You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/06 22:22:11 UTC

[GitHub] [arrow] 0x0L edited a comment on pull request #10562: ARROW-13129: [C#] Fix TableFromRecordBatches

0x0L edited a comment on pull request #10562:
URL: https://github.com/apache/arrow/pull/10562#issuecomment-875115716


   Honestly I find the semantics quite misleading, like the author of TableFromRecordBatches :) IMO these copies are harmless in terms of performance. It also enforces more coherence with the default constructor.
   
   Python does it too: https://github.com/apache/arrow/blob/3ce67ebe6750da22d04e73eab85e484fd29f8264/python/pyarrow/table.pxi#L1591-L1599


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org