[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27665: [SPARK-30623][Core] Spark external shuffle allow disable of separate event loop group

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #27665: [SPARK-30623][Core] Spark external shuffle allow disable of separate event loop group
URL: https://github.com/apache/spark/pull/27665#discussion_r398328411
 
 

 ##########
 File path: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
 ##########
 @@ -339,12 +341,25 @@ public int chunkFetchHandlerThreads() {
       return 0;
     }
     int chunkFetchHandlerThreadsPercent =
-      conf.getInt("spark.shuffle.server.chunkFetchHandlerThreadsPercent", 100);
 
 Review comment:
   What do you mean by `the config must be set`, @xuanyuanking ? What value do you expect by default? Apparently, this is reverting SPARK-25641 without mentioning SPARK-25641. In the PR, only SPARK-24355 is mentioned.
   > No need to give a default value here, when it comes to here, the config must be set.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org