[GitHub] [iceberg] szehon-ho commented on a diff in pull request #7068: Spark 3.3: Use ProcedureInput in AddFilesProcedure

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #7068:
URL: https://github.com/apache/iceberg/pull/7068#discussion_r1132971162


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/ProcedureInput.java:
##########
@@ -167,6 +167,11 @@ public Identifier ident(ProcedureParameter param) {
     return catalogAndIdent.identifier();
   }
 
+  public Identifier ident(ProcedureParameter param, CatalogPlugin defaultCatalog) {

Review Comment:
   I am probably a bit late to comment, but I wanted to note, I think 'defaultCatalog' is a bit confusing here, as ProcedureInput already comes with 'catalog'.  To me, its more of a catalog override, isnt it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org