You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Paul J. Reder (JIRA)" <ji...@apache.org> on 2010/02/24 00:34:27 UTC
[jira] Created: (OWB-300) Currently OWB requires log4j for logging.
This patch provides a means of choosing other loggers.
Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
------------------------------------------------------------------------------------------------
Key: OWB-300
URL: https://issues.apache.org/jira/browse/OWB-300
Project: OpenWebBeans
Issue Type: Improvement
Components: Core
Affects Versions: M4
Environment: All
Reporter: Paul J. Reder
Assignee: Gurkan Erdogdu
Priority: Minor
Fix For: M4
Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers. Notably, the patch switches the logging code to using the JDK java util logging. The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OWB-300) Currently OWB requires log4j for logging.
This patch provides a means of choosing other loggers.
Posted by "Paul J. Reder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul J. Reder updated OWB-300:
------------------------------
Description: Currently OWB requires (is dependent on) log4j for logging. This patch provides a means of choosing other loggers (thus reducing the number of dependencies but allowing flexibility). Notably, the patch switches the logging code to using the JDK java util logging (which is already available for other reasons). The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs. (was: Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers. Notably, the patch switches the logging code to using the JDK java util logging. The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.)
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires (is dependent on) log4j for logging. This patch provides a means of choosing other loggers (thus reducing the number of dependencies but allowing flexibility). Notably, the patch switches the logging code to using the JDK java util logging (which is already available for other reasons). The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-300) Currently OWB requires log4j for
logging. This patch provides a means of choosing other loggers.
Posted by "Paul J. Reder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837857#action_12837857 ]
Paul J. Reder commented on OWB-300:
-----------------------------------
SLF4J does appear to provide support for args and NLS but, as Joe pointed out, those were required to support what OWB currently had and the original motivation for changing to JUL was to reduce the number of dependencies (and overall resources) that OWB required. Adding SLF4J swaps one dependency for another (at minimum - assuming JUL) or adds a new dependency (for SLF4J on top of log4j).
So if consensus is for dependency reduction (per original motivation) then my patch achieves that. If consensus is for adding SLF4J then this issue should probably be closed and pursued via another issue specific to that purpose.
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers. Notably, the patch switches the logging code to using the JDK java util logging. The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-300) Currently OWB requires log4j for
logging. This patch provides a means of choosing other loggers.
Posted by "Joe Bergmark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837831#action_12837831 ]
Joe Bergmark commented on OWB-300:
----------------------------------
Just wanted to provide some history on this. I believe this work item / patch is a result of a discussion earlier this month on the development mailing list here:
http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201002.mbox/%3C4B7D74D9.80307@remulak.net%3E
As part of a discussion around reducing the number of dependency jars required for OWB. I believe Matthias mentioned that MyFaces had also made a switch to using JDK logging recently. Perhaps the abstraction they used in MyFaces was SLF4J or Commons logging?
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers. Notably, the patch switches the logging code to using the JDK java util logging. The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-300) Currently OWB requires log4j for
logging. This patch provides a means of choosing other loggers.
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837568#action_12837568 ]
James Carman commented on OWB-300:
----------------------------------
I would rather see a logging abstraction such as Commons Logging or SLF4J.
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers. Notably, the patch switches the logging code to using the JDK java util logging. The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-300) Currently OWB requires log4j for
logging. This patch provides a means of choosing other loggers.
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837814#action_12837814 ]
James Carman commented on OWB-300:
----------------------------------
So, use SLF4J. Some folks don't like (including myself) using the JDK logging facilities. Using SLF4J allows the code to talk to one abstraction API and the deployment environment to supply whatever implementation they deem necessary (including JDK logging of course).
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers. Notably, the patch switches the logging code to using the JDK java util logging. The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-300) Currently OWB requires log4j for
logging. This patch provides a means of choosing other loggers.
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837867#action_12837867 ]
James Carman commented on OWB-300:
----------------------------------
I understand the whole idea about minimizing dependencies, but let's get real here. If you're using OWB or some other web-based framework, you've already got a boatload of dependencies. Adding SLF4J to the mix does buy you some flexibility, though. What if a project doesn't want to use JUL? What if they want all of their logging to go somewhere else? Having OWB force them to use and configure JUL is a bigger no-no, if you ask me. OWB needs to be flexible for the client environment. With SLF4J, the client project can use whatever logging implementation they wish and SLF4J (and thus OWB) can adapt to it.
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires (is dependent on) log4j for logging. This patch provides a means of choosing other loggers (thus reducing the number of dependencies but allowing flexibility). Notably, the patch switches the logging code to using the JDK java util logging (which is already available for other reasons). The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-300) Currently OWB requires log4j for
logging. This patch provides a means of choosing other loggers.
Posted by "Paul J. Reder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837809#action_12837809 ]
Paul J. Reder commented on OWB-300:
-----------------------------------
I'm not an expert at Commons logging so I may have missed something, but Commons logging does not currently appear to provide embedded support for NLS (one of the main things I've been working to add to OWB logging), and also does not appear to natively support args (they would have to be processed externally before the log call). This would require all the logs to be wrapped in .isXXXEnabled (basically requiring a wrapper of the wrapper) which is basically what we currently have with the WebBeansLogger that I've been enhancing.
My patch allows OWB to be packaged with a minimal set of jars (it uses the exsisting JUL support by default), and shows how the wrapper can be altered to make use of log4j. Other loggers (including the Commons Logger, if you want) can be enabled in similar fashion. This path allows our current OWB logging (with args) to work seamlesslessly, as well as allowing OWB to make use of resource bundles for NLS.
In the future, when Commons Logger natively supports args and NLS the ebBeansLogger can be removed and replaced with the Commons Logger.
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers. Notably, the patch switches the logging code to using the JDK java util logging. The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-300) Currently OWB requires log4j for
logging. This patch provides a means of choosing other loggers.
Posted by "Ceki Gulcu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838322#action_12838322 ]
Ceki Gulcu commented on OWB-300:
--------------------------------
If every framework had its own logging abstraction, the user would need to deal with each separately wasting time and energy.
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires (is dependent on) log4j for logging. This patch provides a means of choosing other loggers (thus reducing the number of dependencies but allowing flexibility). Notably, the patch switches the logging code to using the JDK java util logging (which is already available for other reasons). The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OWB-300) Currently OWB requires log4j for logging.
This patch provides a means of choosing other loggers.
Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gurkan Erdogdu closed OWB-300.
------------------------------
Resolution: Fixed
We will use slf4j instead of implementing our logger facade.
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires (is dependent on) log4j for logging. This patch provides a means of choosing other loggers (thus reducing the number of dependencies but allowing flexibility). Notably, the patch switches the logging code to using the JDK java util logging (which is already available for other reasons). The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OWB-300) Currently OWB requires log4j for logging.
This patch provides a means of choosing other loggers.
Posted by "Paul J. Reder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul J. Reder updated OWB-300:
------------------------------
Attachment: OWBLoggerOnly.patch
The attached patch alters the OWB logger to use the JDK logger instead of log4j.
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers.
> ------------------------------------------------------------------------------------------------
>
> Key: OWB-300
> URL: https://issues.apache.org/jira/browse/OWB-300
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Environment: All
> Reporter: Paul J. Reder
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: M4
>
> Attachments: OWBLoggerOnly.patch
>
>
> Currently OWB requires log4j for logging. This patch provides a means of choosing other loggers. Notably, the patch switches the logging code to using the JDK java util logging. The patch includes comments to show how to maintain log4j use or use it as a model to enable other logging libs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.