You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/02 17:53:55 UTC

[GitHub] [beam] ahmedabu98 opened a new pull request, #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

ahmedabu98 opened a new pull request, #22559:
URL: https://github.com/apache/beam/pull/22559

   Fixes #22558 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on code in PR #22559:
URL: https://github.com/apache/beam/pull/22559#discussion_r964091593


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -73,7 +74,12 @@ public class TableRowToStorageApiProto {
   // The old dremel parser accepts this format, and so does insertall. We need to accept it
   // for backwards compatibility, and it is based on UTC time.
   private static final DateTimeFormatter DATETIME_SPACE_FORMATTER =
-      DateTimeFormatter.ofPattern("uuuu-MM-dd HH:mm:ss.SSSSSS").withZone(ZoneOffset.UTC);
+      new DateTimeFormatterBuilder()

Review Comment:
   No readily available format for the `' '` character. The closest thing is [ISO_LOCAL_DATE_TIME](https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html#ISO_LOCAL_DATE_TIME) but that's for `'T'` between the date and time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] reuvenlax commented on pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
reuvenlax commented on PR #22559:
URL: https://github.com/apache/beam/pull/22559#issuecomment-1229275536

   R: @yirutang could you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #22559:
URL: https://github.com/apache/beam/pull/22559#issuecomment-1203181374

   R: @reuvenlax 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22559:
URL: https://github.com/apache/beam/pull/22559#issuecomment-1203082558

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @lukecwik for label java.
   R: @Abacn for label io.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey merged pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
johnjcasey merged PR #22559:
URL: https://github.com/apache/beam/pull/22559


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #22559:
URL: https://github.com/apache/beam/pull/22559#issuecomment-1203042967

   Run PostCommit_Java_DataflowV2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on a diff in pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
johnjcasey commented on code in PR #22559:
URL: https://github.com/apache/beam/pull/22559#discussion_r956206320


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -73,7 +74,12 @@ public class TableRowToStorageApiProto {
   // The old dremel parser accepts this format, and so does insertall. We need to accept it
   // for backwards compatibility, and it is based on UTC time.
   private static final DateTimeFormatter DATETIME_SPACE_FORMATTER =
-      DateTimeFormatter.ofPattern("uuuu-MM-dd HH:mm:ss.SSSSSS").withZone(ZoneOffset.UTC);
+      new DateTimeFormatterBuilder()

Review Comment:
   Is there a named datetime format for this we could use instead?



##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoTest.java:
##########
@@ -534,6 +556,7 @@ public void testNestedFromTableSchema() {
                   new TableCell().setV("1970-01-01T00:00:00.000+01:00"),
                   new TableCell().setV("1234567"),
                   new TableCell().setV("1970-01-01 00:00:00.000343"),
+                  new TableCell().setV("1970-01-01 00:00:00.123"),

Review Comment:
   can we also have a trailing 0 test case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #22559:
URL: https://github.com/apache/beam/pull/22559#issuecomment-1203125773

   Run PostCommit_Java_DataflowV2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #22559:
URL: https://github.com/apache/beam/pull/22559#issuecomment-1210904671

   R: @chamikaramj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on code in PR #22559:
URL: https://github.com/apache/beam/pull/22559#discussion_r964087529


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoTest.java:
##########
@@ -534,6 +556,7 @@ public void testNestedFromTableSchema() {
                   new TableCell().setV("1970-01-01T00:00:00.000+01:00"),
                   new TableCell().setV("1234567"),
                   new TableCell().setV("1970-01-01 00:00:00.000343"),
+                  new TableCell().setV("1970-01-01 00:00:00.123"),

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #22559: Allowing more flexible precision for TIMESTAMP, DATETIME fields.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22559:
URL: https://github.com/apache/beam/pull/22559#issuecomment-1203182290

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org