You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/12/21 16:29:52 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1228: MINIFICPP-1703 ExecuteScript error handling fix, more docs and tests

szaszm commented on a change in pull request #1228:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1228#discussion_r773279257



##########
File path: extensions/script/python/PythonScriptEngine.h
##########
@@ -57,7 +57,7 @@ struct Interpreter {
 
 Interpreter *getInterpreter();
 
-class PythonScriptEngine : public script::ScriptEngine {
+class __attribute__((visibility("default"))) PythonScriptEngine : public script::ScriptEngine {

Review comment:
       This may not compile on msvc, try doing it with a platform-specific macro.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org