You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (JIRA)" <ji...@apache.org> on 2011/01/24 10:44:44 UTC
[jira] Created: (LUCENE-2882) Cut over SpanQuery#getSpans to
AtomicReaderContext
Cut over SpanQuery#getSpans to AtomicReaderContext
--------------------------------------------------
Key: LUCENE-2882
URL: https://issues.apache.org/jira/browse/LUCENE-2882
Project: Lucene - Java
Issue Type: Task
Affects Versions: 4.0
Reporter: Simon Willnauer
Assignee: Simon Willnauer
Priority: Minor
Fix For: 4.0
Followup from LUCENE-2831 - SpanQuery#getSpans(IR) seems to be the last remaining artifact that doesn't enforce per-segments context while it should really work on AtomicReaderContext (SpanQuery#getSpans(AtomicReaderContext) instead of a naked IR.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2882) Cut over SpanQuery#getSpans to
AtomicReaderContext
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-2882:
------------------------------------
Attachment: LUCENE-2882.patch
here is a patch that cuts over to ARC and cleans up some of the tests to perform span operations per segment
> Cut over SpanQuery#getSpans to AtomicReaderContext
> --------------------------------------------------
>
> Key: LUCENE-2882
> URL: https://issues.apache.org/jira/browse/LUCENE-2882
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2882.patch
>
>
> Followup from LUCENE-2831 - SpanQuery#getSpans(IR) seems to be the last remaining artifact that doesn't enforce per-segments context while it should really work on AtomicReaderContext (SpanQuery#getSpans(AtomicReaderContext) instead of a naked IR.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2882) Cut over SpanQuery#getSpans to
AtomicReaderContext
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985665#action_12985665 ]
Simon Willnauer commented on LUCENE-2882:
-----------------------------------------
Seems like this is an easy one - I will commit shortly
> Cut over SpanQuery#getSpans to AtomicReaderContext
> --------------------------------------------------
>
> Key: LUCENE-2882
> URL: https://issues.apache.org/jira/browse/LUCENE-2882
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2882.patch
>
>
> Followup from LUCENE-2831 - SpanQuery#getSpans(IR) seems to be the last remaining artifact that doesn't enforce per-segments context while it should really work on AtomicReaderContext (SpanQuery#getSpans(AtomicReaderContext) instead of a naked IR.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2882) Cut over SpanQuery#getSpans to
AtomicReaderContext
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985662#action_12985662 ]
Robert Muir commented on LUCENE-2882:
-------------------------------------
looks good to me, thanks for splitting up the cleanup work from the other patch, good idea.
> Cut over SpanQuery#getSpans to AtomicReaderContext
> --------------------------------------------------
>
> Key: LUCENE-2882
> URL: https://issues.apache.org/jira/browse/LUCENE-2882
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2882.patch
>
>
> Followup from LUCENE-2831 - SpanQuery#getSpans(IR) seems to be the last remaining artifact that doesn't enforce per-segments context while it should really work on AtomicReaderContext (SpanQuery#getSpans(AtomicReaderContext) instead of a naked IR.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2882) Cut over SpanQuery#getSpans to
AtomicReaderContext
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer resolved LUCENE-2882.
-------------------------------------
Resolution: Fixed
Committed revision 1062775.
> Cut over SpanQuery#getSpans to AtomicReaderContext
> --------------------------------------------------
>
> Key: LUCENE-2882
> URL: https://issues.apache.org/jira/browse/LUCENE-2882
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2882.patch, LUCENE-2882.patch
>
>
> Followup from LUCENE-2831 - SpanQuery#getSpans(IR) seems to be the last remaining artifact that doesn't enforce per-segments context while it should really work on AtomicReaderContext (SpanQuery#getSpans(AtomicReaderContext) instead of a naked IR.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2882) Cut over SpanQuery#getSpans to
AtomicReaderContext
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-2882:
------------------------------------
Attachment: LUCENE-2882.patch
some more cleanups and CHANGES.TXT entry... will commit in a minute
> Cut over SpanQuery#getSpans to AtomicReaderContext
> --------------------------------------------------
>
> Key: LUCENE-2882
> URL: https://issues.apache.org/jira/browse/LUCENE-2882
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2882.patch, LUCENE-2882.patch
>
>
> Followup from LUCENE-2831 - SpanQuery#getSpans(IR) seems to be the last remaining artifact that doesn't enforce per-segments context while it should really work on AtomicReaderContext (SpanQuery#getSpans(AtomicReaderContext) instead of a naked IR.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org