You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@avalon.apache.org by bl...@apache.org on 2003/04/07 18:47:04 UTC
cvs commit: avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/tools ComponentMetaInfoCollector.java
bloritsch 2003/04/07 09:47:04
Modified: fortress/src/tools/org/apache/avalon/fortress/tools
ComponentMetaInfoCollector.java
Log:
Add support for the "@avalon.service" tag
Revision Changes Path
1.5 +8 -0 avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/tools/ComponentMetaInfoCollector.java
Index: ComponentMetaInfoCollector.java
===================================================================
RCS file: /home/cvs/avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/tools/ComponentMetaInfoCollector.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- ComponentMetaInfoCollector.java 25 Mar 2003 02:00:54 -0000 1.4
+++ ComponentMetaInfoCollector.java 7 Apr 2003 16:47:04 -0000 1.5
@@ -185,6 +185,14 @@
{
m_services.add(javaClass.getFullyQualifiedName());
}
+ else if ( (tag = javaClass.getTagByName( "avalon.service" )) != null )
+ {
+ String className = tag.getValue();
+ if ( null != className && className.length() > 0 )
+ {
+ m_services.add( className );
+ }
+ }
else
{
tag = javaClass.getTagByName( "avalon.component" );
---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@avalon.apache.org
For additional commands, e-mail: cvs-help@avalon.apache.org
Re: cvs commit: avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/tools ComponentMetaInfoCollector.java
Posted by Peter Donald <pe...@realityforge.org>.
On Tue, 8 Apr 2003 07:40, Berin Loritsch wrote:
> Peter Donald wrote:
> > This goes against existing usage patterns.
>
> Explain.
>
> I thought that
> @avalon.service org.apache.excalibur.event.command.Command
>
> was perfectly valid to specify that interface as a role/service.
Old Phoenix style;
@phoenix:service name="org.apache.excalibur.event.command.Command"
New Phoenix style;
@phoenix.service type="Command"
Note that this assumes that Command is resolvable in java file (ie is an
import, is part of java.lang.* package or in current package).
--
Cheers,
Peter Donald
*------------------------------------------------------*
| "Nearly all men can stand adversity, but if you want |
| to test a man's character, give him power." |
| -Abraham Lincoln |
*------------------------------------------------------*
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org
Re: cvs commit: avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/tools
ComponentMetaInfoCollector.java
Posted by Berin Loritsch <bl...@apache.org>.
Peter Royal wrote:
> On Monday, April 7, 2003, at 05:40 PM, Berin Loritsch wrote:
>
>> Peter Donald wrote:
>>
>>> This goes against existing usage patterns.
>>
>>
>> Explain.
>>
>> I thought that
>> @avalon.service org.apache.excalibur.event.command.Command
>>
>> was perfectly valid to specify that interface as a role/service.
>>
>> ALso, I already corrected a bug where that was mutually exclusive
>> with @avalon.component, et. al.
>
>
> Phoenix marks up implementations, not interfaces, with a "service"
> javadoc tag that indicates what interfaces that the component implements
> are services. This lets you use external, predefined interfaces as
> services w/o having to mark them up.
> -pete
And that is what I implemented. So how is that inconsistent with
current usage?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org
Re: cvs commit: avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/tools ComponentMetaInfoCollector.java
Posted by Peter Royal <pr...@apache.org>.
On Monday, April 7, 2003, at 05:40 PM, Berin Loritsch wrote:
> Peter Donald wrote:
>> This goes against existing usage patterns.
>
> Explain.
>
> I thought that
> @avalon.service org.apache.excalibur.event.command.Command
>
> was perfectly valid to specify that interface as a role/service.
>
> ALso, I already corrected a bug where that was mutually exclusive
> with @avalon.component, et. al.
Phoenix marks up implementations, not interfaces, with a "service"
javadoc tag that indicates what interfaces that the component
implements are services. This lets you use external, predefined
interfaces as services w/o having to mark them up.
-pete
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org
Re: cvs commit: avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/tools
ComponentMetaInfoCollector.java
Posted by Berin Loritsch <bl...@apache.org>.
Peter Donald wrote:
> This goes against existing usage patterns.
>
Explain.
I thought that
@avalon.service org.apache.excalibur.event.command.Command
was perfectly valid to specify that interface as a role/service.
ALso, I already corrected a bug where that was mutually exclusive
with @avalon.component, et. al.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org
Re: cvs commit: avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/tools ComponentMetaInfoCollector.java
Posted by Peter Donald <pe...@realityforge.org>.
This goes against existing usage patterns.
On Tue, 8 Apr 2003 02:47, bloritsch@apache.org wrote:
> bloritsch 2003/04/07 09:47:04
>
> Modified: fortress/src/tools/org/apache/avalon/fortress/tools
> ComponentMetaInfoCollector.java
> Log:
> Add support for the "@avalon.service" tag
>
> Revision Changes Path
> 1.5 +8 -0
> avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/tools/Compon
>entMetaInfoCollector.java
>
> Index: ComponentMetaInfoCollector.java
> ===================================================================
> RCS file:
> /home/cvs/avalon-excalibur/fortress/src/tools/org/apache/avalon/fortress/to
>ols/ComponentMetaInfoCollector.java,v retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- ComponentMetaInfoCollector.java 25 Mar 2003 02:00:54 -0000 1.4
> +++ ComponentMetaInfoCollector.java 7 Apr 2003 16:47:04 -0000 1.5
> @@ -185,6 +185,14 @@
> {
> m_services.add(javaClass.getFullyQualifiedName());
> }
> + else if ( (tag = javaClass.getTagByName( "avalon.service" ))
> != null ) + {
> + String className = tag.getValue();
> + if ( null != className && className.length() > 0 )
> + {
> + m_services.add( className );
> + }
> + }
> else
> {
> tag = javaClass.getTagByName( "avalon.component" );
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cvs-unsubscribe@avalon.apache.org
> For additional commands, e-mail: cvs-help@avalon.apache.org
--
Cheers,
Peter Donald
Sufficiently advanced science is
indistinguishable from magic"
-- Arthur C. Clarke
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org