You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kristine Hahn (Code Review)" <ge...@cloudera.org> on 2020/03/16 20:43:18 UTC

[Impala-ASF-CR] IMPALA-9029: [DOCS] Impala 3.4 Release Notes

Kristine Hahn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15451


Change subject: IMPALA-9029: [DOCS] Impala 3.4 Release Notes
......................................................................

IMPALA-9029: [DOCS] Impala 3.4 Release Notes

- Adds features to the end of the new features list: constraints, enhanced external Kudu table, Ranger column masking, Apachi Hudi support, ORC reads enabled

Change-Id: I31e9fcc1e1aa98c784b2c597a6df5aeb75be44c5
---
M docs/topics/impala_new_features.xml
2 files changed, 36 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/15451/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31e9fcc1e1aa98c784b2c597a6df5aeb75be44c5
Gerrit-Change-Number: 15451
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>

[Impala-ASF-CR] IMPALA-9029: [DOCS] Impala 3.4 Release Notes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15451 )

Change subject: IMPALA-9029: [DOCS] Impala 3.4 Release Notes
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/559/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31e9fcc1e1aa98c784b2c597a6df5aeb75be44c5
Gerrit-Change-Number: 15451
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Mar 2020 20:51:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9029: [DOCS] Impala 3.4 Release Notes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15451 )

Change subject: IMPALA-9029: [DOCS] Impala 3.4 Release Notes
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/559/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/15451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31e9fcc1e1aa98c784b2c597a6df5aeb75be44c5
Gerrit-Change-Number: 15451
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Mar 2020 20:43:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9029: [DOCS] Impala 3.4 Release Notes

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/15451 )

Change subject: IMPALA-9029: [DOCS] Impala 3.4 Release Notes
......................................................................


Abandoned

The release notes got merged in a separate change.
-- 
To view, visit http://gerrit.cloudera.org:8080/15451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I31e9fcc1e1aa98c784b2c597a6df5aeb75be44c5
Gerrit-Change-Number: 15451
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9029: [DOCS] Impala 3.4 Release Notes

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15451 )

Change subject: IMPALA-9029: [DOCS] Impala 3.4 Release Notes
......................................................................


Patch Set 1:

You can abandon this change, now that it is addressed in the other review.


-- 
To view, visit http://gerrit.cloudera.org:8080/15451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31e9fcc1e1aa98c784b2c597a6df5aeb75be44c5
Gerrit-Change-Number: 15451
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Mar 2020 18:27:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9029: [DOCS] Impala 3.4 Release Notes

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15451 )

Change subject: IMPALA-9029: [DOCS] Impala 3.4 Release Notes
......................................................................


Patch Set 1:

Two things:
1. Can we add a line to impala_new_features.xml saying that we added support for ZSTD and DEFLATE compression codecs for text files?
2. From a git perspective, this is using a pattern that I'm not used to. We use cherrypicks rather than merge commands. Here's how I would like the change to proceed:
 - Cherrypick Alex's original change on top of current master branch (see dropdown "Download" on the right side and copy the cherrypick command). For me the command is:
git fetch ssh://joemcdonnell@gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/14863/1 && git cherry-pick FETCH_HEAD
 - Make your changes on top of it. Do git add / git commit, then "git rebase origin/master -i" and fixup your new commit with Alex's original commit. Reword the commit message if needed. Leave the Change-Id the same.
 - Then upload that to gerrit with "git push --no-thin asf-gerrit HEAD:refs/for/master". That should do an upload to Alex's original review.
If any of that doesn't make sense, reach out to me and I can help you through it.


-- 
To view, visit http://gerrit.cloudera.org:8080/15451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31e9fcc1e1aa98c784b2c597a6df5aeb75be44c5
Gerrit-Change-Number: 15451
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Mar 2020 22:34:18 +0000
Gerrit-HasComments: No