You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@depot.apache.org by mm...@apache.org on 2004/07/12 18:04:22 UTC
svn commit: rev 22843 - incubator/depot/trunk/update/src/java/org/apache/depot/update/repository
Author: mmay
Date: Mon Jul 12 11:04:21 2004
New Revision: 22843
Modified:
incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java
Log:
The method listArtifacts is pretty much useless, it uses an
recursion, which equals an endless loop.
Modified: incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java
==============================================================================
--- incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java (original)
+++ incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java Mon Jul 12 11:04:21 2004
@@ -115,6 +115,11 @@
setRepositoryAttribute(RepositoryAttribute.ACTIVE, Flag.TRUE);
}
+ /**
+ * this method should not be called right now, it provides a dangerous recursion
+ *
+ * @deprecated this method is useless
+ */
public List listArtifacts(
ArtifactUpdaterContext context,
ArtifactGroup group,
@@ -122,8 +127,10 @@
throws Exception {
List results = null;
+
+// :TODO: useless recursion - calls the same method with the input parameters
List artifacts = listArtifacts(context, group, selector);
-
+
if (!artifacts.isEmpty()) {
List unique =
ComparisonHelper.sortUnique(