You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mymeiyi (via GitHub)" <gi...@apache.org> on 2025/05/28 02:03:47 UTC
[PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
mymeiyi opened a new pull request, #51301:
URL: https://github.com/apache/doris/pull/51301
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3026209422
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2914659399
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2968758296
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2938398722
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2984523688
<details>
<summary>ClickBench: <b>Total hot run time: 29.18 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d8bc877b66391b592136431ce1161e1be78236d6, data reload: false
query1 0.03 0.03 0.02
query2 0.09 0.03 0.04
query3 0.23 0.06 0.06
query4 1.66 0.10 0.10
query5 0.42 0.40 0.41
query6 1.17 0.66 0.65
query7 0.02 0.02 0.01
query8 0.04 0.03 0.04
query9 0.57 0.51 0.51
query10 0.57 0.58 0.57
query11 0.15 0.11 0.11
query12 0.15 0.11 0.12
query13 0.62 0.61 0.61
query14 0.79 0.83 0.81
query15 0.89 0.87 0.86
query16 0.38 0.38 0.39
query17 1.04 1.02 1.05
query18 0.22 0.21 0.21
query19 1.97 1.82 1.84
query20 0.01 0.01 0.01
query21 15.39 0.89 0.54
query22 0.76 1.35 0.71
query23 14.72 1.36 0.63
query24 7.44 2.13 0.60
query25 0.49 0.32 0.06
query26 0.60 0.16 0.14
query27 0.06 0.04 0.04
query28 9.15 0.89 0.46
query29 12.53 3.91 3.27
query30 0.25 0.08 0.06
query31 2.84 0.61 0.39
query32 3.23 0.58 0.48
query33 3.04 3.10 3.18
query34 15.90 5.36 4.76
query35 4.83 4.81 4.81
query36 0.68 0.50 0.49
query37 0.09 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.02 0.02
query40 0.18 0.14 0.14
query41 0.08 0.02 0.02
query42 0.03 0.03 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.43 s
Total hot run time: 29.18 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3045877937
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/4f1b863369aeab919104ab5eb3c9078b1799409c_4f1b863369aeab919104ab5eb3c9078b1799409c/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/4f1b863369aeab919104ab5eb3c9078b1799409c_4f1b863369aeab919104ab5eb3c9078b1799409c/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 57.32% (15500/27039) |
| Line Coverage | 46.30% (140863/304247) |
| Region Coverage | 45.56% (71234/156356) |
| Branch Coverage | 40.27% (37530/93200) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3035102540
# Cloud UT Coverage Report
Increment line coverage `88.89% (112/126)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3_95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3_95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 82.93% (1219/1470) |
| Line Coverage | 67.57% (21058/31165) |
| Region Coverage | 67.31% (10499/15597) |
| Branch Coverage | 56.70% (5504/9708) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2984504932
<details>
<summary>TPC-DS: <b>Total hot run time: 185311 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d8bc877b66391b592136431ce1161e1be78236d6, data reload: false
query1 991 405 399 399
query2 6538 1845 1816 1816
query3 6743 235 223 223
query4 26033 23648 23231 23231
query5 4332 601 467 467
query6 315 216 196 196
query7 4630 496 287 287
query8 269 234 223 223
query9 8649 2634 2632 2632
query10 520 341 272 272
query11 15742 14996 14942 14942
query12 162 112 107 107
query13 1657 536 410 410
query14 9186 6093 6064 6064
query15 193 197 194 194
query16 7207 631 469 469
query17 1210 723 552 552
query18 1961 411 305 305
query19 182 180 152 152
query20 120 133 114 114
query21 230 123 108 108
query22 4236 4202 4050 4050
query23 33912 32890 33197 32890
query24 8446 2362 2341 2341
query25 541 457 411 411
query26 1249 265 154 154
query27 2771 506 343 343
query28 4331 2135 2117 2117
query29 774 566 429 429
query30 291 221 202 202
query31 976 846 751 751
query32 74 59 62 59
query33 557 381 314 314
query34 796 848 527 527
query35 782 803 741 741
query36 940 972 875 875
query37 107 98 77 77
query38 4044 4163 3994 3994
query39 1515 1424 1410 1410
query40 211 117 106 106
query41 61 61 57 57
query42 121 118 110 110
query43 498 489 477 477
query44 1306 836 829 829
query45 176 175 173 173
query46 844 1018 619 619
query47 1764 1793 1722 1722
query48 385 414 309 309
query49 750 486 386 386
query50 639 668 413 413
query51 4186 4239 4061 4061
query52 105 104 98 98
query53 224 254 188 188
query54 566 579 500 500
query55 84 83 81 81
query56 314 287 276 276
query57 1187 1186 1116 1116
query58 268 262 267 262
query59 2534 2635 2595 2595
query60 346 331 339 331
query61 128 128 123 123
query62 803 728 651 651
query63 226 187 185 185
query64 4337 1002 665 665
query65 4257 4162 4166 4162
query66 1141 412 338 338
query67 16068 15637 15354 15354
query68 7822 875 535 535
query69 466 357 270 270
query70 1184 1142 1043 1043
query71 422 315 299 299
query72 5723 4736 4808 4736
query73 661 608 353 353
query74 9271 9370 8877 8877
query75 3577 3179 2710 2710
query76 3440 1193 771 771
query77 756 387 304 304
query78 10027 10117 9360 9360
query79 2031 826 572 572
query80 582 504 439 439
query81 501 259 220 220
query82 458 128 97 97
query83 245 244 232 232
query84 251 105 86 86
query85 805 360 310 310
query86 330 295 284 284
query87 4426 4332 4374 4332
query88 3703 2322 2261 2261
query89 377 317 282 282
query90 1952 209 208 208
query91 142 144 109 109
query92 77 61 58 58
query93 1533 980 593 593
query94 719 408 267 267
query95 374 290 283 283
query96 484 559 278 278
query97 2688 2744 2616 2616
query98 230 211 210 210
query99 1380 1408 1281 1281
Total cold run time: 273378 ms
Total hot run time: 185311 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2984902569
# BE Regression && UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/51301_d8bc877b66391b592136431ce1161e1be78236d6_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/51301_d8bc877b66391b592136431ce1161e1be78236d6_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 61.06% (16048/26284) |
| Line Coverage | 50.55% (150764/298248) |
| Region Coverage | 47.85% (86135/179998) |
| Branch Coverage | 41.39% (42330/102274) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2938633625
<details>
<summary>ClickBench: <b>Total hot run time: 28.89 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fe98460dae72a208039ee2d1392dc75279f1ec2a, data reload: false
query1 0.03 0.04 0.03
query2 0.14 0.11 0.11
query3 0.25 0.20 0.19
query4 1.60 0.19 0.19
query5 0.47 0.47 0.45
query6 1.17 0.67 0.66
query7 0.02 0.01 0.02
query8 0.04 0.04 0.04
query9 0.60 0.51 0.51
query10 0.57 0.59 0.58
query11 0.15 0.11 0.11
query12 0.15 0.12 0.11
query13 0.62 0.59 0.59
query14 0.80 0.81 0.80
query15 0.89 0.86 0.89
query16 0.40 0.40 0.38
query17 1.04 1.06 1.09
query18 0.22 0.22 0.21
query19 1.96 1.82 1.83
query20 0.01 0.02 0.02
query21 15.44 0.92 0.53
query22 0.76 1.32 0.69
query23 14.75 1.40 0.61
query24 6.80 2.11 0.36
query25 0.31 0.32 0.12
query26 0.59 0.17 0.14
query27 0.06 0.05 0.06
query28 9.95 0.94 0.45
query29 12.53 4.07 3.41
query30 0.26 0.11 0.06
query31 2.81 0.61 0.39
query32 3.23 0.57 0.47
query33 3.02 3.12 3.05
query34 15.62 5.09 4.51
query35 4.51 4.52 4.51
query36 0.68 0.50 0.49
query37 0.08 0.07 0.07
query38 0.06 0.04 0.03
query39 0.03 0.02 0.02
query40 0.17 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 102.94 s
Total hot run time: 28.89 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2938837411
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/fe98460dae72a208039ee2d1392dc75279f1ec2a_fe98460dae72a208039ee2d1392dc75279f1ec2a/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/fe98460dae72a208039ee2d1392dc75279f1ec2a_fe98460dae72a208039ee2d1392dc75279f1ec2a/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 56.18% (15052/26791) |
| Line Coverage | 44.98% (134316/298594) |
| Region Coverage | 44.10% (67579/153246) |
| Branch Coverage | 38.64% (34621/89590) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3035568525
<details>
<summary>TPC-DS: <b>Total hot run time: 184572 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3, data reload: false
query1 1005 391 379 379
query2 6545 1778 1745 1745
query3 6740 218 219 218
query4 26179 23768 22953 22953
query5 4333 582 419 419
query6 311 216 183 183
query7 4631 492 272 272
query8 268 220 198 198
query9 8612 2601 2632 2601
query10 441 329 267 267
query11 15499 15139 14891 14891
query12 156 113 103 103
query13 1661 530 410 410
query14 8606 5665 5511 5511
query15 196 189 163 163
query16 7118 620 450 450
query17 935 710 555 555
query18 1973 420 297 297
query19 188 200 169 169
query20 114 119 109 109
query21 212 123 104 104
query22 4338 4257 4252 4252
query23 34049 33194 33136 33136
query24 8499 2401 2330 2330
query25 549 454 395 395
query26 1236 274 143 143
query27 2765 510 335 335
query28 4291 2153 2132 2132
query29 778 556 424 424
query30 283 217 198 198
query31 919 859 733 733
query32 69 70 60 60
query33 586 367 310 310
query34 803 879 525 525
query35 795 807 698 698
query36 938 983 894 894
query37 109 98 74 74
query38 4083 4163 4046 4046
query39 1484 1407 1422 1407
query40 203 115 101 101
query41 55 52 49 49
query42 120 110 106 106
query43 501 516 465 465
query44 1302 827 809 809
query45 176 170 162 162
query46 837 1010 620 620
query47 1740 1828 1708 1708
query48 372 448 305 305
query49 731 483 379 379
query50 624 677 412 412
query51 4175 4209 4058 4058
query52 110 102 101 101
query53 219 251 181 181
query54 563 575 494 494
query55 86 78 82 78
query56 315 293 285 285
query57 1173 1202 1095 1095
query58 261 251 253 251
query59 2717 2759 2718 2718
query60 337 311 297 297
query61 120 118 116 116
query62 825 742 658 658
query63 225 178 188 178
query64 4428 1128 748 748
query65 4262 4212 4175 4175
query66 1169 421 320 320
query67 15736 15711 15507 15507
query68 7922 896 527 527
query69 499 320 267 267
query70 1221 1087 1071 1071
query71 460 325 302 302
query72 5791 4706 4469 4469
query73 672 576 348 348
query74 9057 9036 9189 9036
query75 3781 3170 2669 2669
query76 3498 1134 710 710
query77 774 373 296 296
query78 10020 10123 9359 9359
query79 2368 812 581 581
query80 680 505 437 437
query81 474 256 225 225
query82 420 122 97 97
query83 282 248 233 233
query84 297 98 82 82
query85 772 340 303 303
query86 331 307 301 301
query87 4394 4375 4346 4346
query88 3532 2279 2287 2279
query89 383 315 278 278
query90 1914 209 202 202
query91 148 136 109 109
query92 73 58 56 56
query93 1364 943 587 587
query94 675 411 313 313
query95 374 278 276 276
query96 492 577 276 276
query97 2770 2784 2617 2617
query98 224 213 206 206
query99 1468 1417 1249 1249
Total cold run time: 272809 ms
Total hot run time: 184572 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3045584426
<details>
<summary>ClickBench: <b>Total hot run time: 29.86 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4f1b863369aeab919104ab5eb3c9078b1799409c, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.05
query3 0.24 0.08 0.07
query4 1.62 0.11 0.12
query5 0.43 0.44 0.42
query6 1.18 0.66 0.65
query7 0.02 0.02 0.01
query8 0.05 0.03 0.03
query9 0.61 0.51 0.52
query10 0.57 0.58 0.57
query11 0.16 0.11 0.11
query12 0.15 0.12 0.12
query13 0.62 0.60 0.62
query14 0.80 0.87 0.80
query15 0.91 0.85 0.86
query16 0.40 0.40 0.40
query17 1.09 1.06 1.05
query18 0.24 0.21 0.21
query19 2.23 1.88 1.86
query20 0.01 0.01 0.01
query21 15.37 0.94 0.54
query22 0.75 1.16 0.70
query23 14.89 1.39 0.63
query24 6.82 0.97 1.66
query25 0.49 0.20 0.12
query26 0.64 0.17 0.13
query27 0.07 0.06 0.05
query28 9.10 0.98 0.45
query29 12.53 3.96 3.27
query30 0.25 0.09 0.07
query31 2.83 0.58 0.38
query32 3.23 0.56 0.49
query33 3.07 3.08 3.12
query34 16.01 5.49 4.84
query35 4.87 4.87 4.86
query36 0.67 0.51 0.50
query37 0.10 0.07 0.06
query38 0.06 0.04 0.04
query39 0.03 0.03 0.02
query40 0.17 0.14 0.13
query41 0.08 0.02 0.03
query42 0.03 0.03 0.02
query43 0.04 0.04 0.04
Total cold run time: 103.55 s
Total hot run time: 29.86 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2965977624
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2984461311
<details>
<summary>TPC-H: <b>Total hot run time: 34066 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d8bc877b66391b592136431ce1161e1be78236d6, data reload: false
------ Round 1 ----------------------------------
q1 17594 5141 4987 4987
q2 1942 285 190 190
q3 10380 1414 739 739
q4 10250 1001 524 524
q5 8182 2436 2328 2328
q6 191 167 134 134
q7 912 739 642 642
q8 9323 1305 1117 1117
q9 6897 5101 5124 5101
q10 6896 2374 1977 1977
q11 477 296 275 275
q12 344 347 207 207
q13 17793 3675 3113 3113
q14 237 224 209 209
q15 570 480 495 480
q16 428 456 381 381
q17 635 877 386 386
q18 7726 7117 7240 7117
q19 1546 955 552 552
q20 347 347 220 220
q21 4119 3358 2413 2413
q22 1051 977 974 974
Total cold run time: 107840 ms
Total hot run time: 34066 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5092 4975 5028 4975
q2 244 320 226 226
q3 2196 2666 2294 2294
q4 1329 1789 1337 1337
q5 4254 4260 4446 4260
q6 212 169 131 131
q7 2041 1884 1738 1738
q8 2637 2511 2561 2511
q9 7263 7128 7103 7103
q10 3087 3251 2884 2884
q11 592 506 505 505
q12 676 747 595 595
q13 3440 3908 3290 3290
q14 279 304 291 291
q15 514 469 477 469
q16 440 491 445 445
q17 1176 1599 1374 1374
q18 7878 7439 7252 7252
q19 830 886 1045 886
q20 1976 2103 1884 1884
q21 4968 4551 4301 4301
q22 1065 987 957 957
Total cold run time: 52189 ms
Total hot run time: 49708 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3045566842
<details>
<summary>TPC-DS: <b>Total hot run time: 186119 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4f1b863369aeab919104ab5eb3c9078b1799409c, data reload: false
query1 1018 385 397 385
query2 6536 1702 1681 1681
query3 6750 212 211 211
query4 26161 23644 22857 22857
query5 4328 573 440 440
query6 299 224 200 200
query7 4626 494 289 289
query8 271 224 212 212
query9 8624 2623 2624 2623
query10 448 334 273 273
query11 15741 15127 14967 14967
query12 162 110 111 110
query13 1669 532 409 409
query14 8505 5930 5757 5757
query15 209 207 174 174
query16 7476 431 253 253
query17 1345 703 567 567
query18 1984 405 297 297
query19 193 184 160 160
query20 125 120 114 114
query21 215 132 101 101
query22 4090 4276 4510 4276
query23 35035 33877 33500 33500
query24 8462 2349 2356 2349
query25 506 448 376 376
query26 1234 263 150 150
query27 2773 496 341 341
query28 4316 2117 2079 2079
query29 764 540 417 417
query30 281 217 192 192
query31 918 825 761 761
query32 72 61 57 57
query33 534 325 281 281
query34 784 846 508 508
query35 614 658 558 558
query36 903 980 903 903
query37 106 97 75 75
query38 4218 4174 4051 4051
query39 1502 1404 1405 1404
query40 212 116 100 100
query41 53 55 49 49
query42 121 107 114 107
query43 492 476 469 469
query44 1294 801 817 801
query45 173 166 164 164
query46 835 1018 631 631
query47 1761 1807 1711 1711
query48 410 434 313 313
query49 754 485 408 408
query50 635 690 415 415
query51 4121 4212 4224 4212
query52 111 105 99 99
query53 227 242 181 181
query54 578 564 505 505
query55 81 82 81 81
query56 280 291 298 291
query57 1171 1209 1137 1137
query58 265 251 254 251
query59 2584 2661 2695 2661
query60 322 321 310 310
query61 128 116 123 116
query62 806 711 681 681
query63 225 181 184 181
query64 4388 1235 813 813
query65 4258 4166 4198 4166
query66 1117 418 297 297
query67 15923 15508 15580 15508
query68 7818 919 534 534
query69 566 320 274 274
query70 1201 1125 1063 1063
query71 427 325 288 288
query72 5536 4727 4866 4727
query73 658 627 354 354
query74 9203 9012 8692 8692
query75 3398 3189 2679 2679
query76 3314 1169 717 717
query77 565 376 292 292
query78 10808 11021 10220 10220
query79 1789 893 637 637
query80 639 519 426 426
query81 482 247 218 218
query82 197 123 96 96
query83 251 250 239 239
query84 248 106 88 88
query85 791 360 309 309
query86 367 315 283 283
query87 4597 4491 4425 4425
query88 2944 2286 2307 2286
query89 385 320 289 289
query90 1823 217 208 208
query91 135 145 108 108
query92 67 60 56 56
query93 1158 978 596 596
query94 625 323 198 198
query95 371 290 289 289
query96 517 570 278 278
query97 2672 2751 2721 2721
query98 225 203 213 203
query99 1306 1437 1310 1310
Total cold run time: 272205 ms
Total hot run time: 186119 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #51301:
URL: https://github.com/apache/doris/pull/51301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2939003697
# BE Regression && UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/51301_fe98460dae72a208039ee2d1392dc75279f1ec2a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/51301_fe98460dae72a208039ee2d1392dc75279f1ec2a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.51% (20969/26372) |
| Line Coverage | 72.57% (216606/298491) |
| Region Coverage | 70.79% (127470/180058) |
| Branch Coverage | 64.49% (66006/102350) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3035056559
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3045528875
<details>
<summary>TPC-H: <b>Total hot run time: 33230 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4f1b863369aeab919104ab5eb3c9078b1799409c, data reload: false
------ Round 1 ----------------------------------
q1 17622 5163 5039 5039
q2 1962 283 197 197
q3 10373 1343 724 724
q4 10253 1074 517 517
q5 7816 2339 2418 2339
q6 193 162 125 125
q7 889 740 628 628
q8 9319 1311 1237 1237
q9 7004 5147 5141 5141
q10 6876 2381 1954 1954
q11 486 288 266 266
q12 338 347 209 209
q13 17786 3693 3075 3075
q14 230 247 218 218
q15 538 488 468 468
q16 437 423 365 365
q17 605 877 345 345
q18 7562 7331 7035 7035
q19 1321 986 542 542
q20 332 345 217 217
q21 3712 2511 2292 2292
q22 354 324 297 297
Total cold run time: 106008 ms
Total hot run time: 33230 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5127 5243 5087 5087
q2 242 327 219 219
q3 2182 2665 2318 2318
q4 1348 1772 1284 1284
q5 4241 4337 4575 4337
q6 219 170 123 123
q7 2017 1954 1811 1811
q8 2649 2620 2544 2544
q9 7500 7304 7256 7256
q10 3164 3358 2889 2889
q11 571 510 483 483
q12 695 789 629 629
q13 3635 3978 3367 3367
q14 307 325 271 271
q15 521 479 476 476
q16 452 491 449 449
q17 1195 1689 1386 1386
q18 7959 7613 7587 7587
q19 827 896 1141 896
q20 2011 2096 1996 1996
q21 5276 4506 4558 4506
q22 677 585 564 564
Total cold run time: 52815 ms
Total hot run time: 50478 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2938625392
<details>
<summary>TPC-DS: <b>Total hot run time: 186093 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fe98460dae72a208039ee2d1392dc75279f1ec2a, data reload: false
query1 1028 487 521 487
query2 6576 1879 1852 1852
query3 6764 234 229 229
query4 26831 23775 22932 22932
query5 4342 654 474 474
query6 291 213 190 190
query7 4627 523 287 287
query8 278 233 208 208
query9 8564 2589 2623 2589
query10 476 346 300 300
query11 15351 15117 14920 14920
query12 160 110 110 110
query13 1655 534 409 409
query14 8907 6561 6300 6300
query15 208 211 175 175
query16 7215 637 511 511
query17 1210 740 590 590
query18 1988 399 304 304
query19 202 191 186 186
query20 128 121 124 121
query21 226 129 112 112
query22 4000 4131 4016 4016
query23 34145 33013 33357 33013
query24 8426 2419 2444 2419
query25 546 472 416 416
query26 1228 270 151 151
query27 2741 541 356 356
query28 4292 2121 2090 2090
query29 779 577 441 441
query30 281 225 191 191
query31 912 876 775 775
query32 73 66 66 66
query33 562 364 306 306
query34 828 881 537 537
query35 788 817 739 739
query36 945 966 898 898
query37 116 100 82 82
query38 4111 4108 4101 4101
query39 1464 1428 1394 1394
query40 214 129 114 114
query41 71 62 58 58
query42 122 110 110 110
query43 512 537 496 496
query44 1354 820 817 817
query45 186 177 172 172
query46 855 1027 644 644
query47 1744 1784 1706 1706
query48 386 421 309 309
query49 734 484 391 391
query50 694 701 401 401
query51 4141 4219 4135 4135
query52 122 108 105 105
query53 229 269 191 191
query54 596 582 515 515
query55 88 83 87 83
query56 337 327 320 320
query57 1119 1153 1082 1082
query58 267 268 260 260
query59 2624 2724 2537 2537
query60 342 331 320 320
query61 130 144 129 129
query62 835 756 665 665
query63 229 195 201 195
query64 4379 1010 713 713
query65 4285 4184 4156 4156
query66 1144 419 324 324
query67 16173 15546 15689 15546
query68 8007 895 525 525
query69 480 309 283 283
query70 1216 1135 1072 1072
query71 486 343 295 295
query72 5629 4740 4814 4740
query73 702 615 351 351
query74 9334 9124 8727 8727
query75 3908 3212 2699 2699
query76 3762 1221 813 813
query77 777 405 288 288
query78 10026 10123 9348 9348
query79 2925 830 583 583
query80 679 554 481 481
query81 549 259 227 227
query82 447 128 100 100
query83 293 251 234 234
query84 300 115 93 93
query85 815 377 317 317
query86 390 305 268 268
query87 4451 4463 4324 4324
query88 3761 2262 2271 2262
query89 394 323 291 291
query90 1917 216 216 216
query91 149 147 113 113
query92 78 65 60 60
query93 2243 985 576 576
query94 672 409 309 309
query95 381 297 292 292
query96 493 560 280 280
query97 2690 2745 2668 2668
query98 245 229 207 207
query99 1470 1424 1280 1280
Total cold run time: 276845 ms
Total hot run time: 186093 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2984203913
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2918039074
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2938465241
# Cloud UT Coverage Report
Increment line coverage `88.89% (112/126)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/fe98460dae72a208039ee2d1392dc75279f1ec2a_fe98460dae72a208039ee2d1392dc75279f1ec2a_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/fe98460dae72a208039ee2d1392dc75279f1ec2a_fe98460dae72a208039ee2d1392dc75279f1ec2a_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.32% (1119/1343) |
| Line Coverage | 66.90% (19173/28659) |
| Region Coverage | 66.57% (9499/14270) |
| Branch Coverage | 56.48% (5148/9114) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "zhannngchen (via GitHub)" <gi...@apache.org>.
zhannngchen commented on code in PR #51301:
URL: https://github.com/apache/doris/pull/51301#discussion_r2115264947
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -3011,7 +3021,7 @@ void MetaServiceImpl::remove_delete_bitmap_update_lock_v2(
msg = "failed to init txn";
return;
}
- if (request->lock_id() == COMPACTION_DELETE_BITMAP_LOCK_ID) {
+ if (is_job_delete_bitmap_lock_id(request->lock_id())) {
std::string tablet_compaction_key =
mow_tablet_compaction_key({instance_id, request->table_id(), request->initiator()});
Review Comment:
the lock key should not use `compaction` any more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2984293024
# Cloud UT Coverage Report
Increment line coverage `88.89% (112/126)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/d8bc877b66391b592136431ce1161e1be78236d6_d8bc877b66391b592136431ce1161e1be78236d6_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/d8bc877b66391b592136431ce1161e1be78236d6_d8bc877b66391b592136431ce1161e1be78236d6_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.31% (1123/1348) |
| Line Coverage | 66.98% (19384/28938) |
| Region Coverage | 66.75% (9619/14411) |
| Branch Coverage | 56.67% (5228/9226) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3044695558
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2938604120
<details>
<summary>TPC-H: <b>Total hot run time: 34154 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fe98460dae72a208039ee2d1392dc75279f1ec2a, data reload: false
------ Round 1 ----------------------------------
q1 26548 5116 5080 5080
q2 1987 279 196 196
q3 10348 1277 769 769
q4 10245 1014 551 551
q5 7616 2399 2390 2390
q6 192 166 136 136
q7 924 761 634 634
q8 9325 1247 1141 1141
q9 6848 5105 5134 5105
q10 6897 2335 1888 1888
q11 505 298 267 267
q12 350 362 223 223
q13 17778 3802 3066 3066
q14 235 232 214 214
q15 580 495 482 482
q16 431 435 369 369
q17 606 878 376 376
q18 7798 7201 7066 7066
q19 1607 984 604 604
q20 346 355 230 230
q21 3837 3260 2426 2426
q22 1050 1026 941 941
Total cold run time: 116053 ms
Total hot run time: 34154 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5321 5013 5162 5013
q2 240 319 223 223
q3 2177 2692 2281 2281
q4 1446 1822 1461 1461
q5 4583 4472 4443 4443
q6 221 169 129 129
q7 2003 1968 1767 1767
q8 2609 2524 2506 2506
q9 7166 7210 7052 7052
q10 3020 3197 2742 2742
q11 570 533 491 491
q12 708 775 619 619
q13 3672 3968 3351 3351
q14 279 293 281 281
q15 530 469 480 469
q16 446 487 480 480
q17 1183 1615 1354 1354
q18 7703 7424 7518 7424
q19 845 845 911 845
q20 1977 2068 1912 1912
q21 4716 4489 4230 4230
q22 1076 1026 1003 1003
Total cold run time: 52491 ms
Total hot run time: 50076 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3026571322
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/c6f2534005d4356f38290f0a91cf059a62750b21_c6f2534005d4356f38290f0a91cf059a62750b21/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/c6f2534005d4356f38290f0a91cf059a62750b21_c6f2534005d4356f38290f0a91cf059a62750b21/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 57.12% (15373/26913) |
| Line Coverage | 46.16% (139503/302217) |
| Region Coverage | 45.47% (70690/155482) |
| Branch Coverage | 40.23% (37323/92776) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3044695459
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3045344383
# Cloud UT Coverage Report
Increment line coverage `88.89% (112/126)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/4f1b863369aeab919104ab5eb3c9078b1799409c_4f1b863369aeab919104ab5eb3c9078b1799409c_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/4f1b863369aeab919104ab5eb3c9078b1799409c_4f1b863369aeab919104ab5eb3c9078b1799409c_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.03% (1223/1473) |
| Line Coverage | 67.68% (21218/31351) |
| Region Coverage | 67.44% (10576/15682) |
| Branch Coverage | 56.77% (5567/9806) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3035806304
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3_95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3_95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 57.24% (15451/26994) |
| Line Coverage | 46.17% (140063/303353) |
| Region Coverage | 45.51% (70946/155899) |
| Branch Coverage | 40.24% (37407/92954) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2984893124
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/d8bc877b66391b592136431ce1161e1be78236d6_d8bc877b66391b592136431ce1161e1be78236d6/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/d8bc877b66391b592136431ce1161e1be78236d6_d8bc877b66391b592136431ce1161e1be78236d6/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 56.34% (15049/26709) |
| Line Coverage | 45.10% (134596/298409) |
| Region Coverage | 44.24% (67690/153016) |
| Branch Coverage | 38.82% (34729/89464) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3035594277
<details>
<summary>ClickBench: <b>Total hot run time: 30.08 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3, data reload: false
query1 0.04 0.03 0.03
query2 0.11 0.06 0.06
query3 0.28 0.06 0.06
query4 1.61 0.08 0.07
query5 0.43 0.41 0.40
query6 1.15 0.66 0.65
query7 0.03 0.02 0.02
query8 0.05 0.05 0.05
query9 0.64 0.52 0.51
query10 0.57 0.60 0.56
query11 0.26 0.13 0.13
query12 0.25 0.14 0.13
query13 0.65 0.63 0.63
query14 0.80 0.82 0.81
query15 0.97 0.89 0.88
query16 0.38 0.38 0.37
query17 1.08 1.12 1.06
query18 0.24 0.22 0.23
query19 2.00 1.84 1.88
query20 0.01 0.02 0.01
query21 15.37 0.96 0.66
query22 0.93 1.01 0.79
query23 14.70 1.52 0.74
query24 5.46 0.57 0.28
query25 0.17 0.09 0.08
query26 0.56 0.22 0.18
query27 0.08 0.08 0.09
query28 11.04 1.18 0.58
query29 12.53 4.04 3.40
query30 0.28 0.08 0.06
query31 2.86 0.62 0.42
query32 3.23 0.60 0.52
query33 3.10 3.11 3.21
query34 16.70 5.46 4.75
query35 4.86 4.81 4.78
query36 0.65 0.50 0.50
query37 0.20 0.18 0.18
query38 0.18 0.17 0.15
query39 0.05 0.04 0.04
query40 0.20 0.16 0.17
query41 0.10 0.05 0.05
query42 0.06 0.04 0.05
query43 0.06 0.04 0.05
Total cold run time: 104.92 s
Total hot run time: 30.08 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3035506869
<details>
<summary>TPC-H: <b>Total hot run time: 34673 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95f67ccb053a3e9bec4baef6e2c5ac94b1221ca3, data reload: false
------ Round 1 ----------------------------------
q1 17628 5369 5223 5223
q2 1931 288 180 180
q3 10379 1432 719 719
q4 10239 1117 518 518
q5 7815 2455 2631 2455
q6 203 171 129 129
q7 955 760 590 590
q8 9313 1543 1287 1287
q9 7017 5361 5349 5349
q10 6948 2407 1969 1969
q11 498 288 278 278
q12 355 390 215 215
q13 17817 3797 3037 3037
q14 227 228 203 203
q15 549 472 473 472
q16 430 420 385 385
q17 616 922 367 367
q18 7963 7191 7081 7081
q19 1233 1105 586 586
q20 341 378 223 223
q21 4227 3236 2426 2426
q22 1094 1031 981 981
Total cold run time: 107778 ms
Total hot run time: 34673 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5410 5421 5399 5399
q2 254 332 228 228
q3 2208 2705 2326 2326
q4 1422 1836 1358 1358
q5 4811 4557 4556 4556
q6 263 189 131 131
q7 2107 1986 1748 1748
q8 2910 2860 2812 2812
q9 7312 7375 7285 7285
q10 3201 3379 2865 2865
q11 609 516 472 472
q12 725 810 624 624
q13 3615 4169 3202 3202
q14 302 338 323 323
q15 518 470 479 470
q16 464 503 430 430
q17 1285 1770 1471 1471
q18 8147 7762 7652 7652
q19 1044 903 957 903
q20 2037 2068 1837 1837
q21 4908 4375 4254 4254
q22 1121 1070 983 983
Total cold run time: 54673 ms
Total hot run time: 51329 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3026247156
# Cloud UT Coverage Report
Increment line coverage `88.89% (112/126)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/c6f2534005d4356f38290f0a91cf059a62750b21_c6f2534005d4356f38290f0a91cf059a62750b21_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/c6f2534005d4356f38290f0a91cf059a62750b21_c6f2534005d4356f38290f0a91cf059a62750b21_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 82.82% (1186/1432) |
| Line Coverage | 67.44% (20725/30733) |
| Region Coverage | 67.17% (10314/15356) |
| Branch Coverage | 56.44% (5389/9548) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "zhannngchen (via GitHub)" <gi...@apache.org>.
zhannngchen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-3045214672
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2914678457
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2914700349
# Cloud UT Coverage Report
Increment line coverage `93.55% (29/31)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/34454d65d7a82d5eefbf8cdf53d85ce9b8fb69c7_34454d65d7a82d5eefbf8cdf53d85ce9b8fb69c7_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/34454d65d7a82d5eefbf8cdf53d85ce9b8fb69c7_34454d65d7a82d5eefbf8cdf53d85ce9b8fb69c7_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.26% (1114/1338) |
| Line Coverage | 66.27% (18716/28240) |
| Region Coverage | 65.95% (9293/14090) |
| Branch Coverage | 55.75% (5004/8976) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](mow) refactor mow update lock for schema change to reduce txn conflict [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #51301:
URL: https://github.com/apache/doris/pull/51301#issuecomment-2918054651
# Cloud UT Coverage Report
Increment line coverage `92.86% (26/28)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60da61b08de8e85ff2da27465f80793621f21322_60da61b08de8e85ff2da27465f80793621f21322_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60da61b08de8e85ff2da27465f80793621f21322_60da61b08de8e85ff2da27465f80793621f21322_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.27% (1115/1339) |
| Line Coverage | 66.59% (18847/28301) |
| Region Coverage | 66.29% (9352/14107) |
| Branch Coverage | 56.17% (5046/8984) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org