You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/26 14:22:31 UTC

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1473: IGNITE-18220: Implement integration tests for completers

PakhomovAlexander commented on code in PR #1473:
URL: https://github.com/apache/ignite-3/pull/1473#discussion_r1057256638


##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/CliCommandTestNotInitializedIntegrationBase.java:
##########
@@ -106,6 +107,10 @@ protected void execute(String... args) {
         exitCode = cmd.execute(args);
     }
 
+    protected CommandLine getCmd() {

Review Comment:
   I wouldn't like to give an access to fields event for children. But I could rename the method to `cmd()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org