You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (Created) (JIRA)" <ji...@apache.org> on 2011/11/29 11:49:39 UTC
[jira] [Created] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Remove columns shadowed by a deleted container even when we cannot purge
------------------------------------------------------------------------
Key: CASSANDRA-3538
URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Priority: Trivial
Fix For: 1.0.5
Attachments: 3538.patch
During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3538:
----------------------------------------
Attachment: 3538.patch
> Remove columns shadowed by a deleted container even when we cannot purge
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-3538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0.6
>
> Attachments: 3538.patch
>
>
> During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161667#comment-13161667 ]
Sylvain Lebresne commented on CASSANDRA-3538:
---------------------------------------------
It is definitively only an optimization, which LCR does use because it calls Precompacted.removeDeletedAndOldShards, but not EchoedRow indeed. And even if not a life changer, it's still an optimization. But I would be very fine with putting this in trunk only if we don't want to take any risks.
> Remove columns shadowed by a deleted container even when we cannot purge
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-3538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0.6
>
> Attachments: 3538.patch
>
>
> During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3538:
----------------------------------------
Attachment: (was: 3538.patch)
> Remove columns shadowed by a deleted container even when we cannot purge
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-3538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0.6
>
> Attachments: 3538.patch
>
>
> During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161708#comment-13161708 ]
Hudson commented on CASSANDRA-3538:
-----------------------------------
Integrated in Cassandra #1231 (See [https://builds.apache.org/job/Cassandra/1231/])
Remove columns shadowed by a deleted container even when we cannot purge
patch by slebresne; reviewed by jbellis for CASSANDRA-3538
slebresne : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1209530
Files :
* /cassandra/trunk/CHANGES.txt
* /cassandra/trunk/src/java/org/apache/cassandra/db/compaction/PrecompactedRow.java
> Remove columns shadowed by a deleted container even when we cannot purge
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-3538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.1
>
> Attachments: 3538.patch
>
>
> During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161654#comment-13161654 ]
Jonathan Ellis commented on CASSANDRA-3538:
-------------------------------------------
Taking a step back... what about LCR and EchoedRow? Is it worth doing this if it's only a "sometimes" behavior?
> Remove columns shadowed by a deleted container even when we cannot purge
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-3538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0.6
>
> Attachments: 3538.patch
>
>
> During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161434#comment-13161434 ]
Jonathan Ellis commented on CASSANDRA-3538:
-------------------------------------------
gcBefore of MAX_VALUE means "collect *all* tombstones," don't you want MIN_VALUE here? And if so, it sounds like we should add a test that catches the difference.
> Remove columns shadowed by a deleted container even when we cannot purge
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-3538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0.6
>
> Attachments: 3538.patch
>
>
> During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161646#comment-13161646 ]
Sylvain Lebresne commented on CASSANDRA-3538:
---------------------------------------------
You're right, I meant MIN_VALUE. Patch updated. Turns out I was a bit quick and my previous patch wasn't passing all unit tests because we already have a test that verify that we don't purge tombstones when it shouldn't. As for testing this patch, it's actually tricky because normal query already remove columns that are shadowed by a tombstones, making it hard to test.
> Remove columns shadowed by a deleted container even when we cannot purge
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-3538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0.6
>
> Attachments: 3538.patch
>
>
> During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161669#comment-13161669 ]
Jonathan Ellis commented on CASSANDRA-3538:
-------------------------------------------
+1 trunk only.
> Remove columns shadowed by a deleted container even when we cannot purge
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-3538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0.6
>
> Attachments: 3538.patch
>
>
> During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3538) Remove columns shadowed by a
deleted container even when we cannot purge
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3538:
----------------------------------------
Attachment: 3538.patch
> Remove columns shadowed by a deleted container even when we cannot purge
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-3538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3538
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0.5
>
> Attachments: 3538.patch
>
>
> During compaction, if shouldPurge == false, we don't do anything with the column family. It is however ok to remove columns for with their container is deleted with a timestamp greater than their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira