You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/15 19:47:40 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
dongjoon-hyun commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594635612
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3986,4 +3986,13 @@ class SQLConf extends Serializable with Logging {
def isModifiable(key: String): Boolean = {
sqlConfEntries.containsKey(key) && !staticConfKeys.contains(key)
}
+
+ /**
+ * Return all non-static configuration
+ */
+ def getAllNonStaticConfs(): Map[String, String] = {
Review comment:
When do we need to declare this additional function? This PR shows the modified configs by comparing the value between `sessionState.conf` and `globalConfigs`. For the static configs, the values are the same already, aren't they?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3986,4 +3986,13 @@ class SQLConf extends Serializable with Logging {
def isModifiable(key: String): Boolean = {
sqlConfEntries.containsKey(key) && !staticConfKeys.contains(key)
}
+
+ /**
+ * Return all non-static configuration
+ */
+ def getAllNonStaticConfs(): Map[String, String] = {
Review comment:
When do we need this additional function? This PR shows the modified configs by comparing the value between `sessionState.conf` and `globalConfigs`. For the static configs, the values are the same already, aren't they?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org