Re: [PR] [SPARK-60057] Add `suspendReason` to `Suspended` states [spark-kubernetes-operator]

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #954:
URL: https://github.com/apache/spark-kubernetes-operator/pull/954#discussion_r4212402516


##########
spark-operator/src/test/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/AppSuspendStepTest.java:
##########
@@ -734,6 +740,26 @@ void suspendingEvictedAppIsRecorded() {
     Assertions.assertNull(getWorkload());
   }
 
+  @Test
+  void evictionIsToldByTheSuspendReasonRatherThanByTheMessage() {

Review Comment:
   Thank you for the review and the suggestion. Verifying the persisted field across an operator restart in E2E makes sense. I'll add that E2E coverage separately in a follow-up, since it needs to restart the operator in the Kueue scenarios.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org