[GitHub] [incubator-mxnet] stephenrawls commented on issue #17292: Can't run horovod with latest nightly wheel

[GitBox <gi...@apache.org>]

stephenrawls commented on issue #17292: Can't run horovod with latest nightly wheel
URL: https://github.com/apache/incubator-mxnet/issues/17292#issuecomment-573948848
 
 
   Saw this on email list and got curious...
   
   
   Looks like problem is probably this commit:
   https://github.com/apache/incubator-mxnet/commit/4ed14e2b749743a014121f57b265675fa7b4c06d#diff-875aa4c013dbd73b044531e439e8afdd
   
   Basically `MXAPIHandleException` used to be defined inline in the header file, so all consumers had to do was 
   ```
   #include <mxnet/c_api_error.h>
   ```
   
   But now as of 3 days ago it is not an inline function anymore. Meaning that consumers need to make sure to link against c_api_error.o to get the symbol.
   
   I don't know enough about the build system that produces these nightly builds (does it use the CMake one or the Makefile one?) ... but my hunch would be that either c_api_error.o is not getting built into libmxnet.so. Or somehow it is, but the order it is presented to the linker is before MXAPIHandleException is used, so that symbol isn't included in libmxnet.so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services