You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/01/29 09:54:40 UTC
[GitHub] [incubator-linkis] aleneZeng opened a new pull request #1353: create resultSet path by jvmuser,fix issue 1314
aleneZeng opened a new pull request #1353:
URL: https://github.com/apache/incubator-linkis/pull/1353
### What is the purpose of the change
fix the issue 1314,
before this fixing , wds.linkis.resultSet.store.path is created by task launcher by default ,it would cause another task launcher failed to write on this path.
### Brief change log
(for example:)
1,only add one line in linkis-computation-governance/linkis-entrance/src/main/java/org/apache/linkis/entrance/job/EntranceExecutionJob
2,when execute job, create wds.linkis.resultSet.store.path in hdfs by jvmuser if it not exists
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- Anything that affects deployment: no
- The MGS(Microservice Governance Services),no
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] aleneZeng commented on pull request #1353: create resultSet path by jvmuser,fix issue 1314
Posted by GitBox <gi...@apache.org>.
aleneZeng commented on pull request #1353:
URL: https://github.com/apache/incubator-linkis/pull/1353#issuecomment-1025027666
> Thank you, is it better to create and authorize in the install script, because jvm user may not have permission to create this directory
yes, it is better to collect all this kind of paths and create them in install script as an improvement.
I can create a feature for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] aleneZeng closed pull request #1353: create resultSet path by jvmuser,fix issue 1314
Posted by GitBox <gi...@apache.org>.
aleneZeng closed pull request #1353:
URL: https://github.com/apache/incubator-linkis/pull/1353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] aleneZeng edited a comment on pull request #1353: create resultSet path by jvmuser,fix issue 1314
Posted by GitBox <gi...@apache.org>.
aleneZeng edited a comment on pull request #1353:
URL: https://github.com/apache/incubator-linkis/pull/1353#issuecomment-1025027666
yes, it is better to collect all this kind of paths and create them in install script.
I can create a feature for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on pull request #1353: create resultSet path by jvmuser,fix issue 1314
Posted by GitBox <gi...@apache.org>.
peacewong commented on pull request #1353:
URL: https://github.com/apache/incubator-linkis/pull/1353#issuecomment-1024888178
Thank you, is it better to create and authorize in the install script, because jvm user may not have permission to create this directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] aleneZeng commented on pull request #1353: create resultSet path by jvmuser,fix issue 1314
Posted by GitBox <gi...@apache.org>.
aleneZeng commented on pull request #1353:
URL: https://github.com/apache/incubator-linkis/pull/1353#issuecomment-1032174815
ok,close this pull request and will fix it in install script
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on pull request #1353: create resultSet path by jvmuser,fix issue 1314
Posted by GitBox <gi...@apache.org>.
peacewong commented on pull request #1353:
URL: https://github.com/apache/incubator-linkis/pull/1353#issuecomment-1031023068
> yes, it is better to collect all this kind of paths and create them in install script. what is your suggestion? we can discard this pull request and I give a paths list to you guys to help me check whether they are ok to create in install script; or we can merge this pull request and I open another feature to do improvement in install script? If all paths are created in install scripts or java code, we can avoid so many problems about path privileges.
Thank you, I suggest to close this pr, because if there is no permission, it may cause the interface call to fail. It is more reasonable to modify it in the installation script. You can refer to the creation methods of other directories.
[install.sh](https://github.com/apache/incubator-linkis/blob/master/assembly-combined-package/bin/install.sh)
```
######################## init hdfs and db ################################
if [ "$HDFS_USER_ROOT_PATH" != "" ]
then
localRootDir=$HDFS_USER_ROOT_PATH
if [[ $HDFS_USER_ROOT_PATH == file://* ]];then
localRootDir=${HDFS_USER_ROOT_PATH#file://}
mkdir -p $localRootDir/$deployUser
sudo chmod -R 775 $localRootDir/$deployUser
elif [[ $HDFS_USER_ROOT_PATH == hdfs://* ]];then
localRootDir=${HDFS_USER_ROOT_PATH#hdfs://}
hdfs dfs -mkdir -p $localRootDir/$deployUser
else
echo "does not support $HDFS_USER_ROOT_PATH filesystem types"
fi
fi
isSuccess "create $HDFS_USER_ROOT_PATH directory"
if [ "$RESULT_SET_ROOT_PATH" != "" ]
then
localRootDir=$RESULT_SET_ROOT_PATH
if [[ $RESULT_SET_ROOT_PATH == file://* ]];then
localRootDir=${RESULT_SET_ROOT_PATH#file://}
mkdir -p $localRootDir/$deployUser
sudo chmod -R 775 $localRootDir/$deployUser
elif [[ $RESULT_SET_ROOT_PATH == hdfs://* ]];then
localRootDir=${RESULT_SET_ROOT_PATH#hdfs://}
hdfs dfs -mkdir -p $localRootDir/$deployUser
else
echo "does not support $RESULT_SET_ROOT_PATH filesystem types"
fi
fi
isSuccess "create $RESULT_SET_ROOT_PATH directory"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] aleneZeng edited a comment on pull request #1353: create resultSet path by jvmuser,fix issue 1314
Posted by GitBox <gi...@apache.org>.
aleneZeng edited a comment on pull request #1353:
URL: https://github.com/apache/incubator-linkis/pull/1353#issuecomment-1025027666
yes, it is better to collect all this kind of paths and create them in install script.
what is your suggestion? we can discard this pull request and I give a paths list to you guys to help me check whether they are ok to create in install script; or we can merge this pull request and I open another feature to do improvement in install script?
If all paths are created in install scripts or java code, we can avoid so many problems about path privileges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org