You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/10/26 16:09:05 UTC
[GitHub] incubator-brooklyn pull request: Ignore Groovy plugin in Eclipse b...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/989
Ignore Groovy plugin in Eclipse build
The changes allow the project to be imported in vanilla "Eclipse for Java Developers" install without using additional plugins.
Also upgrades the groovy related dependencies to latest release.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn ignore-groovy-eclipse
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/989.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #989
----
commit 56a9eb8b76f0e8c67169fe4c2372e0486aba5f8f
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-10-26T14:11:57Z
Ignore testCompile phase in Eclipse so the Groovy plugin is not required
commit e030bb31a600ad7ecf0c8c921ca73b75ab287459
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-10-26T14:26:30Z
Upgrade groovy compiler to latest release
commit a24e58e7c89bf12bf5b4da54b5c9b7a842cf6fea
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-10-26T15:07:58Z
Update docs to reflect that Groovy plugin is no longer needed in Eclipse
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Ignore Groovy plugin in Eclipse b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Ignore Groovy plugin in Eclipse b...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/989#issuecomment-151439925
LGTM. But I suggest we figure out if #962 is being corrected or reverted (see comments there) before fixing the merge conflict, unless this one is urgent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Ignore Groovy plugin in Eclipse b...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/989#issuecomment-151321781
Reviewed, looks good, simple actually. Opened the project in Luna, all ok.
There is a merge conflict because of the properties moving in #962 into the root pom.xml (from parent/pom.xml). That's I think the only really minor issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Ignore Groovy plugin in Eclipse b...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/989#issuecomment-151322057
Forgot to mention, these changes seem to address all of @aledsage 's comments from #984 if I am not mistaken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---