You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Phil Hartley (JIRA)" <ji...@apache.org> on 2007/09/24 22:28:37 UTC
[jira] Created: (WW-2204) The package referenced in the JFreeChart
plugin struts-plugin.xml should extend struts-default
The package referenced in the JFreeChart plugin struts-plugin.xml should extend struts-default
----------------------------------------------------------------------------------------------
Key: WW-2204
URL: https://issues.apache.org/struts/browse/WW-2204
Project: Struts 2
Issue Type: Bug
Components: Plugins
Affects Versions: 2.0.9
Environment: All environments
Reporter: Phil Hartley
Because the package jfreechart-default does not extend struts-default, you cannot, for example, send parameters with a request for a chart and have them automatically set in the action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WW-2204) The package referenced in the JFreeChart
plugin struts-plugin.xml should extend struts-default
Posted by "Tom Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom Schneider closed WW-2204.
-----------------------------
Resolution: Fixed
Assignee: Tom Schneider
I think we're relatively safe in making this change. Right now, if you extend the jfreechart package, your actions don't get any default stack and none of the default interceptors. I also added this change to the jasperreports plugin. I didn't do this for the spring plugin because I don't think too many people are using the spring package. It only defines 2 interceptors so it's relatively easy to add those to your own package.
> The package referenced in the JFreeChart plugin struts-plugin.xml should extend struts-default
> ----------------------------------------------------------------------------------------------
>
> Key: WW-2204
> URL: https://issues.apache.org/struts/browse/WW-2204
> Project: Struts 2
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.9
> Environment: All environments
> Reporter: Phil Hartley
> Assignee: Tom Schneider
> Fix For: 2.1.1
>
>
> Because the package jfreechart-default does not extend struts-default, you cannot, for example, send parameters with a request for a chart and have them automatically set in the action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2204) The package referenced in the
JFreeChart plugin struts-plugin.xml should extend struts-default
Posted by "Phil Hartley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42251 ]
Phil Hartley commented on WW-2204:
----------------------------------
I modified the struts-plugin.xml in the JAR file to extend struts-default as follows:
<struts>
<package name="jfreechart-default" extends="struts-default">
<result-types>
<result-type name="chart" class="org.apache.struts2.dispatcher.ChartResult">
<param name="height">150</param>
<param name="width">200</param>
</result-type>
</result-types>
</package>
</struts>
> The package referenced in the JFreeChart plugin struts-plugin.xml should extend struts-default
> ----------------------------------------------------------------------------------------------
>
> Key: WW-2204
> URL: https://issues.apache.org/struts/browse/WW-2204
> Project: Struts 2
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.9
> Environment: All environments
> Reporter: Phil Hartley
>
> Because the package jfreechart-default does not extend struts-default, you cannot, for example, send parameters with a request for a chart and have them automatically set in the action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2204) The package referenced in the
JFreeChart plugin struts-plugin.xml should extend struts-default
Posted by "Phil Hartley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42284 ]
Phil Hartley commented on WW-2204:
----------------------------------
I honestly can't see how this can break anything. In fact, I really think it's a bug: without the extends="struts-default" you cannot send parameters with a request and hope that they get populated in your action correctly. My vote is to make the change.
> The package referenced in the JFreeChart plugin struts-plugin.xml should extend struts-default
> ----------------------------------------------------------------------------------------------
>
> Key: WW-2204
> URL: https://issues.apache.org/struts/browse/WW-2204
> Project: Struts 2
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.9
> Environment: All environments
> Reporter: Phil Hartley
> Fix For: 2.0.12
>
>
> Because the package jfreechart-default does not extend struts-default, you cannot, for example, send parameters with a request for a chart and have them automatically set in the action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2204) The package referenced in the JFreeChart
plugin struts-plugin.xml should extend struts-default
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Holmes updated WW-2204:
-----------------------------
Fix Version/s: 2.0.12
I'm not sure what the ramifications are to this. Is there a reason we didn't already have it done this way perhaps?
I'm happy to make the change, but I don't use the JFreeChart plugin currently and don't want to potentially break something.
> The package referenced in the JFreeChart plugin struts-plugin.xml should extend struts-default
> ----------------------------------------------------------------------------------------------
>
> Key: WW-2204
> URL: https://issues.apache.org/struts/browse/WW-2204
> Project: Struts 2
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.9
> Environment: All environments
> Reporter: Phil Hartley
> Fix For: 2.0.12
>
>
> Because the package jfreechart-default does not extend struts-default, you cannot, for example, send parameters with a request for a chart and have them automatically set in the action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2204) The package referenced in the JFreeChart
plugin struts-plugin.xml should extend struts-default
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Husted updated WW-2204:
---------------------------
Flags: [Patch]
Fix Version/s: (was: 2.1.2)
2.1.1
> The package referenced in the JFreeChart plugin struts-plugin.xml should extend struts-default
> ----------------------------------------------------------------------------------------------
>
> Key: WW-2204
> URL: https://issues.apache.org/struts/browse/WW-2204
> Project: Struts 2
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.9
> Environment: All environments
> Reporter: Phil Hartley
> Fix For: 2.1.1
>
>
> Because the package jfreechart-default does not extend struts-default, you cannot, for example, send parameters with a request for a chart and have them automatically set in the action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.