[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #690: OAK-9913 : added metrics for mongo document store throttling feature

[GitBox <gi...@apache.org>]

rishabhdaim commented on code in PR #690:
URL: https://github.com/apache/jackrabbit-oak/pull/690#discussion_r967205008


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/CreateMetricUpdater.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.jackrabbit.oak.plugins.document.util;
+
+import org.apache.jackrabbit.oak.plugins.document.Collection;
+import org.apache.jackrabbit.oak.plugins.document.Document;
+import org.apache.jackrabbit.oak.plugins.document.DocumentStore;
+import org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsCollector;
+import org.apache.jackrabbit.oak.stats.MeterStats;
+import org.apache.jackrabbit.oak.stats.TimerStats;
+
+import java.util.List;
+import java.util.function.BiPredicate;
+import java.util.function.Predicate;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Abstract class to update the metrics for {@link DocumentStoreStatsCollector#doneCreate(long, Collection, List, boolean)} for underlying {@link DocumentStore}
+ *
+ * <p>Concrete implementations provide instances of {@link MeterStats}, {@link TimerStats} based on whether throttling is ongoing or not
+ */
+public abstract class CreateMetricUpdater {
+
+    private final MeterStats createNodeMeter;
+    private final MeterStats createSplitNodeMeter;
+    private final TimerStats createNodeTimer;
+    private final MeterStats createJournal;
+    private final TimerStats createJournalTimer;
+
+    public CreateMetricUpdater(final MeterStats createNodeMeter,
+                               final MeterStats createSplitNodeMeter,
+                               final TimerStats createNodeTimer,
+                               final MeterStats createJournal,
+                               final TimerStats createJournalTimer) {
+        this.createNodeMeter = createNodeMeter;
+        this.createSplitNodeMeter = createSplitNodeMeter;
+        this.createNodeTimer = createNodeTimer;
+        this.createJournal = createJournal;
+        this.createJournalTimer = createJournalTimer;
+    }
+
+    public void update(final Collection<? extends Document> collection, final long timeTakenNanos,
+                       final List<String> ids, final boolean insertSuccess,
+                       final BiPredicate<Collection<? extends Document>, Integer> isNodesCollectionUpdated,
+                       final CreateStatsConsumer<MeterStats, MeterStats, TimerStats> createStatsConsumer,
+                       final Predicate<Collection<? extends Document>> isJournalCollection,
+                       final StatsConsumer<MeterStats, TimerStats> journalStatsConsumer) {
+
+        requireNonNull(isNodesCollectionUpdated);
+        requireNonNull(isJournalCollection);
+        requireNonNull(createStatsConsumer);
+        requireNonNull(journalStatsConsumer);
+
+        if (isNodesCollectionUpdated.test(collection, ids.size()) && insertSuccess) {
+            createStatsConsumer.accept(createNodeMeter, createSplitNodeMeter, createNodeTimer, ids, timeTakenNanos);
+        } else if (isJournalCollection.test(collection)) {
+            journalStatsConsumer.accept(createJournal, createJournalTimer, ids.size(), timeTakenNanos);
+        }
+    }
+
+    public static class CreateMetricUpdaterWithoutThrottling extends CreateMetricUpdater {

Review Comment:
   I have created 2 implementations for each updater (abstract) class, one with & other without throttling.
   
   Their implementations only differ in metrics that are passed into their respective constructors.
   So the one with throttling has metrics with throttling and the other without (as is the case with their respective names). Rest everything is identical.
   
   In this way, I can reuse the code in the base updater class, while using different metrics based on whether or not throttling is going on.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org