You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/06 21:25:15 UTC
[GitHub] [incubator-mxnet] r3stl355 opened a new pull request #19095: [1.x] Backport of #19078
r3stl355 opened a new pull request #19095:
URL: https://github.com/apache/incubator-mxnet/pull/19095
## Description ##
Backport of https://github.com/apache/incubator-mxnet/pull/19078 to v1.x (solves https://github.com/apache/incubator-mxnet/issues/18886)
## Checklist ##
### Essentials ###
- [X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [X] Changes are complete (i.e. I finished coding on this PR)
- [X] All changes have test coverage
- [X] Code is well-documented
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19095: [1.x] Backport of #19078
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19095:
URL: https://github.com/apache/incubator-mxnet/pull/19095#issuecomment-687921167
@r3stl355 thanks for backporting! remember to add back the part for text processing as it's still available in contrib on 1.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19095: [1.x] Backport of #19078
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19095:
URL: https://github.com/apache/incubator-mxnet/pull/19095#issuecomment-687905751
Hey @r3stl355 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, unix-gpu, miscellaneous, centos-cpu, windows-cpu, edge, unix-cpu, sanity, centos-gpu, clang, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19095: [1.x] Backport of #19078
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19095:
URL: https://github.com/apache/incubator-mxnet/pull/19095#issuecomment-689676641
You can suggest the inclusion in https://github.com/apache/incubator-mxnet/issues/18800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19095: [1.x] Backport of #19078
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19095:
URL: https://github.com/apache/incubator-mxnet/pull/19095#issuecomment-688093404
> @szha thanks, yes, I realised that at some point after submitting the PR. I still need to figure out how to run all the tests locally, doing `nosetests tests/python/unittest/` segfaults and crashes Python on my Mac
This seems to be a common request. I recently shared some of it in https://github.com/apache/incubator-mxnet/pull/18997#issuecomment-683217771, though I think we likely need to expand a bit more and add in https://github.com/apache/incubator-mxnet/blob/master/docs/static_site/src/pages/community/code_guide.md#testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19095: [1.x] Backport of #19078
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19095:
URL: https://github.com/apache/incubator-mxnet/pull/19095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19095: [1.x] Backport of #19078
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19095:
URL: https://github.com/apache/incubator-mxnet/pull/19095#issuecomment-688088081
@szha thanks, yes, I realised that at some point after submitting the PR. I still need to figure out how to run all the tests locally, doing `nosetests tests/python/unittest/` segfaults and crashes Python on my Mac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19095: [1.x] Backport of #19078
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19095:
URL: https://github.com/apache/incubator-mxnet/pull/19095#issuecomment-689471614
@szha - do you want to merge this before the 1.8 release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19095: [1.x] Backport of #19078
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19095:
URL: https://github.com/apache/incubator-mxnet/pull/19095#issuecomment-688105145
Great, I'll try to make it run on my machine and update the docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org