You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Bruno Busco (JIRA)" <ji...@apache.org> on 2010/04/18 10:08:26 UTC
[jira] Closed: (OFBIZ-3708) Fields should be defined with span not
div. (radio, date, lookup)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco closed OFBIZ-3708.
------------------------------
Assignee: Bruno Busco
Resolution: Fixed
Thank you Blas,
thank you Adam and Adrian for reviews.
Blas,
your patch is in trunk at revision: 935312
> Fields should be defined with span not div. (radio, date, lookup)
> -----------------------------------------------------------------
>
> Key: OFBIZ-3708
> URL: https://issues.apache.org/jira/browse/OFBIZ-3708
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff
>
>
> Field markup should be a valid inline element.
> Defining fields with div (block) instead of span (inline) creates several problems:
> - Missalignments in screen. (See LOOKUP_CAL screenshots)
> - Implies a end-of-line after the div. (See CAL screenshots)
> - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log)
> Because this is a markup problem, it spans to all the themes.
> This patch contains 2 files in the framework/widget area and 5 in the themes area.
> Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira