[GitHub] [nuttx] donghengqaz commented on a diff in pull request #8783: xtensa/esp32: Tasks use PSRAM as stack can do SPI flash read/write/erase/map/unmap

["donghengqaz (via GitHub)" <gi...@apache.org>]

donghengqaz commented on code in PR #8783:
URL: https://github.com/apache/nuttx/pull/8783#discussion_r1143268345


##########
arch/xtensa/src/esp32/esp32_spiflash.c:
##########
@@ -170,6 +183,27 @@ struct spiflash_cachestate_s
   uint32_t val[CONFIG_SMP_NCPUS];
 };
 
+#ifdef CONFIG_ESP32_SPI_FLASH_SUPPORT_PSRAM_STACK
+/* SPI flash work operation arguments */
+
+struct spiflash_work_arg
+{
+  enum spiflash_op_code_e op_code;
+
+  struct
+  {
+    struct esp32_spiflash_s *priv;
+    uint32_t addr;
+    uint8_t *buffer;
+    uint32_t size;
+  } op_arg;
+
+  int ret;

Review Comment:
   Why here needs volatile ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org