You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2021/12/17 10:33:16 UTC
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret opened a new pull request #89: SLING-10095 - Surface latest content package extractor error in the e…
tmaret opened a new pull request #89:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/89
…xception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on pull request #89: SLING-10095 - Surface latest content package extractor error in the e…
Posted by GitBox <gi...@apache.org>.
tmaret commented on pull request #89:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/89#issuecomment-996755205
Moved the relevant part of the exception in https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal] cschneider commented on pull request #89: SLING-10095 - Surface latest content package extractor error in the e…
Posted by GitBox <gi...@apache.org>.
cschneider commented on pull request #89:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/89#issuecomment-996657893
Apart from the inlining I think it is good. I can understand that having the installPackage method before was not necessary but now that we do a lot more I think we should not inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on pull request #89: SLING-10095 - Surface latest content package extractor error in the e…
Posted by GitBox <gi...@apache.org>.
tmaret commented on pull request #89:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/89#issuecomment-996638971
https://issues.apache.org/jira/browse/INFRA-22627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on pull request #89: SLING-10095 - Surface latest content package extractor error in the e…
Posted by GitBox <gi...@apache.org>.
tmaret commented on pull request #89:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/89#issuecomment-996632088
Sonar cloud marked the release instable, apparently because it failed to run the Java version installed
```
+ mvn -U clean verify sonar:sonar -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache -Dsonar.projectKey=apache_sling-org-apache-sling-distribution-journal -Pjacoco-report -Dsonar.coverage.jacoco.xmlReportPaths=target/site/jacoco-merged/jacoco.xml -Dsonar.pullrequest.branch=SLING-10095 -Dsonar.pullrequest.base=master -Dsonar.pullrequest.key=89 -Pci
----- withMaven Wrapper script -----
/home/jenkins/tools/maven/latest3/bin/mvn: 194: exec: /home/jenkins/tools/java/latest11/bin/java: Exec format error
```
https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-distribution-journal/detail/PR-89/2/pipeline/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret edited a comment on pull request #89: SLING-10095 - Surface latest content package extractor error in the e…
Posted by GitBox <gi...@apache.org>.
tmaret edited a comment on pull request #89:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/89#issuecomment-996696062
Thanks @cschneider. Inlining is not a matter of taste here. The purpose is to reduce useless entries in the logs such that deployments that cap the size of exported logs don't end up missing the relevant part. I'll clarify the note in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on pull request #89: SLING-10095 - Surface latest content package extractor error in the e…
Posted by GitBox <gi...@apache.org>.
tmaret commented on pull request #89:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/89#issuecomment-996696062
Thanks @cschneider. Inlining is not a matter of taste here. The purpose is to reduce useless entries in the logs such that deployments that cap the size of exported logs don't end up missing the relevant part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret closed pull request #89: SLING-10095 - Surface latest content package extractor error in the e…
Posted by GitBox <gi...@apache.org>.
tmaret closed pull request #89:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org