[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4061: ARTEMIS-3808 support start/stop embedded web server via mngmnt

[GitBox <gi...@apache.org>]

jbertram commented on code in PR #4061:
URL: https://github.com/apache/activemq-artemis/pull/4061#discussion_r863094171


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java:
##########
@@ -1971,5 +1971,11 @@ void replay(@Parameter(name = "startScanDate", desc = "Start date where we will
                @Parameter(name = "address", desc = "Name of the address to replay") String address,
                @Parameter(name = "target", desc = "Where the replay data should be sent") String target,
                @Parameter(name = "filter", desc = "Filter to apply on message selection. Null means everything matching the address") String filter) throws Exception;
+
+   @Operation(desc = "stop the embedded web server", impact = MBeanOperationInfo.ACTION)
+   void stopEmbeddedWebServer() throws Exception;

Review Comment:
   With the current change, if you were using the web console to stop the embedded web server then you'd have to use something _other_ than the web console to start it again (e.g. JConsole, Jolokia, etc.). However, it does make sense to have a method to both stop & start it. The user experience would certainly be better with that method in most circumstances. I'll add that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org