You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/09/16 08:23:13 UTC
[GitHub] [incubator-mxnet] mozga-intel opened a new pull request #20582: [Master] Zero initialization to avoid error message on a Centos
mozga-intel opened a new pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582
## Description ##
Zero initialization (**) to avoid error message on a Centos: error: [-Werror=maybe-uninitialized] is used to allows the user to selectively enable or disable certain types of diagnostics, and change the kind of the diagnostic. A Centos has shown an error message that `'*((void*)& param +129)'` may be used uninitialized in this function - as follows:
```Shell
/work/mxnet/src/api/operator/numpy/random/../../../../operator/numpy/random/np_choice_op.h:43:8: error: '*((void*)& param +129)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
[2021-09-03T20:41:39.011Z] struct NumpyChoiceParam : public dmlc::Parameter<NumpyChoiceParam> {
[2021-09-03T20:41:39.011Z] ^~~~~~~~~~~~~~~~
[2021-09-03T20:41:39.011Z] /work/mxnet/src/api/operator/numpy/random/np_choice_op.cc:40:24: note: '*((void*)& param +129)' was declared here
[2021-09-03T20:41:39.011Z] op::NumpyChoiceParam param;
```
(**) Following the [doc](https://en.cppreference.com/w/cpp/language/zero_initialization):
> As part of value-initialization sequence for non-class types and for members of value-initialized class types that have no constructors, including value initialization of elements of aggregates for which no initializers are provided.
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20582: [Master] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-921805955
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20582: [master][bugfix] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-972663334
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20582: [master][bugfix] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-971600931
Jenkins CI successfully triggered : [windows-cpu, centos-cpu, miscellaneous, website, clang, unix-gpu, sanity, unix-cpu, edge, windows-gpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20582: [Master] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-921633862
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20582: [Master] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-920695096
Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, centos-gpu, unix-cpu, sanity, clang, website, windows-gpu, miscellaneous, centos-cpu, windows-cpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20582: [master][bugfix] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-972663269
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20582: [master][bugfix] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-960864783
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20582: [master][bugfix] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-960864649
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20582: [Master] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-921955722
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20582: [Master] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-921955658
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20582: [master][bugfix] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-971600830
@mxnet-bot run ci [all]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20582: [master][bugfix] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-971919537
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20582: [master][bugfix] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-971919452
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20582: [Master] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-921806033
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20582: [Master] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-921582755
@mxnet-bot run ci [all]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20582: [Master] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582#issuecomment-921633949
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #20582: [master][bugfix] Zero initialization to avoid error message on a Centos
Posted by GitBox <gi...@apache.org>.
bgawrych merged pull request #20582:
URL: https://github.com/apache/incubator-mxnet/pull/20582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org