You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/05 15:17:22 UTC
[GitHub] [beam] AnandInguva opened a new issue, #24902: [Task]: Create a helper function fill_in_missing for TFT Criteo tests
AnandInguva opened a new issue, #24902:
URL: https://github.com/apache/beam/issues/24902
### What needs to happen?
This function should accept a rank 2 SparseTensor, and a default value, and return a rank 1 Tensor. It will assume the input is from a VarLenFeature and has dimensions [batch_size, 0] or [batch_size, 1] depending on the max size of the feature over the batch. It's assumed each feature has 0 or 1 values (0 for missing, 1 for present).
It will emit a Tensor which is constructed using the code
feature = tf.sparse_to_dense(
feature.indices, [feature.dense_shape[0], 1], feature.values,
default_value=-1)
feature = tf.squeeze(feature, axis=1)
### Issue Priority
Priority: 3 (nice-to-have improvement)
### Issue Components
- [X] Component: Python SDK
- [ ] Component: Java SDK
- [ ] Component: Go SDK
- [ ] Component: Typescript SDK
- [ ] Component: IO connector
- [ ] Component: Beam examples
- [ ] Component: Beam playground
- [ ] Component: Beam katas
- [ ] Component: Website
- [ ] Component: Spark Runner
- [ ] Component: Flink Runner
- [ ] Component: Samza Runner
- [ ] Component: Twister2 Runner
- [ ] Component: Hazelcast Jet Runner
- [ ] Component: Google Cloud Dataflow Runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task]: Create a helper function fill_in_missing for TFT Criteo tests [beam]
Posted by "damccorm (via GitHub) via github" <gi...@beam.apache.org>.
damccorm commented on issue #24902:
URL: https://github.com/apache/beam/issues/24902#issuecomment-6748952938
Fixed by #39011 (commit 2940f8fc6a03d1c01bfe2f85e420c944bde71dc6), which implemented the `fill_in_missing` helper function with unit tests in `criteo_test.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task]: Create a helper function fill_in_missing for TFT Criteo tests [beam]
Posted by "AbhishekChaudharii (via GitHub)" <gi...@apache.org>.
AbhishekChaudharii commented on issue #24902:
URL: https://github.com/apache/beam/issues/24902#issuecomment-5044641155
Hi! While looking for an issue to contribute to, I noticed that this issue appears to be resolved by #39011
If this is fixed and ready to be closed, I'd love to find another open issue to work on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] smeet07 commented on issue #24902: [Task]: Create a helper function fill_in_missing for TFT Criteo tests
Posted by "smeet07 (via GitHub)" <gi...@apache.org>.
smeet07 commented on issue #24902:
URL: https://github.com/apache/beam/issues/24902#issuecomment-1502169784
@AnandInguva where should I put this helper function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] smeet07 commented on issue #24902: [Task]: Create a helper function fill_in_missing for TFT Criteo tests
Posted by "smeet07 (via GitHub)" <gi...@apache.org>.
smeet07 commented on issue #24902:
URL: https://github.com/apache/beam/issues/24902#issuecomment-1502164852
.take-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task]: Create a helper function fill_in_missing for TFT Criteo tests [beam]
Posted by "damccorm (via GitHub) via github" <gi...@beam.apache.org>.
damccorm closed issue #24902: [Task]: Create a helper function fill_in_missing for TFT Criteo tests
URL: https://github.com/apache/beam/issues/24902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] smeet07 commented on issue #24902: [Task]: Create a helper function fill_in_missing for TFT Criteo tests
Posted by "smeet07 (via GitHub)" <gi...@apache.org>.
smeet07 commented on issue #24902:
URL: https://github.com/apache/beam/issues/24902#issuecomment-1504007719
R: @AnandInguva
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on issue #24902: [Task]: Create a helper function fill_in_missing for TFT Criteo tests
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on issue #24902:
URL: https://github.com/apache/beam/issues/24902#issuecomment-1503529853
This is the place that needs this feature. https://github.com/apache/beam/blob/1fc8e5ce558ad53dcdf67a6c1baf5a790e8fdbb7/sdks/python/apache_beam/testing/benchmarks/cloudml/criteo_tft/criteo.py#L135.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org