You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jingsong Lee (Jira)" <ji...@apache.org> on 2020/01/15 05:35:00 UTC

[jira] [Created] (FLINK-15595) Resolution Order is chaotic not FLIP-68 defined

Jingsong Lee created FLINK-15595:
------------------------------------

             Summary: Resolution Order is chaotic not FLIP-68 defined
                 Key: FLINK-15595
                 URL: https://issues.apache.org/jira/browse/FLINK-15595
             Project: Flink
          Issue Type: Bug
          Components: Table SQL / API
            Reporter: Jingsong Lee
             Fix For: 1.10.0


First of all, the implementation is problematic. CoreModule returns BuiltinFunctionDefinition, which cannot be resolved in FunctionCatalogOperatorTable, so it will fall back to FlinkSqlOperatorTable.

Second, the function defined by CoreModule is seriously incomplete. You can compare it with FunctionCatalogOperatorTable, a lot less.

We should:
 * We should resolve BuiltinFunctionDefinition correctly in FunctionCatalogOperatorTable.
 * CoreModule should contains all functions in FlinkSqlOperatorTable, a simple way could provided calcite wrapper to wrap all functions.
 * PlannerContext.getBuiltinSqlOperatorTable should not contains FlinkSqlOperatorTable, we should use one FunctionCatalogOperatorTable.Otherwise, there will be a lot of confusion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)