You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/02 06:13:34 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #14756: test
BiteTheDDDDt opened a new pull request, #14756:
URL: https://github.com/apache/doris/pull/14756
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt closed pull request #14756: test
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt closed pull request #14756: test
URL: https://github.com/apache/doris/pull/14756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14756: test
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14756:
URL: https://github.com/apache/doris/pull/14756#issuecomment-1334825539
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.47 seconds
load time: 433 seconds
storage size: 17123356280 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221202064340_clickbench_pr_56670.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14756: test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #14756:
URL: https://github.com/apache/doris/pull/14756#discussion_r1038711803
##########
be/src/vec/exec/vjson_scanner.h:
##########
@@ -52,7 +52,7 @@ class VJsonScanner : public JsonScanner {
const std::vector<TNetworkAddress>& broker_addresses,
const std::vector<TExpr>& pre_filter_texprs, ScannerCounter* counter);
- Status get_next(doris::Tuple* tuple, MemPool* tuple_pool, bool* eof,
+ Status get_next(doris::Tuple* /*tuple*/, MemPool* tuple_pool, bool* eof,
Review Comment:
warning: parameter 'tuple_pool' is unused [misc-unused-parameters]
```suggestion
Status get_next(doris::Tuple* /*tuple*/, MemPool* /*tuple_pool*/, bool* eof,
```
##########
be/src/vec/functions/function_binary_arithmetic.h:
##########
@@ -234,9 +234,7 @@ struct DecimalBinaryOperation {
IsDecimalV2<ResultType>) {
Op::vector_vector(a, b, c);
} else {
- for (size_t i = 0; i < size; i++) {
- c[i] = apply(a[i], b[i]);
- }
+ for (size_t i = 0; i < size; i++) c[i] = apply(a[i], b[i]);
Review Comment:
warning: statement should be inside braces [readability-braces-around-statements]
```suggestion
for (size_t i = 0; i < size; i++) { c[i] = apply(a[i], b[i]);
}
```
##########
be/src/vec/exec/vjson_scanner.h:
##########
@@ -52,7 +52,7 @@
const std::vector<TNetworkAddress>& broker_addresses,
const std::vector<TExpr>& pre_filter_texprs, ScannerCounter* counter);
- Status get_next(doris::Tuple* tuple, MemPool* tuple_pool, bool* eof,
+ Status get_next(doris::Tuple* /*tuple*/, MemPool* tuple_pool, bool* eof,
Review Comment:
warning: parameter 'eof' is unused [misc-unused-parameters]
```suggestion
Status get_next(doris::Tuple* /*tuple*/, MemPool* tuple_pool, bool* /*eof*/,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt closed pull request #14756: test
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt closed pull request #14756: test
URL: https://github.com/apache/doris/pull/14756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org