You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/12 03:02:33 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3040: [GOBBLIN-1192] Commit suicide if Helix Task creation failed after retry

sv2000 commented on a change in pull request #3040:
URL: https://github.com/apache/incubator-gobblin/pull/3040#discussion_r439181661



##########
File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
##########
@@ -194,6 +195,7 @@ private ContainerHealthCheckFailureEvent createTaskCreationEvent() {
     event.addMetadata("helixJobId", this.helixJobId);

Review comment:
       Can we align the metadata field names to the ones in HelixTaskEventMetadataGenerator?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org