You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/15 10:50:00 UTC
[GitHub] [airflow] potiuk opened a new pull request #7730: [AIRFLOW-7067]
Pinned version of Apache Airflow
potiuk opened a new pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
- Coverage 86.93% 86.81% -0.12%
==========================================
Files 915 915
Lines 44158 44170 +12
==========================================
- Hits 38387 38346 -41
- Misses 5771 5824 +53
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0.00%> (-45.66%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0.00%> (-32.36%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.73% <0.00%> (-0.15%)` | :arrow_down: |
| [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100.00% <0.00%> (ø)` | |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `86.07% <0.00%> (+2.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...a7fca22](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7730: [AIRFLOW-7067] Pinned
version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#discussion_r396076732
##########
File path: INSTALL
##########
@@ -1,7 +1,20 @@
# INSTALL / BUILD instructions for Apache Airflow
-# [required] fetch the tarball and untar the source
-# change into the directory that was untarred.
+This ia a generic installation method that requires a number of dependencies to be installed.
+
+Depending on your system you might need different prerequisites, but the following
+systems/prerequisites are known to work:
+
+Linux (Debian Buster and Linux Mint Tricia):
+
+sudo apt install build-essentials python3.6-dev python3.7-dev python-dev openssl \
+ sqlite sqlite-dev default-libmysqlclient-dev libmysqld-dev postgresq
+
+MacOS (Mojave/Catalina):
+
+brew install sqlite mysql postgresql
+
+# [required] fetch the tarball and untar the source chnge into the directory that was untarred.
Review comment:
```suggestion
# [required] fetch the tarball and untar the source, move into the directory that was untarred.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7730: [AIRFLOW-7067] Pinned
version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599237136
All should be update and much nicer now @ashb !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#discussion_r396076916
##########
File path: INSTALL
##########
@@ -11,12 +24,31 @@ java -jar apache-rat.jar -E ./.rat-excludes -d .
# to connect to other services. You might want to test or run Airflow
# from a virtual env to make sure those dependencies are separated
# from your system wide versions
-python -m my_env
-source my_env/bin/activate
-# [required] building and installing
-# by pip (preferred)
+python3 -m venv PATH_TO_YOUR_VENV
+source PATH_TO_YOUR_VENV/bin/activate
+
+# [required] building and installing by pip (preferred)
pip install .
# or directly
python setup.py install
+
+# You can also install recommended version of the dependencies by using requirements.txt
+# as constraint file
+
+pip install . --constraint requirements.txt
Review comment:
How should I know if I should use requirements or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7730: [AIRFLOW-7067] Pinned
version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599242772
And all green!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `97.66% <0.00%> (+2.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [9ad1844...6a80f5f](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#discussion_r392679061
##########
File path: INSTALL
##########
@@ -1,22 +1,5 @@
# INSTALL / BUILD instructions for Apache Airflow
-# [required] fetch the tarball and untar the source
-# change into the directory that was untarred.
-
-# [optional] run Apache RAT (release audit tool) to validate license headers
-# RAT docs here: https://creadur.apache.org/rat/. Requires Java and Apache Rat
-java -jar apache-rat.jar -E ./.rat-excludes -d .
-
-# [optional] Airflow pulls in quite a lot of dependencies in order
-# to connect to other services. You might want to test or run Airflow
-# from a virtual env to make sure those dependencies are separated
-# from your system wide versions
-python -m my_env
-source my_env/bin/activate
-
-# [required] building and installing
-# by pip (preferred)
-pip install .
-
-# or directly
-python setup.py install
+We used to have generic instructions for local installation for development here
+However it's much easier to install and develop Airflow via Breeze development
Review comment:
Install is for end users, so breeze isn't appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
- Coverage 86.93% 86.86% -0.07%
==========================================
Files 915 915
Lines 44158 44170 +12
==========================================
- Hits 38387 38368 -19
- Misses 5771 5802 +31
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50% <0%> (-50%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (-32.36%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0%> (-15.5%)` | :arrow_down: |
| [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `86.07% <0%> (+2.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...a7fca22](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100.00% <0.00%> (ø)` | |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...bfd5d21](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100.00% <0.00%> (ø)` | |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...bfd5d21](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7730: [AIRFLOW-7067]
Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...5b8c573](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `97.66% <0.00%> (+2.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [9ad1844...6a80f5f](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...6d36e13](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `97.66% <0.00%> (+2.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [9ad1844...6a80f5f](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7730: [AIRFLOW-7067] Pinned
version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599221736
BTW. I am going to simplify it even more - no need to store fixed requirements in setup.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100.00% <0.00%> (ø)` | |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...bfd5d21](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
- Coverage 86.93% 86.86% -0.07%
==========================================
Files 915 915
Lines 44158 44170 +12
==========================================
- Hits 38387 38368 -19
- Misses 5771 5802 +31
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0.00%> (-32.36%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100.00% <0.00%> (ø)` | |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `86.07% <0.00%> (+2.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...a7fca22](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...5b8c573](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...5b8c573](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#discussion_r392682021
##########
File path: INSTALL
##########
@@ -1,22 +1,5 @@
# INSTALL / BUILD instructions for Apache Airflow
-# [required] fetch the tarball and untar the source
-# change into the directory that was untarred.
-
-# [optional] run Apache RAT (release audit tool) to validate license headers
-# RAT docs here: https://creadur.apache.org/rat/. Requires Java and Apache Rat
-java -jar apache-rat.jar -E ./.rat-excludes -d .
-
-# [optional] Airflow pulls in quite a lot of dependencies in order
-# to connect to other services. You might want to test or run Airflow
-# from a virtual env to make sure those dependencies are separated
-# from your system wide versions
-python -m my_env
-source my_env/bin/activate
-
-# [required] building and installing
-# by pip (preferred)
-pip install .
-
-# or directly
-python setup.py install
+We used to have generic instructions for local installation for development here
+However it's much easier to install and develop Airflow via Breeze development
Review comment:
It was recommending to install -e . :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...6d36e13](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `97.66% <0.00%> (+2.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [9ad1844...6a80f5f](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#discussion_r396077467
##########
File path: INSTALL
##########
@@ -11,12 +24,31 @@ java -jar apache-rat.jar -E ./.rat-excludes -d .
# to connect to other services. You might want to test or run Airflow
# from a virtual env to make sure those dependencies are separated
# from your system wide versions
-python -m my_env
-source my_env/bin/activate
-# [required] building and installing
-# by pip (preferred)
+python3 -m venv PATH_TO_YOUR_VENV
+source PATH_TO_YOUR_VENV/bin/activate
+
+# [required] building and installing by pip (preferred)
pip install .
# or directly
python setup.py install
+
+# You can also install recommended version of the dependencies by using requirements.txt
+# as constraint file
+
+pip install . --constraint requirements.txt
Review comment:
You do not have to - it's the recommended version of dependencies. This is just a hint that you can do it. I proposed to have "apache-airflow-pinned" package release separately. with clear purpose in mind "to have repeatable installation"
I agreed having the --constraint and having to know which version to install might be confusing - that was my point in the discussion - but there are different opinions. For now I just want to merge requirements.txt and it's maintenance mechanism so that we avoid further breakage. But the discussion continues here how to approach it:
https://lists.apache.org/thread.html/rf8b0ea9a7b93482734ae9e10e7d87f3c31679edb5eaf88496e733aa5%40%3Cdev.airflow.apache.org%3E
I invite you to take part in the discussion and propose some solutions/approach. I would really love to have yours (and others) opinions in the thread there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...6d36e13](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 915 915
Lines 44158 44158
=======================================
Hits 38387 38387
Misses 5771 5771
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100.00% <0.00%> (ø)` | |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...bfd5d21](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#discussion_r392679015
##########
File path: INSTALL
##########
@@ -1,22 +1,5 @@
# INSTALL / BUILD instructions for Apache Airflow
-# [required] fetch the tarball and untar the source
-# change into the directory that was untarred.
-
-# [optional] run Apache RAT (release audit tool) to validate license headers
-# RAT docs here: https://creadur.apache.org/rat/. Requires Java and Apache Rat
-java -jar apache-rat.jar -E ./.rat-excludes -d .
-
-# [optional] Airflow pulls in quite a lot of dependencies in order
-# to connect to other services. You might want to test or run Airflow
-# from a virtual env to make sure those dependencies are separated
-# from your system wide versions
-python -m my_env
-source my_env/bin/activate
-
-# [required] building and installing
-# by pip (preferred)
-pip install .
-
-# or directly
-python setup.py install
+We used to have generic instructions for local installation for development here
Review comment:
I think this was first added to follow Apache guide-lines, let me see if I can find that again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#discussion_r392691267
##########
File path: INSTALL
##########
@@ -1,22 +1,5 @@
# INSTALL / BUILD instructions for Apache Airflow
-# [required] fetch the tarball and untar the source
-# change into the directory that was untarred.
-
-# [optional] run Apache RAT (release audit tool) to validate license headers
-# RAT docs here: https://creadur.apache.org/rat/. Requires Java and Apache Rat
-java -jar apache-rat.jar -E ./.rat-excludes -d .
-
-# [optional] Airflow pulls in quite a lot of dependencies in order
-# to connect to other services. You might want to test or run Airflow
-# from a virtual env to make sure those dependencies are separated
-# from your system wide versions
-python -m my_env
-source my_env/bin/activate
-
-# [required] building and installing
-# by pip (preferred)
-pip install .
-
-# or directly
-python setup.py install
+We used to have generic instructions for local installation for development here
+However it's much easier to install and develop Airflow via Breeze development
Review comment:
Yep. I updated the description now and made even more valid with additional information and generated extras list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
- Coverage 86.93% 86.86% -0.07%
==========================================
Files 915 915
Lines 44158 44170 +12
==========================================
- Hits 38387 38368 -19
- Misses 5771 5802 +31
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0.00%> (-32.36%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100.00% <0.00%> (ø)` | |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `86.07% <0.00%> (+2.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...a7fca22](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7730:
[AIRFLOW-7067] Pinned version of Apache Airflow
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7730: [AIRFLOW-7067] Pinned version of Apache Airflow
URL: https://github.com/apache/airflow/pull/7730#issuecomment-599199404
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=h1) Report
> Merging [#7730](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/271ee6477b80633049457557020a4f525f9135cd&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
- Coverage 86.93% 86.86% -0.07%
==========================================
Files 915 915
Lines 44158 44170 +12
==========================================
- Hits 38387 38368 -19
- Misses 5771 5802 +31
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0.00%> (-32.36%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100.00% <0.00%> (ø)` | |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100.00% <0.00%> (ø)` | |
| [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7730/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `86.07% <0.00%> (+2.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=footer). Last update [271ee64...a7fca22](https://codecov.io/gh/apache/airflow/pull/7730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services