You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/13 19:50:35 UTC

[GitHub] [beam] ibzib opened a new pull request #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

ibzib opened a new pull request #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124
 
 
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
   --- | --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
   Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
   Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
   XLang | --- | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website
   --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) 
   Portable | --- | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-599786492
 
 
   Run Python PreCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia closed pull request #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
amaliujia closed pull request #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-598887381
 
 
   Run Python 2 PostCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-598887460
 
 
   Run Python 3.7 PostCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-598915263
 
 
   LGTM after tests pass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-598887440
 
 
   Run Python 3.6 PostCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-600382340
 
 
   Python2_PVR_Flink failures are probably flakes related to timeouts -- see BEAM-8912

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-598886496
 
 
   Run Python3 Postcommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib removed a comment on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib removed a comment on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-598886496
 
 
   Run Python3 Postcommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-600434903
 
 
   Thank you! I have cherry-picked your commit directly. Closing this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-600368958
 
 
   Run Python 3.7 PostCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-599754982
 
 
   Run Python PreCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-598886460
 
 
   Run Python2 Postcommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-598887413
 
 
   Run Python 3.5 PostCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] ibzib removed a comment on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.

Posted by GitBox <gi...@apache.org>.
ibzib removed a comment on issue #11124: [cherry-pick][release-2.20.0][BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11124#issuecomment-598886460
 
 
   Run Python2 Postcommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services