You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by eymorale <gi...@git.apache.org> on 2015/10/02 19:03:19 UTC
[GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...
GitHub user eymorale opened a pull request:
https://github.com/apache/cordova-ios/pull/170
CB-9719 set enable_modules build setting to no
In 3.x, this setting was set to no. It currently breaks frameworks that have CordovaLib as a dependency since it is not a module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eymorale/cordova-ios CB-9719
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit 6ca02f577c374e2c1340455c60590bffca0089c9
Author: Edna Morales <ed...@gmail.com>
Date: 2015-10-02T17:00:07Z
CB-9719 set enable_modules build setting to no
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...
Posted by csantanapr <gi...@git.apache.org>.
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/170#issuecomment-145299566
I did some investigation today, I found the reason why putting
CLANG_ENABLE_MODULES = NO
in build.xcconfig doesn't get reflected, is because build.xcconfig is for Project, not the Target, the Project file is set to Yes, and Project file has higher precedence than Project xcconfig
For the variable assingment to be able to work it needs to be set in Target's release/build or extras xcconfig
There is another value that also fixes our problem with a framework referring to a non-module header/class from CordovaLib
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES
From looking at all levels in XCode, it looks like the iOS Platform default is:
CLANG_ENABLE_MODULES = NO and CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = NO
But XCode 7 when it creates a new projects, overwrites the default of one of them to CLANG_ENABLE_MODULES = YES
It might be safer to set
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES
which I think is more closer to the compile error that we are getting, and maybe has less side effects.
By Google Power I discover this page, explains variable assignment precedence:
http://pewpewthespells.com/blog/xcconfig_guide.html
What you all think?
And what would be the best to assign it? Project (build.xcconfig) or Target (build-debug.xcconfig and build-release.xcconfig)
We could use extras but I would like to leave extra empty for the developer/user to overwrite values from Target and Project xcconfig programmatically
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/170#issuecomment-145129095
LGTM.
However, the side effect of this is, if any modules use the module import syntax, ie `@import UIKit;` this might break I think, but the workaround there is to use the old import method, so its fine.
The final fix would be to make CordovaLib as a module, but that's a lot more work potentially.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/170#issuecomment-145442229
Regarding the xcconfig - for command line builds, anything set by the xcconfig flag should override everything. This is what the setting from the man page for xcodebuild says:
```
-xcconfig filename
Load the build settings defined in filename when building all targets. These set-
tings will override all other settings, including settings passed individually on
the command line.
```
So I'm confused, unless Xcode 7 has a bug in it. Couldn't verify unless we have a test project to get the failure case, and to test a fix.
Thanks for investigating this. Like you said, try setting CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES in build.xcconfig to see if it fixes your problem?. build.xcconfig is the base xcconfig for all Build Configurations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...
Posted by eymorale <gi...@git.apache.org>.
Github user eymorale closed the pull request at:
https://github.com/apache/cordova-ios/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org