You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/12/12 20:05:37 UTC

[commons-crypto] branch master updated (dff65e5 -> 6186036)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git


    from dff65e5  Better internal name
     new f45080f  Format
     new 241c0eb  Javadoc
     new 6186036  Make package-private classes final

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/apache/commons/crypto/OpenSslInfoNative.java |  2 +-
 .../org/apache/commons/crypto/cipher/JceCipher.java  |  2 +-
 .../apache/commons/crypto/cipher/OpenSslCipher.java  | 10 ++++++----
 .../commons/crypto/cipher/OpenSslCommonMode.java     |  2 +-
 .../crypto/cipher/OpenSslGaloisCounterMode.java      |  2 +-
 .../apache/commons/crypto/cipher/OpenSslNative.java  |  2 +-
 .../commons/crypto/jna/OpenSsl10XNativeJna.java      |  2 +-
 .../commons/crypto/jna/OpenSsl11XNativeJna.java      |  2 +-
 .../commons/crypto/jna/OpenSsl20XNativeJna.java      |  2 +-
 .../apache/commons/crypto/jna/OpenSslJnaCipher.java  |  2 +-
 .../commons/crypto/jna/OpenSslJnaCryptoRandom.java   |  2 +-
 .../apache/commons/crypto/jna/OpenSslNativeJna.java  |  2 +-
 .../commons/crypto/random/JavaCryptoRandom.java      |  4 ++--
 .../commons/crypto/random/OpenSslCryptoRandom.java   | 20 +++++++++-----------
 .../crypto/random/OpenSslCryptoRandomNative.java     |  2 +-
 .../apache/commons/crypto/random/OsCryptoRandom.java | 15 +++++++--------
 .../java/org/apache/commons/crypto/utils/Utils.java  |  2 +-
 17 files changed, 37 insertions(+), 38 deletions(-)


[commons-crypto] 02/03: Javadoc

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git

commit 241c0eb85c1b9c61e389f949f7ed12a88828f914
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Dec 12 15:01:15 2022 -0500

    Javadoc
---
 .../org/apache/commons/crypto/cipher/JceCipher.java    |  2 +-
 .../apache/commons/crypto/cipher/OpenSslCipher.java    |  6 ++++--
 .../apache/commons/crypto/random/JavaCryptoRandom.java |  2 +-
 .../commons/crypto/random/OpenSslCryptoRandom.java     | 18 ++++++++----------
 .../apache/commons/crypto/random/OsCryptoRandom.java   |  9 +++++----
 .../java/org/apache/commons/crypto/utils/Utils.java    |  2 +-
 6 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/src/main/java/org/apache/commons/crypto/cipher/JceCipher.java b/src/main/java/org/apache/commons/crypto/cipher/JceCipher.java
index 3c34076..9caf3cc 100644
--- a/src/main/java/org/apache/commons/crypto/cipher/JceCipher.java
+++ b/src/main/java/org/apache/commons/crypto/cipher/JceCipher.java
@@ -34,7 +34,7 @@ import javax.crypto.ShortBufferException;
 /**
  * Implements the {@link CryptoCipher} using JCE provider.
  * <p>
- * N.B. this class is not public/protected so does not appear in the main Javadoc. Please ensure that property use is documented in the enum
+ * This class is not public/protected so does not appear in the main Javadoc. Please ensure that property use is documented in the enum
  * CryptoRandomFactory.RandomProvider
  * </p>
  */
diff --git a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java
index e829ed3..ef23b2e 100644
--- a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java
+++ b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java
@@ -33,6 +33,10 @@ import javax.crypto.ShortBufferException;
 
 /**
  * Implements the CryptoCipher using JNI into OpenSSL.
+ * <p>
+ * this class is not public/protected so does not appear in the main Javadoc Please ensure that property use is documented in the enum
+ * CryptoRandomFactory.RandomProvider
+ * </p>
  */
 class OpenSslCipher implements CryptoCipher {
 
@@ -48,8 +52,6 @@ class OpenSslCipher implements CryptoCipher {
      * @param transformation  transformation for OpenSSL openSslEngine (algorithm/mode/padding)
      * @throws GeneralSecurityException if OpenSSL openSslEngine initialize failed
      */
-    // N.B. this class is not public/protected so does not appear in the main Javadoc
-    // Please ensure that property use is documented in the enum CryptoRandomFactory.RandomProvider
     public OpenSslCipher(final Properties props, final String transformation) // NOPMD
             throws GeneralSecurityException {
         this.transformation = transformation;
diff --git a/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java b/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java
index 47a0f69..ae5c314 100644
--- a/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java
+++ b/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java
@@ -26,7 +26,7 @@ import org.apache.commons.crypto.utils.Utils;
 /**
  * A CryptoRandom of Java implementation.
  * <p>
- * N.B. this class is not public/protected so does not appear in the main Javadoc Please ensure that property use is documented in the enum
+ * This class is not public/protected so does not appear in the main Javadoc Please ensure that property use is documented in the enum
  * CryptoRandomFactory.RandomProvider
  * </p>
  */
diff --git a/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java b/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java
index 591fd31..be87907 100644
--- a/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java
+++ b/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java
@@ -29,16 +29,16 @@ import org.apache.commons.crypto.Crypto;
  * </p>
  *
  * <p>
- * If using an Intel chipset with RDRAND, the high-performance hardware random
- * number generator will be used and it's much faster than SecureRandom. If
- * RDRAND is unavailable, default OpenSSL secure random generator will be used.
- * It's still faster and can generate strong random bytes.
+ * If using an Intel chipset with RDRAND, the high-performance hardware random number generator will be used and it's much faster than SecureRandom. If RDRAND
+ * is unavailable, default OpenSSL secure random generator will be used. It's still faster and can generate strong random bytes.
+ * </p>
+ * <p>
+ * This class is not public/protected so does not appear in the main Javadoc Please ensure that property use is documented in the enum
+ * CryptoRandomFactory.RandomProvider
  * </p>
  *
- * @see <a href="https://wiki.openssl.org/index.php/Random_Numbers">
- *      https://wiki.openssl.org/index.php/Random_Numbers</a>
- * @see <a href="http://en.wikipedia.org/wiki/RdRand">
- *      http://en.wikipedia.org/wiki/RdRand</a>
+ * @see <a href="https://wiki.openssl.org/index.php/Random_Numbers"> https://wiki.openssl.org/index.php/Random_Numbers</a>
+ * @see <a href="http://en.wikipedia.org/wiki/RdRand"> http://en.wikipedia.org/wiki/RdRand</a>
  */
 class OpenSslCryptoRandom implements CryptoRandom {
 
@@ -95,8 +95,6 @@ class OpenSslCryptoRandom implements CryptoRandom {
      * @param props the configuration properties - not used
      * @throws GeneralSecurityException if the native library could not be initialized successfully
      */
-    // N.B. this class is not public/protected so does not appear in the main Javadoc
-    // Please ensure that property use is documented in the enum CryptoRandomFactory.RandomProvider
     public OpenSslCryptoRandom(final Properties props) throws GeneralSecurityException { // NOPMD
         checkNative();
     }
diff --git a/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java b/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
index 52539a2..49e0ebf 100644
--- a/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
+++ b/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
@@ -25,8 +25,11 @@ import java.util.Properties;
 import org.apache.commons.crypto.utils.IoUtils;
 
 /**
- * A Random implementation that uses random bytes sourced from the operating
- * system.
+ * A Random implementation that uses random bytes sourced from the operating system.
+ * <p>
+ * This class is not public/protected so does not appear in the main Javadoc Please ensure that property use is documented in the enum
+ * CryptoRandomFactory.RandomProvider
+ * </p>
  */
 class OsCryptoRandom implements CryptoRandom {
 
@@ -62,8 +65,6 @@ class OsCryptoRandom implements CryptoRandom {
      * path to the random device, default is
      * {@link CryptoRandomFactory#DEVICE_FILE_PATH_DEFAULT}
      */
-    // N.B. this class is not public/protected so does not appear in the main Javadoc
-    // Please ensure that property use is documented in the enum CryptoRandomFactory.RandomProvider
     public OsCryptoRandom(final Properties props) {
         final File randomDevFile = new File(props.getProperty(CryptoRandomFactory.DEVICE_FILE_PATH_KEY, CryptoRandomFactory.DEVICE_FILE_PATH_DEFAULT));
 
diff --git a/src/main/java/org/apache/commons/crypto/utils/Utils.java b/src/main/java/org/apache/commons/crypto/utils/Utils.java
index c0d9ec1..93a9dad 100644
--- a/src/main/java/org/apache/commons/crypto/utils/Utils.java
+++ b/src/main/java/org/apache/commons/crypto/utils/Utils.java
@@ -230,7 +230,7 @@ public final class Utils {
      * The code is intended for use with macOS where SIP makes it hard to override
      * the environment variables needed to override the DLL search path. It also
      * works for Linux, but is not (currently) used or needed for Windows.
-     * N.B. Do not change the method name or its signature!
+     * Do not change the method name or its signature!
      */
     static String libraryPath(final String name) {
         final String override = System.getProperty("jni.library.path");


[commons-crypto] 03/03: Make package-private classes final

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git

commit 6186036b3caa1c6e93804d94665cbabbcc172ca4
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Dec 12 15:05:33 2022 -0500

    Make package-private classes final
---
 src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java        | 2 +-
 src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java     | 4 ++--
 src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java | 2 +-
 .../org/apache/commons/crypto/cipher/OpenSslGaloisCounterMode.java    | 2 +-
 src/main/java/org/apache/commons/crypto/cipher/OpenSslNative.java     | 2 +-
 src/main/java/org/apache/commons/crypto/jna/OpenSsl10XNativeJna.java  | 2 +-
 src/main/java/org/apache/commons/crypto/jna/OpenSsl11XNativeJna.java  | 2 +-
 src/main/java/org/apache/commons/crypto/jna/OpenSsl20XNativeJna.java  | 2 +-
 src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java     | 2 +-
 .../java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java    | 2 +-
 src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java     | 2 +-
 src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java  | 2 +-
 .../java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java    | 2 +-
 .../org/apache/commons/crypto/random/OpenSslCryptoRandomNative.java   | 2 +-
 src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java    | 2 +-
 15 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java b/src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java
index a249ded..668381e 100644
--- a/src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java
+++ b/src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java
@@ -26,7 +26,7 @@ import org.apache.commons.crypto.random.CryptoRandom;
  * and implemented in the file
  * src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
  */
-class OpenSslInfoNative {
+final class OpenSslInfoNative {
 
     public static final long VERSION_1_0_2X = 0x10002000;
     public static final long VERSION_1_1_0X = 0x10100000;
diff --git a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java
index ef23b2e..6cf0c15 100644
--- a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java
+++ b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java
@@ -38,7 +38,7 @@ import javax.crypto.ShortBufferException;
  * CryptoRandomFactory.RandomProvider
  * </p>
  */
-class OpenSslCipher implements CryptoCipher {
+final class OpenSslCipher implements CryptoCipher {
 
     private final OpenSsl openSslEngine;
     private boolean initialized;
@@ -71,7 +71,7 @@ class OpenSslCipher implements CryptoCipher {
      * not a block openSslEngine
      */
     @Override
-    public final int getBlockSize() {
+    public int getBlockSize() {
         return CryptoCipherFactory.AES_BLOCK_SIZE;
     }
 
diff --git a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java
index 7641846..e8cc1e5 100644
--- a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java
+++ b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java
@@ -32,7 +32,7 @@ import javax.crypto.spec.IvParameterSpec;
  * It will call the OpenSSL API to implement encryption/decryption
  * </p>
  */
-class OpenSslCommonMode extends AbstractOpenSslFeedbackCipher {
+final class OpenSslCommonMode extends AbstractOpenSslFeedbackCipher {
 
     OpenSslCommonMode(final long context, final int algorithmMode, final int padding) {
         super(context, algorithmMode, padding);
diff --git a/src/main/java/org/apache/commons/crypto/cipher/OpenSslGaloisCounterMode.java b/src/main/java/org/apache/commons/crypto/cipher/OpenSslGaloisCounterMode.java
index 42394f2..b637525 100644
--- a/src/main/java/org/apache/commons/crypto/cipher/OpenSslGaloisCounterMode.java
+++ b/src/main/java/org/apache/commons/crypto/cipher/OpenSslGaloisCounterMode.java
@@ -36,7 +36,7 @@ import javax.crypto.spec.GCMParameterSpec;
  *
  * @since 1.1
  */
-class OpenSslGaloisCounterMode extends AbstractOpenSslFeedbackCipher {
+final class OpenSslGaloisCounterMode extends AbstractOpenSslFeedbackCipher {
 
     // buffer for AAD data; if consumed, set as null
     private ByteArrayOutputStream aadBuffer = new ByteArrayOutputStream();
diff --git a/src/main/java/org/apache/commons/crypto/cipher/OpenSslNative.java b/src/main/java/org/apache/commons/crypto/cipher/OpenSslNative.java
index 64ea231..0b1760f 100644
--- a/src/main/java/org/apache/commons/crypto/cipher/OpenSslNative.java
+++ b/src/main/java/org/apache/commons/crypto/cipher/OpenSslNative.java
@@ -23,7 +23,7 @@ import java.nio.ByteBuffer;
  * JNI interface of {@link OpenSsl} implementation. The native method in this
  * class is defined in OpenSslNative.h (generated by javah).
  */
-class OpenSslNative {
+final class OpenSslNative {
 
     /**
      * The private constructor of {@link OpenSslNative}.
diff --git a/src/main/java/org/apache/commons/crypto/jna/OpenSsl10XNativeJna.java b/src/main/java/org/apache/commons/crypto/jna/OpenSsl10XNativeJna.java
index 2a2d6ba..c2eb152 100644
--- a/src/main/java/org/apache/commons/crypto/jna/OpenSsl10XNativeJna.java
+++ b/src/main/java/org/apache/commons/crypto/jna/OpenSsl10XNativeJna.java
@@ -26,7 +26,7 @@ import com.sun.jna.Native;
 import com.sun.jna.NativeLong;
 import com.sun.jna.ptr.PointerByReference;
 
-class OpenSsl10XNativeJna implements OpenSslInterfaceNativeJna {
+final class OpenSsl10XNativeJna implements OpenSslInterfaceNativeJna {
 
     static final boolean INIT_OK;
 
diff --git a/src/main/java/org/apache/commons/crypto/jna/OpenSsl11XNativeJna.java b/src/main/java/org/apache/commons/crypto/jna/OpenSsl11XNativeJna.java
index adf023e..1d4fa88 100644
--- a/src/main/java/org/apache/commons/crypto/jna/OpenSsl11XNativeJna.java
+++ b/src/main/java/org/apache/commons/crypto/jna/OpenSsl11XNativeJna.java
@@ -26,7 +26,7 @@ import com.sun.jna.Native;
 import com.sun.jna.NativeLong;
 import com.sun.jna.ptr.PointerByReference;
 
-class OpenSsl11XNativeJna  implements OpenSslInterfaceNativeJna {
+final class OpenSsl11XNativeJna  implements OpenSslInterfaceNativeJna {
 
     static final boolean INIT_OK;
 
diff --git a/src/main/java/org/apache/commons/crypto/jna/OpenSsl20XNativeJna.java b/src/main/java/org/apache/commons/crypto/jna/OpenSsl20XNativeJna.java
index ecc1a2a..9c01014 100644
--- a/src/main/java/org/apache/commons/crypto/jna/OpenSsl20XNativeJna.java
+++ b/src/main/java/org/apache/commons/crypto/jna/OpenSsl20XNativeJna.java
@@ -26,7 +26,7 @@ import com.sun.jna.Native;
 import com.sun.jna.NativeLong;
 import com.sun.jna.ptr.PointerByReference;
 
-class OpenSsl20XNativeJna implements OpenSslInterfaceNativeJna {
+final class OpenSsl20XNativeJna implements OpenSslInterfaceNativeJna {
 
     static final boolean INIT_OK;
 
diff --git a/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java b/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java
index 94b14b5..5c5fd64 100644
--- a/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java
+++ b/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java
@@ -43,7 +43,7 @@ import com.sun.jna.ptr.PointerByReference;
 /**
  * Implements the CryptoCipher using JNA into OpenSSL.
  */
-class OpenSslJnaCipher implements CryptoCipher {
+final class OpenSslJnaCipher implements CryptoCipher {
 
     private PointerByReference algo;
     private final PointerByReference context;
diff --git a/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java b/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java
index b839e1d..ba38dd7 100644
--- a/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java
+++ b/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java
@@ -44,7 +44,7 @@ import com.sun.jna.ptr.PointerByReference;
  * @see <a href="http://en.wikipedia.org/wiki/RdRand">
  *      http://en.wikipedia.org/wiki/RdRand</a>
  */
-class OpenSslJnaCryptoRandom implements CryptoRandom {
+final class OpenSslJnaCryptoRandom implements CryptoRandom {
 
     private final boolean rdrandEnabled;
     private final transient PointerByReference rdrandEngine;
diff --git a/src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java b/src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java
index ea7522d..fdc013d 100644
--- a/src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java
+++ b/src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java
@@ -27,7 +27,7 @@ import com.sun.jna.NativeLibrary;
 import com.sun.jna.NativeLong;
 import com.sun.jna.ptr.PointerByReference;
 
-class OpenSslNativeJna {
+final class OpenSslNativeJna {
 
     static final int OPENSSL_INIT_ENGINE_RDRAND = 0x00000200;
 
diff --git a/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java b/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java
index ae5c314..d81b7d1 100644
--- a/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java
+++ b/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java
@@ -30,7 +30,7 @@ import org.apache.commons.crypto.utils.Utils;
  * CryptoRandomFactory.RandomProvider
  * </p>
  */
-class JavaCryptoRandom implements CryptoRandom {
+final class JavaCryptoRandom implements CryptoRandom {
 
     private final SecureRandom instance;
 
diff --git a/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java b/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java
index be87907..9c42776 100644
--- a/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java
+++ b/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java
@@ -40,7 +40,7 @@ import org.apache.commons.crypto.Crypto;
  * @see <a href="https://wiki.openssl.org/index.php/Random_Numbers"> https://wiki.openssl.org/index.php/Random_Numbers</a>
  * @see <a href="http://en.wikipedia.org/wiki/RdRand"> http://en.wikipedia.org/wiki/RdRand</a>
  */
-class OpenSslCryptoRandom implements CryptoRandom {
+final class OpenSslCryptoRandom implements CryptoRandom {
 
     private static final boolean nativeEnabled;
 
diff --git a/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.java b/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.java
index f52cf79..76d07ea 100644
--- a/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.java
+++ b/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.java
@@ -24,7 +24,7 @@ package org.apache.commons.crypto.random;
  * and implemented in the file
  * src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
  */
-class OpenSslCryptoRandomNative {
+final class OpenSslCryptoRandomNative {
 
     /**
      * The private constructor of {@link OpenSslCryptoRandomNative}.
diff --git a/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java b/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
index 49e0ebf..f79bb15 100644
--- a/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
+++ b/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
@@ -31,7 +31,7 @@ import org.apache.commons.crypto.utils.IoUtils;
  * CryptoRandomFactory.RandomProvider
  * </p>
  */
-class OsCryptoRandom implements CryptoRandom {
+final class OsCryptoRandom implements CryptoRandom {
 
     private static final int RESERVOIR_LENGTH = 8192;
 


[commons-crypto] 01/03: Format

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git

commit f45080f4913517b151a353201697101c677e4335
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Dec 12 14:56:47 2022 -0500

    Format
---
 src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java b/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
index f5b06d3..52539a2 100644
--- a/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
+++ b/src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
@@ -65,9 +65,7 @@ class OsCryptoRandom implements CryptoRandom {
     // N.B. this class is not public/protected so does not appear in the main Javadoc
     // Please ensure that property use is documented in the enum CryptoRandomFactory.RandomProvider
     public OsCryptoRandom(final Properties props) {
-        final File randomDevFile = new File(
-                props.getProperty(CryptoRandomFactory.DEVICE_FILE_PATH_KEY,
-                                  CryptoRandomFactory.DEVICE_FILE_PATH_DEFAULT));
+        final File randomDevFile = new File(props.getProperty(CryptoRandomFactory.DEVICE_FILE_PATH_KEY, CryptoRandomFactory.DEVICE_FILE_PATH_DEFAULT));
 
         try {
             close();