You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "codeDing18 (via GitHub)" <gi...@apache.org> on 2025/11/14 09:03:53 UTC
[PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
codeDing18 opened a new pull request, #58032:
URL: https://github.com/apache/doris/pull/58032
### What problem does this PR solve?
The date_add function supports new type: MINUTE_SECOND, now we can use a string in the format 'minute:second' as the INTERVAL parameter.
```
mysql> select DATE_ADD('2025-10-23 10:10:10', INTERVAL '1:1' MINUTE_SECOND);
+---------------------------------------------------------------+
| DATE_ADD('2025-10-23 10:10:10', INTERVAL '1:1' MINUTE_SECOND) |
+---------------------------------------------------------------+
| 2025-10-23 10:11:11 |
+---------------------------------------------------------------+
1 row in set (0.01 sec)
mysql> select DATE_ADD('2025-10-23 10:10:10', INTERVAL '-1:1' MINUTE_SECOND);
+----------------------------------------------------------------+
| DATE_ADD('2025-10-23 10:10:10', INTERVAL '-1:1' MINUTE_SECOND) |
+----------------------------------------------------------------+
| 2025-10-23 10:09:09 |
+----------------------------------------------------------------+
1 row in set (0.00 sec)
```
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3578671971
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "codeDing18 (via GitHub)" <gi...@apache.org>.
codeDing18 commented on code in PR #58032:
URL: https://github.com/apache/doris/pull/58032#discussion_r2554480530
##########
regression-test/suites/query_p0/sql_functions/datetime_functions/test_dateadd_with_other_timeunit.groovy:
##########
@@ -171,4 +171,61 @@ suite("test_dateadd_with_other_timeunit") {
exception "Invalid hours format"
}
+
+ // MINUTE_SECOND
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:-10" MINUTE_SECOND); """
+
+ qt_sql """ select date_add(test_datetime, INTERVAL "1:1" MINUTE_SECOND) result from ${tableName}; """
+ qt_sql """ select date_add(test_datetime, INTERVAL "1:1" MINUTE_SECOND) result from ${tableName}; """
+
+ qt_sql """ select date_add(test_date, INTERVAL "-1:1" MINUTE_SECOND) result from ${tableName}; """
+ qt_sql """ select date_add(test_date, INTERVAL "-1:-1" MINUTE_SECOND) result from ${tableName}; """
+
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:-10" MINUTE_SECOND); """
+
+ test {
+ sql """ select date_add(test_datetime, INTERVAL '1' MINUTE_SECOND) result from ${tableName}; """
Review Comment:
return NULL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3535561272
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (43/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.53% (24337/34024) |
| Line Coverage | 58.01% (253035/436157) |
| Region Coverage | 53.49% (211360/395113) |
| Branch Coverage | 54.71% (90085/164663) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #58032:
URL: https://github.com/apache/doris/pull/58032#discussion_r2554428087
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -1756,6 +1756,7 @@ interval
unitIdentifier
: YEAR | QUARTER | MONTH | WEEK | DAY | HOUR | MINUTE | SECOND | DAY_SECOND | DAY_HOUR
+ | MINUTE_SECOND | SECOND_MICROSECOND
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3533928992
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (43/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.54% (24342/34024) |
| Line Coverage | 58.04% (253166/436157) |
| Region Coverage | 53.58% (211707/395113) |
| Branch Coverage | 54.75% (90156/164663) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3579030447
# BE Regression && UT Coverage Report
Increment line coverage `83.72% (36/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.61% (24477/34183) |
| Line Coverage | 58.08% (254928/438900) |
| Region Coverage | 53.13% (212171/399316) |
| Branch Coverage | 54.67% (90720/165952) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #58032:
URL: https://github.com/apache/doris/pull/58032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3531839882
<details>
<summary>TPC-DS: <b>Total hot run time: 187814 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ff31e72f5a7083d2331f4ad142aa39d2f003f3b9, data reload: false
query1 1035 393 388 388
query2 6563 1691 1713 1691
query3 6750 226 224 224
query4 26406 23538 23173 23173
query5 4473 657 484 484
query6 360 256 228 228
query7 4655 496 305 305
query8 303 266 260 260
query9 8738 2603 2604 2603
query10 551 333 305 305
query11 15851 15151 14945 14945
query12 191 127 111 111
query13 1674 563 426 426
query14 12101 9171 9233 9171
query15 200 195 172 172
query16 7672 687 493 493
query17 1471 748 613 613
query18 2024 411 318 318
query19 207 194 172 172
query20 130 124 123 123
query21 211 133 113 113
query22 3976 4049 3896 3896
query23 33938 33086 32965 32965
query24 8371 2378 2441 2378
query25 608 539 471 471
query26 1245 277 165 165
query27 2747 498 362 362
query28 4398 2220 2206 2206
query29 810 658 516 516
query30 310 232 197 197
query31 907 831 731 731
query32 91 81 73 73
query33 614 395 359 359
query34 791 849 518 518
query35 846 829 753 753
query36 960 984 911 911
query37 122 118 96 96
query38 3605 3554 3480 3480
query39 1490 1431 1424 1424
query40 233 137 133 133
query41 69 67 64 64
query42 130 118 118 118
query43 475 499 468 468
query44 1222 791 745 745
query45 189 175 173 173
query46 874 992 633 633
query47 1772 1759 1689 1689
query48 401 426 311 311
query49 773 493 402 402
query50 648 678 402 402
query51 3910 3969 4033 3969
query52 114 104 99 99
query53 246 276 196 196
query54 313 309 278 278
query55 90 88 82 82
query56 328 321 305 305
query57 1187 1236 1143 1143
query58 286 278 267 267
query59 2565 2694 2648 2648
query60 351 336 320 320
query61 156 158 159 158
query62 797 719 707 707
query63 226 194 189 189
query64 4387 1154 885 885
query65 4023 3981 3922 3922
query66 1102 457 340 340
query67 15313 15187 14929 14929
query68 8345 924 597 597
query69 498 318 287 287
query70 1343 1248 1266 1248
query71 438 343 323 323
query72 5793 4861 4862 4861
query73 644 577 355 355
query74 9006 8904 8911 8904
query75 3301 3363 2779 2779
query76 3358 1142 721 721
query77 517 406 316 316
query78 9459 9625 8841 8841
query79 2432 803 604 604
query80 637 577 514 514
query81 518 257 231 231
query82 436 158 135 135
query83 269 261 255 255
query84 263 116 92 92
query85 979 487 447 447
query86 378 336 280 280
query87 3751 3757 3643 3643
query88 3737 2266 2268 2266
query89 387 328 294 294
query90 1940 227 224 224
query91 174 177 144 144
query92 85 74 61 61
query93 2060 976 642 642
query94 729 453 346 346
query95 400 331 321 321
query96 496 570 289 289
query97 2912 2989 2856 2856
query98 248 211 215 211
query99 1359 1366 1333 1333
Total cold run time: 276467 ms
Total hot run time: 187814 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "codeDing18 (via GitHub)" <gi...@apache.org>.
codeDing18 commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3535350961
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3531791124
<details>
<summary>TPC-H: <b>Total hot run time: 34508 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ff31e72f5a7083d2331f4ad142aa39d2f003f3b9, data reload: false
------ Round 1 ----------------------------------
q1 17627 5171 5103 5103
q2 2082 310 213 213
q3 10244 1277 716 716
q4 10233 871 374 374
q5 7531 2365 2375 2365
q6 190 171 138 138
q7 902 746 618 618
q8 9338 1317 1110 1110
q9 6929 5123 5139 5123
q10 6820 2236 1824 1824
q11 488 318 280 280
q12 336 367 222 222
q13 17770 3700 3077 3077
q14 237 229 211 211
q15 567 500 520 500
q16 1033 991 928 928
q17 572 868 363 363
q18 7510 7189 7236 7189
q19 1102 970 549 549
q20 351 355 231 231
q21 3918 3279 2387 2387
q22 1044 1052 987 987
Total cold run time: 106824 ms
Total hot run time: 34508 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5116 5072 5095 5072
q2 246 328 236 236
q3 2184 2709 2322 2322
q4 1402 1764 1326 1326
q5 4215 4453 4614 4453
q6 215 178 135 135
q7 2024 1941 1875 1875
q8 2661 2494 2586 2494
q9 7384 7363 7198 7198
q10 3096 3238 2858 2858
q11 577 559 529 529
q12 722 798 661 661
q13 3630 3923 3266 3266
q14 275 291 292 291
q15 546 533 496 496
q16 1119 1134 1075 1075
q17 1205 1536 1436 1436
q18 7849 7716 7686 7686
q19 791 823 811 811
q20 1974 2049 1896 1896
q21 5162 4588 4372 4372
q22 1095 1045 1001 1001
Total cold run time: 53488 ms
Total hot run time: 51489 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3574738395
<details>
<summary>TPC-H: <b>Total hot run time: 34273 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ac0ca99105e49fc46ceb2450446011c65b97b7b, data reload: false
------ Round 1 ----------------------------------
q1 17629 4995 4866 4866
q2 2054 315 215 215
q3 10249 1291 729 729
q4 10214 838 370 370
q5 7537 2312 2368 2312
q6 181 170 137 137
q7 911 797 634 634
q8 9355 1328 1100 1100
q9 7059 5195 5335 5195
q10 6830 2221 1824 1824
q11 485 318 279 279
q12 336 359 219 219
q13 17769 3670 3087 3087
q14 233 239 214 214
q15 581 516 513 513
q16 1068 1012 973 973
q17 575 852 367 367
q18 7817 7233 7111 7111
q19 1228 950 545 545
q20 356 343 233 233
q21 3948 2598 2387 2387
q22 1041 1007 963 963
Total cold run time: 107456 ms
Total hot run time: 34273 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4939 5240 4878 4878
q2 328 403 325 325
q3 2204 2711 2325 2325
q4 1360 1747 1342 1342
q5 4227 4475 4594 4475
q6 224 175 130 130
q7 2087 2020 1862 1862
q8 2653 2540 2676 2540
q9 7578 7532 7482 7482
q10 3075 3250 2820 2820
q11 584 537 494 494
q12 684 823 794 794
q13 3412 3775 3372 3372
q14 301 301 294 294
q15 563 530 510 510
q16 1119 1203 1135 1135
q17 1190 1636 1383 1383
q18 8136 7749 7501 7501
q19 833 852 826 826
q20 2026 2072 1961 1961
q21 4978 4514 4331 4331
q22 1086 1067 1028 1028
Total cold run time: 53587 ms
Total hot run time: 51808 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3574346583
# FE UT Coverage Report
Increment line coverage ` 45.24% (19/42)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #58032:
URL: https://github.com/apache/doris/pull/58032#discussion_r2554427858
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisLexer.g4:
##########
@@ -484,6 +485,7 @@ SCHEDULER: 'SCHEDULER';
SCHEMA: 'SCHEMA';
SCHEMAS: 'SCHEMAS';
SECOND: 'SECOND';
+SECOND_MICROSECOND: 'SECOND_MICROSECOND';
Review Comment:
not seen implementation of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3574791722
<details>
<summary>TPC-DS: <b>Total hot run time: 185034 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ac0ca99105e49fc46ceb2450446011c65b97b7b, data reload: false
query1 1057 414 406 406
query2 6576 1621 1621 1621
query3 6764 226 223 223
query4 26114 22958 22595 22595
query5 4408 642 473 473
query6 341 258 229 229
query7 4651 517 316 316
query8 316 262 257 257
query9 8699 2592 2609 2592
query10 513 361 320 320
query11 15240 14902 14762 14762
query12 181 117 115 115
query13 1695 582 461 461
query14 10453 8886 8907 8886
query15 215 205 193 193
query16 7771 677 495 495
query17 1263 776 639 639
query18 2045 438 347 347
query19 220 216 191 191
query20 132 127 123 123
query21 237 139 126 126
query22 3937 4102 4040 4040
query23 33050 31946 31924 31924
query24 8424 2424 2462 2424
query25 619 551 480 480
query26 1291 283 167 167
query27 2757 501 352 352
query28 4378 2155 2128 2128
query29 793 605 486 486
query30 304 241 212 212
query31 831 697 640 640
query32 90 75 76 75
query33 589 377 330 330
query34 797 868 535 535
query35 798 853 723 723
query36 919 949 878 878
query37 126 113 86 86
query38 3297 3387 3312 3312
query39 1488 1422 1403 1403
query40 223 130 121 121
query41 66 62 61 61
query42 128 119 116 116
query43 470 472 428 428
query44 1235 761 757 757
query45 198 194 181 181
query46 886 991 648 648
query47 1698 1717 1693 1693
query48 396 423 320 320
query49 774 482 433 433
query50 655 677 430 430
query51 3941 3867 3919 3867
query52 111 114 115 114
query53 250 259 193 193
query54 307 352 278 278
query55 94 88 89 88
query56 354 332 314 314
query57 1165 1178 1104 1104
query58 285 276 274 274
query59 2383 2534 2408 2408
query60 374 357 333 333
query61 168 154 160 154
query62 799 706 663 663
query63 229 196 196 196
query64 4478 1196 904 904
query65 4069 4000 4020 4000
query66 1107 458 335 335
query67 15275 15003 15104 15003
query68 8373 903 625 625
query69 512 330 311 311
query70 1297 1145 1125 1125
query71 439 342 309 309
query72 5898 4973 5205 4973
query73 706 648 380 380
query74 8604 8670 8576 8576
query75 3547 3340 2793 2793
query76 3444 1131 752 752
query77 605 404 302 302
query78 9587 9686 8918 8918
query79 2699 805 609 609
query80 689 585 499 499
query81 525 273 236 236
query82 474 160 127 127
query83 270 264 253 253
query84 259 119 92 92
query85 952 487 447 447
query86 387 303 287 287
query87 3441 3556 3398 3398
query88 3735 2266 2287 2266
query89 393 324 293 293
query90 1932 227 220 220
query91 180 176 140 140
query92 84 68 64 64
query93 2262 973 651 651
query94 724 464 347 347
query95 498 414 397 397
query96 503 573 288 288
query97 2927 2933 2890 2890
query98 242 214 202 202
query99 1318 1379 1283 1283
Total cold run time: 273003 ms
Total hot run time: 185034 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "codeDing18 (via GitHub)" <gi...@apache.org>.
codeDing18 commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3533354985
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "codeDing18 (via GitHub)" <gi...@apache.org>.
codeDing18 commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3531690671
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3531950083
# BE UT Coverage Report
Increment line coverage `67.44% (29/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/ff31e72f5a7083d2331f4ad142aa39d2f003f3b9_ff31e72f5a7083d2331f4ad142aa39d2f003f3b9/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/ff31e72f5a7083d2331f4ad142aa39d2f003f3b9_ff31e72f5a7083d2331f4ad142aa39d2f003f3b9/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.82% (18288/34624) |
| Line Coverage | 38.19% (166298/435483) |
| Region Coverage | 33.17% (129242/389602) |
| Branch Coverage | 33.91% (55471/163588) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3532320034
# FE Regression Coverage Report
Increment line coverage ` 77.14% (27/35)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_ff31e72f5a7083d2331f4ad142aa39d2f003f3b9_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_ff31e72f5a7083d2331f4ad142aa39d2f003f3b9_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3569131652
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (43/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_2de27f5285e39902e323f0049a9307a9a40c64e9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_2de27f5285e39902e323f0049a9307a9a40c64e9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.53% (24393/34102) |
| Line Coverage | 58.00% (253554/437173) |
| Region Coverage | 53.31% (211608/396973) |
| Branch Coverage | 54.69% (90314/165144) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "codeDing18 (via GitHub)" <gi...@apache.org>.
codeDing18 commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3574052014
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #58032:
URL: https://github.com/apache/doris/pull/58032#discussion_r2557846585
##########
regression-test/suites/query_p0/sql_functions/datetime_functions/test_dateadd_with_other_timeunit.groovy:
##########
@@ -171,4 +171,61 @@ suite("test_dateadd_with_other_timeunit") {
exception "Invalid hours format"
}
+
+ // MINUTE_SECOND
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:-10" MINUTE_SECOND); """
+
+ qt_sql """ select date_add(test_datetime, INTERVAL "1:1" MINUTE_SECOND) result from ${tableName}; """
+ qt_sql """ select date_add(test_datetime, INTERVAL "1:1" MINUTE_SECOND) result from ${tableName}; """
+
+ qt_sql """ select date_add(test_date, INTERVAL "-1:1" MINUTE_SECOND) result from ${tableName}; """
+ qt_sql """ select date_add(test_date, INTERVAL "-1:-1" MINUTE_SECOND) result from ${tableName}; """
+
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:-10" MINUTE_SECOND); """
+
+ test {
+ sql """ select date_add(test_datetime, INTERVAL '1' MINUTE_SECOND) result from ${tableName}; """
Review Comment:
那这个地方有大问题,以前PR可能也有。BE的行为是报错,那FE常量折叠也不应该返回NULL。在这个PR里面一起修改了吧,加一些测试来保证这一点 。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3579098569
# FE Regression Coverage Report
Increment line coverage ` 61.90% (26/42)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3532253310
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (43/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_ff31e72f5a7083d2331f4ad142aa39d2f003f3b9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_ff31e72f5a7083d2331f4ad142aa39d2f003f3b9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.55% (24343/34024) |
| Line Coverage | 58.01% (253020/436157) |
| Region Coverage | 53.32% (210683/395113) |
| Branch Coverage | 54.68% (90034/164663) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3533598613
<details>
<summary>TPC-DS: <b>Total hot run time: 187820 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e, data reload: false
query1 1018 402 392 392
query2 6561 1688 1716 1688
query3 6764 224 223 223
query4 26674 23508 23114 23114
query5 4420 683 484 484
query6 347 270 233 233
query7 4655 499 301 301
query8 332 276 271 271
query9 8695 2620 2615 2615
query10 498 353 308 308
query11 15708 15183 14892 14892
query12 191 125 119 119
query13 1698 583 457 457
query14 11276 9283 9327 9283
query15 196 188 171 171
query16 7530 671 404 404
query17 1216 764 630 630
query18 1994 416 311 311
query19 210 208 175 175
query20 141 131 125 125
query21 214 130 113 113
query22 3921 4095 3885 3885
query23 33757 32975 32937 32937
query24 8503 2493 2432 2432
query25 596 508 453 453
query26 1254 279 171 171
query27 2737 512 355 355
query28 4381 2205 2196 2196
query29 831 647 533 533
query30 305 233 204 204
query31 949 793 715 715
query32 84 72 79 72
query33 602 420 355 355
query34 807 860 555 555
query35 833 842 766 766
query36 985 1011 901 901
query37 124 111 88 88
query38 3540 3573 3492 3492
query39 1535 1418 1430 1418
query40 227 130 123 123
query41 64 61 61 61
query42 128 117 116 116
query43 505 515 488 488
query44 1274 751 746 746
query45 186 181 173 173
query46 920 1003 680 680
query47 1744 1789 1688 1688
query48 411 420 312 312
query49 787 501 425 425
query50 680 680 417 417
query51 3866 3941 4068 3941
query52 112 114 104 104
query53 242 280 201 201
query54 311 304 271 271
query55 89 85 82 82
query56 318 315 304 304
query57 1176 1161 1106 1106
query58 291 280 296 280
query59 2475 2629 2504 2504
query60 340 371 349 349
query61 159 153 151 151
query62 815 716 672 672
query63 239 196 197 196
query64 4365 1137 905 905
query65 4026 3947 3911 3911
query66 1105 434 335 335
query67 15292 15020 14746 14746
query68 6672 974 599 599
query69 492 323 289 289
query70 1343 1253 1265 1253
query71 446 371 321 321
query72 5819 4877 4940 4877
query73 692 618 355 355
query74 8830 9179 8900 8900
query75 3304 3356 2910 2910
query76 3325 1170 785 785
query77 513 441 357 357
query78 9538 9824 8795 8795
query79 988 856 619 619
query80 1085 578 499 499
query81 551 261 235 235
query82 430 164 139 139
query83 281 267 261 261
query84 250 107 92 92
query85 889 477 430 430
query86 343 316 307 307
query87 3768 3736 3640 3640
query88 2906 2302 2285 2285
query89 391 340 305 305
query90 1753 238 227 227
query91 176 164 145 145
query92 68 74 65 65
query93 1046 995 644 644
query94 728 444 349 349
query95 414 333 315 315
query96 498 585 293 293
query97 2898 2988 2860 2860
query98 239 216 216 216
query99 1325 1437 1329 1329
Total cold run time: 270230 ms
Total hot run time: 187820 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3533538865
<details>
<summary>TPC-H: <b>Total hot run time: 34251 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e, data reload: false
------ Round 1 ----------------------------------
q1 17605 5171 5059 5059
q2 2052 308 202 202
q3 10282 1286 726 726
q4 10222 889 381 381
q5 7533 2223 2445 2223
q6 180 171 142 142
q7 876 794 634 634
q8 9353 1329 1296 1296
q9 6825 5175 5131 5131
q10 6905 2213 1821 1821
q11 494 299 283 283
q12 338 369 232 232
q13 17774 3711 3025 3025
q14 224 239 208 208
q15 580 505 498 498
q16 1014 996 949 949
q17 602 864 365 365
q18 7413 7084 6946 6946
q19 1195 943 571 571
q20 350 335 234 234
q21 3794 3289 2348 2348
q22 1064 1012 977 977
Total cold run time: 106675 ms
Total hot run time: 34251 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5153 5209 5213 5209
q2 257 328 234 234
q3 2188 2702 2300 2300
q4 1381 1802 1311 1311
q5 4208 4457 4508 4457
q6 208 169 128 128
q7 2046 2024 1807 1807
q8 2772 2588 2558 2558
q9 7332 7318 7321 7318
q10 3101 3283 2828 2828
q11 586 554 501 501
q12 689 773 606 606
q13 3592 3957 3247 3247
q14 286 308 319 308
q15 555 504 507 504
q16 1063 1224 1145 1145
q17 1215 1514 1430 1430
q18 8111 7522 7739 7522
q19 813 983 1008 983
q20 1980 2098 1912 1912
q21 4815 4370 4451 4370
q22 1093 1038 997 997
Total cold run time: 53444 ms
Total hot run time: 51675 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3533992148
# FE Regression Coverage Report
Increment line coverage ` 77.14% (27/35)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3574813396
<details>
<summary>ClickBench: <b>Total hot run time: 27.47 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9ac0ca99105e49fc46ceb2450446011c65b97b7b, data reload: false
query1 0.05 0.05 0.05
query2 0.09 0.05 0.05
query3 0.26 0.08 0.08
query4 1.61 0.12 0.11
query5 0.28 0.24 0.25
query6 1.19 0.65 0.65
query7 0.04 0.03 0.02
query8 0.06 0.04 0.04
query9 0.59 0.52 0.52
query10 0.58 0.58 0.57
query11 0.16 0.11 0.11
query12 0.15 0.11 0.12
query13 0.63 0.61 0.61
query14 0.99 0.99 1.01
query15 0.86 0.84 0.85
query16 0.40 0.38 0.40
query17 1.02 1.02 1.00
query18 0.21 0.23 0.20
query19 1.92 1.88 1.82
query20 0.02 0.01 0.02
query21 15.44 0.21 0.12
query22 4.88 0.06 0.04
query23 15.63 0.26 0.10
query24 2.65 0.46 1.02
query25 0.06 0.06 0.06
query26 0.15 0.14 0.13
query27 0.07 0.05 0.06
query28 4.97 1.16 0.94
query29 12.56 3.89 3.22
query30 0.27 0.13 0.12
query31 2.82 0.59 0.38
query32 3.23 0.54 0.47
query33 3.04 3.03 3.11
query34 15.82 5.18 4.53
query35 4.56 4.57 4.59
query36 0.69 0.50 0.49
query37 0.10 0.07 0.07
query38 0.06 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.15 0.14
query41 0.09 0.03 0.03
query42 0.04 0.02 0.03
query43 0.05 0.04 0.03
Total cold run time: 98.5 s
Total hot run time: 27.47 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3568839095
<details>
<summary>TPC-H: <b>Total hot run time: 34563 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2de27f5285e39902e323f0049a9307a9a40c64e9, data reload: false
------ Round 1 ----------------------------------
q1 17607 5053 4955 4955
q2 2048 316 218 218
q3 10229 1350 752 752
q4 10233 978 378 378
q5 7487 2481 2378 2378
q6 189 176 140 140
q7 963 766 634 634
q8 9348 1378 1122 1122
q9 7228 5416 5430 5416
q10 6932 2215 1796 1796
q11 493 314 283 283
q12 364 374 225 225
q13 17810 3700 3033 3033
q14 228 235 216 216
q15 582 512 505 505
q16 1021 1005 940 940
q17 620 881 363 363
q18 7495 7196 7149 7149
q19 1092 959 562 562
q20 361 346 230 230
q21 3948 3182 2326 2326
q22 998 1013 942 942
Total cold run time: 107276 ms
Total hot run time: 34563 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4983 4988 4981 4981
q2 331 391 324 324
q3 2207 2685 2314 2314
q4 1360 1760 1361 1361
q5 4259 4522 4527 4522
q6 208 166 127 127
q7 2034 1954 1834 1834
q8 2755 2559 2549 2549
q9 7626 7559 7587 7559
q10 3091 3329 2827 2827
q11 595 543 509 509
q12 676 773 701 701
q13 3590 3988 3386 3386
q14 307 325 291 291
q15 547 532 495 495
q16 1076 1107 1062 1062
q17 1200 1556 1354 1354
q18 7785 7768 7479 7479
q19 850 839 895 839
q20 1932 1958 1876 1876
q21 4842 4389 4307 4307
q22 1085 1037 983 983
Total cold run time: 53339 ms
Total hot run time: 51680 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3568808017
# FE UT Coverage Report
Increment line coverage ` 54.29% (19/35)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_2de27f5285e39902e323f0049a9307a9a40c64e9/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_2de27f5285e39902e323f0049a9307a9a40c64e9/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3533682532
# BE UT Coverage Report
Increment line coverage `67.44% (29/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.81% (18285/34624) |
| Line Coverage | 38.17% (166216/435483) |
| Region Coverage | 33.15% (129138/389602) |
| Branch Coverage | 33.89% (55437/163588) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3531690153
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3568506863
need a document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3568853293
<details>
<summary>TPC-DS: <b>Total hot run time: 187719 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2de27f5285e39902e323f0049a9307a9a40c64e9, data reload: false
query1 1040 443 395 395
query2 6577 1701 1707 1701
query3 6750 223 221 221
query4 26527 23924 23247 23247
query5 4320 613 467 467
query6 325 241 229 229
query7 4664 506 295 295
query8 308 276 242 242
query9 8682 2570 2592 2570
query10 503 366 288 288
query11 15127 15131 14852 14852
query12 174 121 113 113
query13 1677 601 457 457
query14 10412 9219 9484 9219
query15 201 188 168 168
query16 7293 684 505 505
query17 1232 746 604 604
query18 1973 415 319 319
query19 211 195 174 174
query20 129 130 126 126
query21 219 144 116 116
query22 3950 3987 4095 3987
query23 33961 33055 32879 32879
query24 8445 2431 2403 2403
query25 608 514 451 451
query26 1244 269 161 161
query27 2764 494 352 352
query28 4371 2179 2160 2160
query29 877 613 498 498
query30 298 228 202 202
query31 905 805 724 724
query32 85 76 71 71
query33 573 365 314 314
query34 794 865 516 516
query35 793 828 748 748
query36 945 1016 885 885
query37 118 107 87 87
query38 3513 3617 3532 3532
query39 1500 1429 1419 1419
query40 222 129 114 114
query41 66 62 62 62
query42 123 113 114 113
query43 485 496 462 462
query44 1232 768 751 751
query45 188 183 174 174
query46 871 988 640 640
query47 1748 1768 1712 1712
query48 386 432 339 339
query49 761 485 421 421
query50 653 674 415 415
query51 3845 3950 3951 3950
query52 106 109 108 108
query53 248 269 199 199
query54 302 291 269 269
query55 88 87 83 83
query56 316 324 318 318
query57 1168 1210 1111 1111
query58 282 274 265 265
query59 2502 2617 2512 2512
query60 342 342 337 337
query61 158 150 156 150
query62 797 704 668 668
query63 225 194 197 194
query64 4578 1166 857 857
query65 4048 3958 3928 3928
query66 1195 454 348 348
query67 15383 14804 14786 14786
query68 3233 994 658 658
query69 493 331 291 291
query70 1370 1309 1283 1283
query71 410 354 311 311
query72 6338 5217 5091 5091
query73 634 588 359 359
query74 9140 8881 8929 8881
query75 3296 3295 2811 2811
query76 3120 1155 738 738
query77 500 406 315 315
query78 9553 9655 8969 8969
query79 2138 788 602 602
query80 1548 591 497 497
query81 551 256 223 223
query82 412 154 131 131
query83 303 260 255 255
query84 260 102 92 92
query85 929 507 446 446
query86 466 300 293 293
query87 3674 3762 3584 3584
query88 2850 2250 2240 2240
query89 380 333 292 292
query90 1887 218 215 215
query91 165 168 134 134
query92 79 64 64 64
query93 1705 1029 686 686
query94 734 472 318 318
query95 405 327 317 317
query96 480 566 284 284
query97 2885 2933 2878 2878
query98 253 208 212 208
query99 1292 1403 1270 1270
Total cold run time: 267889 ms
Total hot run time: 187719 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3568993232
# BE UT Coverage Report
Increment line coverage `67.44% (29/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2de27f5285e39902e323f0049a9307a9a40c64e9_2de27f5285e39902e323f0049a9307a9a40c64e9/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2de27f5285e39902e323f0049a9307a9a40c64e9_2de27f5285e39902e323f0049a9307a9a40c64e9/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.62% (18282/34741) |
| Line Coverage | 38.07% (166366/437007) |
| Region Coverage | 33.05% (129435/391665) |
| Branch Coverage | 33.82% (55505/164133) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3575287827
# FE Regression Coverage Report
Increment line coverage ` 64.29% (27/42)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3578671850
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3533665755
# FE UT Coverage Report
Increment line coverage ` 54.29% (19/35)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3578933254
# BE Regression && UT Coverage Report
Increment line coverage `83.72% (36/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58032_9ac0ca99105e49fc46ceb2450446011c65b97b7b_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.61% (24477/34183) |
| Line Coverage | 58.08% (254931/438900) |
| Region Coverage | 53.13% (212167/399316) |
| Branch Coverage | 54.66% (90704/165952) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3578901610
# BE UT Coverage Report
Increment line coverage `67.44% (29/43)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/9ac0ca99105e49fc46ceb2450446011c65b97b7b_9ac0ca99105e49fc46ceb2450446011c65b97b7b/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/9ac0ca99105e49fc46ceb2450446011c65b97b7b_9ac0ca99105e49fc46ceb2450446011c65b97b7b/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.90% (18421/34821) |
| Line Coverage | 38.38% (168341/438612) |
| Region Coverage | 33.19% (130707/393854) |
| Branch Coverage | 34.11% (56231/164855) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "codeDing18 (via GitHub)" <gi...@apache.org>.
codeDing18 commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3574652846
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "codeDing18 (via GitHub)" <gi...@apache.org>.
codeDing18 commented on code in PR #58032:
URL: https://github.com/apache/doris/pull/58032#discussion_r2558779122
##########
regression-test/suites/query_p0/sql_functions/datetime_functions/test_dateadd_with_other_timeunit.groovy:
##########
@@ -171,4 +171,61 @@ suite("test_dateadd_with_other_timeunit") {
exception "Invalid hours format"
}
+
+ // MINUTE_SECOND
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:-10" MINUTE_SECOND); """
+
+ qt_sql """ select date_add(test_datetime, INTERVAL "1:1" MINUTE_SECOND) result from ${tableName}; """
+ qt_sql """ select date_add(test_datetime, INTERVAL "1:1" MINUTE_SECOND) result from ${tableName}; """
+
+ qt_sql """ select date_add(test_date, INTERVAL "-1:1" MINUTE_SECOND) result from ${tableName}; """
+ qt_sql """ select date_add(test_date, INTERVAL "-1:-1" MINUTE_SECOND) result from ${tableName}; """
+
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:-10" MINUTE_SECOND); """
+
+ test {
+ sql """ select date_add(test_datetime, INTERVAL '1' MINUTE_SECOND) result from ${tableName}; """
Review Comment:
fe return exception after fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3531861739
<details>
<summary>ClickBench: <b>Total hot run time: 27.39 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ff31e72f5a7083d2331f4ad142aa39d2f003f3b9, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.05
query3 0.26 0.08 0.09
query4 1.61 0.12 0.11
query5 0.27 0.25 0.25
query6 1.15 0.65 0.64
query7 0.03 0.03 0.03
query8 0.06 0.04 0.04
query9 0.57 0.53 0.53
query10 0.59 0.57 0.57
query11 0.16 0.12 0.11
query12 0.14 0.12 0.12
query13 0.62 0.60 0.61
query14 1.02 1.00 1.00
query15 0.85 0.83 0.82
query16 0.39 0.39 0.40
query17 1.04 1.06 1.00
query18 0.22 0.20 0.20
query19 1.90 1.82 1.77
query20 0.02 0.01 0.01
query21 15.46 0.19 0.13
query22 5.06 0.08 0.05
query23 15.65 0.26 0.11
query24 3.50 1.13 0.27
query25 0.07 0.06 0.07
query26 0.13 0.13 0.13
query27 0.06 0.06 0.05
query28 4.68 1.14 0.93
query29 12.63 3.85 3.28
query30 0.28 0.14 0.12
query31 2.81 0.58 0.38
query32 3.24 0.56 0.46
query33 3.06 3.11 3.05
query34 15.94 5.16 4.56
query35 4.56 4.58 4.62
query36 0.68 0.52 0.50
query37 0.10 0.07 0.07
query38 0.06 0.04 0.04
query39 0.04 0.03 0.02
query40 0.17 0.14 0.15
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 99.39 s
Total hot run time: 27.39 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3533628302
<details>
<summary>ClickBench: <b>Total hot run time: 27.44 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c8cf12bfb2befefcb6b8d5ad2044e39a8d65a46e, data reload: false
query1 0.05 0.05 0.05
query2 0.10 0.05 0.05
query3 0.26 0.08 0.09
query4 1.61 0.11 0.11
query5 0.27 0.25 0.24
query6 1.18 0.65 0.65
query7 0.03 0.03 0.02
query8 0.05 0.04 0.04
query9 0.58 0.53 0.53
query10 0.58 0.58 0.57
query11 0.17 0.12 0.11
query12 0.15 0.12 0.12
query13 0.63 0.60 0.61
query14 1.02 0.99 1.01
query15 0.85 0.82 0.83
query16 0.40 0.40 0.39
query17 1.01 1.01 1.02
query18 0.22 0.20 0.20
query19 1.91 1.84 1.77
query20 0.02 0.01 0.01
query21 15.46 0.19 0.13
query22 5.14 0.07 0.05
query23 15.70 0.26 0.10
query24 2.83 1.06 0.35
query25 0.07 0.06 0.06
query26 0.15 0.14 0.15
query27 0.06 0.06 0.05
query28 4.20 1.14 0.96
query29 12.55 3.84 3.18
query30 0.29 0.14 0.12
query31 2.82 0.60 0.38
query32 3.23 0.56 0.47
query33 3.11 3.10 3.07
query34 15.83 5.21 4.57
query35 4.65 4.60 4.58
query36 0.67 0.50 0.50
query37 0.10 0.07 0.07
query38 0.06 0.04 0.04
query39 0.04 0.02 0.03
query40 0.19 0.15 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.04
Total cold run time: 98.41 s
Total hot run time: 27.44 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #58032:
URL: https://github.com/apache/doris/pull/58032#discussion_r2554431687
##########
regression-test/suites/query_p0/sql_functions/datetime_functions/test_dateadd_with_other_timeunit.groovy:
##########
@@ -171,4 +171,61 @@ suite("test_dateadd_with_other_timeunit") {
exception "Invalid hours format"
}
+
+ // MINUTE_SECOND
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "1:-10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:-1" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:10" MINUTE_SECOND); """
+ testFoldConst """ select date_add("2025-10-29", INTERVAL "-1:-10" MINUTE_SECOND); """
+
+ qt_sql """ select date_add(test_datetime, INTERVAL "1:1" MINUTE_SECOND) result from ${tableName}; """
+ qt_sql """ select date_add(test_datetime, INTERVAL "1:1" MINUTE_SECOND) result from ${tableName}; """
+
+ qt_sql """ select date_add(test_date, INTERVAL "-1:1" MINUTE_SECOND) result from ${tableName}; """
+ qt_sql """ select date_add(test_date, INTERVAL "-1:-1" MINUTE_SECOND) result from ${tableName}; """
+
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29 10:10:10", INTERVAL "-1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "1:-10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:-1" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:10" MINUTE_SECOND); """
+ qt_sql """ select date_add("2025-10-29", INTERVAL "-1:-10" MINUTE_SECOND); """
+
+ test {
+ sql """ select date_add(test_datetime, INTERVAL '1' MINUTE_SECOND) result from ${tableName}; """
Review Comment:
if the arguments are both literal, will we get null or exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "codeDing18 (via GitHub)" <gi...@apache.org>.
codeDing18 commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3568691958
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](function) The date_add function supports MINUTE_SECOND as interval type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58032:
URL: https://github.com/apache/doris/pull/58032#issuecomment-3568861099
<details>
<summary>ClickBench: <b>Total hot run time: 27.41 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2de27f5285e39902e323f0049a9307a9a40c64e9, data reload: false
query1 0.06 0.05 0.04
query2 0.09 0.05 0.07
query3 0.26 0.08 0.08
query4 1.60 0.11 0.11
query5 0.26 0.25 0.25
query6 1.17 0.65 0.64
query7 0.03 0.02 0.02
query8 0.05 0.05 0.04
query9 0.58 0.52 0.51
query10 0.57 0.57 0.57
query11 0.16 0.10 0.11
query12 0.15 0.12 0.12
query13 0.62 0.60 0.60
query14 1.01 0.99 0.99
query15 0.84 0.81 0.83
query16 0.38 0.38 0.38
query17 0.99 1.02 1.02
query18 0.21 0.21 0.20
query19 1.88 1.76 1.82
query20 0.02 0.01 0.01
query21 15.44 0.16 0.13
query22 5.14 0.07 0.05
query23 15.67 0.26 0.11
query24 2.66 0.54 0.65
query25 0.07 0.06 0.07
query26 0.15 0.13 0.13
query27 0.07 0.05 0.05
query28 4.29 1.14 0.92
query29 12.57 3.84 3.16
query30 0.28 0.14 0.12
query31 2.81 0.59 0.38
query32 3.22 0.56 0.47
query33 3.01 3.07 3.14
query34 15.85 5.13 4.55
query35 4.59 4.57 4.54
query36 0.68 0.50 0.49
query37 0.10 0.07 0.07
query38 0.07 0.04 0.03
query39 0.04 0.03 0.03
query40 0.16 0.13 0.13
query41 0.08 0.04 0.03
query42 0.04 0.03 0.02
query43 0.04 0.04 0.03
Total cold run time: 97.96 s
Total hot run time: 27.41 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org