[GitHub] [hudi] vinothchandar commented on a diff in pull request #8326: [HUDI-6006] Deprecate hoodie.payload.ordering.field

["vinothchandar (via GitHub)" <gi...@apache.org>]

vinothchandar commented on code in PR #8326:
URL: https://github.com/apache/hudi/pull/8326#discussion_r1157662922


##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/TestPreCombineUtils.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.testutils;
+
+import org.apache.hudi.common.model.HoodiePayloadProps;
+import org.apache.hudi.common.table.HoodieTableConfig;
+
+import org.junit.jupiter.params.provider.Arguments;
+
+import java.util.Arrays;
+import java.util.Properties;
+import java.util.stream.Stream;
+
+public class TestPreCombineUtils {

Review Comment:
   rename: PrecombineTestUtils? so it does not look like a test. 



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodiePayloadConfig.java:
##########
@@ -60,6 +54,14 @@ public class HoodiePayloadConfig extends HoodieConfig {
         + "the record payload class to merge records in the log against each other, merge again with the base file and "
         + "produce the final record to be written after compaction.");
 
+  /** @deprecated Use {@link HoodieWriteConfig#PRECOMBINE_FIELD_NAME} and its methods instead */

Review Comment:
   would n't the payload config be used on the read/query side as well? does not feel good to have this depend on writeConfig?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org