You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/16 04:07:56 UTC
[GitHub] [shardingsphere] TeslaCN opened a new pull request, #18384: Move logic of COM_STMT from packet to executor
TeslaCN opened a new pull request, #18384:
URL: https://github.com/apache/shardingsphere/pull/18384
Related to #18281.
The COM_STMT packet does too much, which should be done in executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18384: Move logic of COM_STMT from packet to executor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18384:
URL: https://github.com/apache/shardingsphere/pull/18384#issuecomment-1157232210
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18384](https://codecov.io/gh/apache/shardingsphere/pull/18384?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b60cbff) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0e2bc029e14b37b6e11d2c0e8b32482a2eba0ba8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e2bc02) will **decrease** coverage by `0.00%`.
> The diff coverage is `83.33%`.
```diff
@@ Coverage Diff @@
## master #18384 +/- ##
============================================
- Coverage 59.16% 59.15% -0.01%
Complexity 2197 2197
============================================
Files 3741 3741
Lines 54813 54796 -17
Branches 8003 9302 +1299
============================================
- Hits 32428 32415 -13
- Misses 19627 19631 +4
+ Partials 2758 2750 -8
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/mysql/command/MySQLCommandExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvTXlTUUxDb21tYW5kRXhlY3V0ZUVuZ2luZS5qYXZh) | `4.00% <ø> (ø)` | |
| [...ry/binary/execute/MySQLComStmtExecuteExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvYmluYXJ5L2V4ZWN1dGUvTXlTUUxDb21TdG10RXhlY3V0ZUV4ZWN1dG9yLmphdmE=) | `65.95% <80.00%> (+0.74%)` | :arrow_up: |
| [...uery/binary/execute/MySQLComStmtExecutePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L2JpbmFyeS9leGVjdXRlL015U1FMQ29tU3RtdEV4ZWN1dGVQYWNrZXQuamF2YQ==) | `92.30% <83.33%> (+1.00%)` | :arrow_up: |
| [...ntend/mysql/command/MySQLCommandPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvTXlTUUxDb21tYW5kUGFja2V0RmFjdG9yeS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...backend/text/transaction/TransactionXAHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3RyYW5zYWN0aW9uL1RyYW5zYWN0aW9uWEFIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../admin/mysql/executor/MySQLSetCharsetExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL215c3FsL2V4ZWN1dG9yL015U1FMU2V0Q2hhcnNldEV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rding/merge/ddl/fetch/FetchStreamMergedResult.java](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZGRsL2ZldGNoL0ZldGNoU3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `82.85% <0.00%> (ø)` | |
| [...nt/executor/SetReadwriteSplittingHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL1NldFJlYWR3cml0ZVNwbGl0dGluZ0hpbnRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...or/statement/impl/MySQLDCLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMRENMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `43.51% <0.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/shardingsphere/pull/18384/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18384?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18384?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0e2bc02...b60cbff](https://codecov.io/gh/apache/shardingsphere/pull/18384?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #18384: Move logic of COM_STMT from packet to executor
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #18384:
URL: https://github.com/apache/shardingsphere/pull/18384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org