You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/29 04:19:23 UTC
[GitHub] [incubator-doris] wutiangan opened a new pull request #3970: Explain verbose stmt to print tupleDesc/slotDesc information
wutiangan opened a new pull request #3970:
URL: https://github.com/apache/incubator-doris/pull/3970
fix #3969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3970: Explain verbose stmt to print tupleDesc/slotDesc information
Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on a change in pull request #3970:
URL: https://github.com/apache/incubator-doris/pull/3970#discussion_r446765379
##########
File path: fe/src/main/jflex/sql_scanner.flex
##########
@@ -239,6 +239,7 @@ import org.apache.doris.qe.SqlModeHelper;
keywordMap.put("load", new Integer(SqlParserSymbols.KW_LOAD));
keywordMap.put("local", new Integer(SqlParserSymbols.KW_LOCAL));
keywordMap.put("location", new Integer(SqlParserSymbols.KW_LOCATION));
+ keywordMap.put("materialized", new Integer(SqlParserSymbols.KW_MATERIALIZED));
Review comment:
Can you explain why add this for this PR, I noticed you delete this keyword in `sql_parser`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3970: Explain verbose stmt to print tupleDesc/slotDesc information
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3970:
URL: https://github.com/apache/incubator-doris/pull/3970#discussion_r446776613
##########
File path: fe/src/main/jflex/sql_scanner.flex
##########
@@ -239,6 +239,7 @@ import org.apache.doris.qe.SqlModeHelper;
keywordMap.put("load", new Integer(SqlParserSymbols.KW_LOAD));
keywordMap.put("local", new Integer(SqlParserSymbols.KW_LOCAL));
keywordMap.put("location", new Integer(SqlParserSymbols.KW_LOCATION));
+ keywordMap.put("materialized", new Integer(SqlParserSymbols.KW_MATERIALIZED));
Review comment:
I didn't delete this keyword “materialized”. The keywords “materialized” are not sorted in alphabetical order, so I only put this keyword in the position it should be
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3970: Explain verbose stmt to print tupleDesc/slotDesc information
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3970:
URL: https://github.com/apache/incubator-doris/pull/3970
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org