You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Gopal Vijayaraghavan (Jira)" <ji...@apache.org> on 2020/02/26 03:08:00 UTC
[jira] [Commented] (HIVE-22930) Performance: ASTNode::getName()
allocates within the walker loops
[ https://issues.apache.org/jira/browse/HIVE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045106#comment-17045106 ]
Gopal Vijayaraghavan commented on HIVE-22930:
---------------------------------------------
No idea why that is even used here - the numbers here are not constants across builds.
> Performance: ASTNode::getName() allocates within the walker loops
> -----------------------------------------------------------------
>
> Key: HIVE-22930
> URL: https://issues.apache.org/jira/browse/HIVE-22930
> Project: Hive
> Issue Type: Bug
> Reporter: Gopal Vijayaraghavan
> Priority: Major
> Attachments: ASTNode-name.png
>
>
> {code}
> /*
> * (non-Javadoc)
> *
> * @see org.apache.hadoop.hive.ql.lib.Node#getName()
> */
> @Override
> public String getName() {
> return String.valueOf(super.getToken().getType());
> }
> {code}
> !ASTNode-name.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)