You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/11/30 08:13:57 UTC
[native-toolchain-CR] IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18058
Change subject: IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
......................................................................
IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
ORC-1020 improves read performance of the ORC library in scanning random
integers. Columns that encoded into integers, e.g. dictionary encoded
strings, will also benifit from this. This patch bump the ORC version
from 1.7.0-p3 to 1.7.0-p4 to have the improvement.
Test:
- Build ORC locally.
Change-Id: Id0d3cc3b357e2f03f2eca7c289ec376d12d58061
---
M buildall.sh
A source/orc/orc-1.7.0-patches/0004-ORC-1020-C-Optimize-RleDecoderV2-nextDirect-base-on-.patch
2 files changed, 962 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/58/18058/1
--
To view, visit http://gerrit.cloudera.org:8080/18058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0d3cc3b357e2f03f2eca7c289ec376d12d58061
Gerrit-Change-Number: 18058
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[native-toolchain-CR] IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18058 )
Change subject: IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Carry on Csaba's +2.
http://gerrit.cloudera.org:8080/#/c/18058/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18058/1//COMMIT_MSG@11
PS1, Line 11: bump
> nit: bumps
Done
--
To view, visit http://gerrit.cloudera.org:8080/18058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0d3cc3b357e2f03f2eca7c289ec376d12d58061
Gerrit-Change-Number: 18058
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 00:37:53 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Csaba Ringhofer,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18058
to look at the new patch set (#2).
Change subject: IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
......................................................................
IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
ORC-1020 improves read performance of the ORC library in scanning random
integers. Columns that encoded into integers, e.g. dictionary encoded
strings, will also benifit from this. This patch bumps the ORC version
from 1.7.0-p3 to 1.7.0-p4 to have the improvement.
Test:
- Build ORC locally.
Change-Id: Id0d3cc3b357e2f03f2eca7c289ec376d12d58061
---
M buildall.sh
A source/orc/orc-1.7.0-patches/0004-ORC-1020-C-Optimize-RleDecoderV2-nextDirect-base-on-.patch
2 files changed, 962 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/58/18058/2
--
To view, visit http://gerrit.cloudera.org:8080/18058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0d3cc3b357e2f03f2eca7c289ec376d12d58061
Gerrit-Change-Number: 18058
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[native-toolchain-CR] IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18058 )
Change subject: IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0d3cc3b357e2f03f2eca7c289ec376d12d58061
Gerrit-Change-Number: 18058
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 00:38:44 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18058 )
Change subject: IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18058/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18058/1//COMMIT_MSG@11
PS1, Line 11: bump
nit: bumps
--
To view, visit http://gerrit.cloudera.org:8080/18058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0d3cc3b357e2f03f2eca7c289ec376d12d58061
Gerrit-Change-Number: 18058
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 10:32:16 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18058 )
Change subject: IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
......................................................................
IMPALA-11037: Bump ORC to 1.7.0-p4 to contain ORC-1020
ORC-1020 improves read performance of the ORC library in scanning random
integers. Columns that encoded into integers, e.g. dictionary encoded
strings, will also benifit from this. This patch bumps the ORC version
from 1.7.0-p3 to 1.7.0-p4 to have the improvement.
Test:
- Build ORC locally.
Change-Id: Id0d3cc3b357e2f03f2eca7c289ec376d12d58061
Reviewed-on: http://gerrit.cloudera.org:8080/18058
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M buildall.sh
A source/orc/orc-1.7.0-patches/0004-ORC-1020-C-Optimize-RleDecoderV2-nextDirect-base-on-.patch
2 files changed, 962 insertions(+), 3 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0d3cc3b357e2f03f2eca7c289ec376d12d58061
Gerrit-Change-Number: 18058
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>