[GitHub] [hbase] bbeaudreault commented on pull request #3926: HBASE-26546: hbase-shaded-client missing required thirdparty classes under hadoop 3.3.1

[GitBox <gi...@apache.org>]

bbeaudreault commented on pull request #3926:
URL: https://github.com/apache/hbase/pull/3926#issuecomment-988503569


   I did some investigation and cannot figure out why this works without tweaking our allow list. In fact, I checked out the original state prior to https://github.com/apache/hbase/pull/3184 and (after applying https://github.com/apache/hbase/pull/3299, which adds a different necessary exclusion) it also succeeds there. For reference, I'm running the following locally to test (which confirms runs and succeeds invariant checks):
   
   `mvn clean verify -Phadoop-3.0 -Dhadoop.profile=3.0 -Dhadoop-three.version=3.3.1 -Dcheckstyle.skip -DskipTests`
   
   I've also manually verified that the jars look correct:
   
   ```
   # should be zero
   $ jar -tf hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-3.0.0-alpha-2-SNAPSHOT.jar | grep -c "org/apache/hadoop/thirdparty"
   0
   
   # should be zero
   $ jar -tf hbase-shaded/hbase-shaded-client-byo-hadoop/target/hbase-shaded-client-byo-hadoop-3.0.0-alpha-2-SNAPSHOT.jar | grep -c "org/apache/hadoop/thirdparty"
   0
   
   # should be non-zero
   $ jar -tf hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-3.0.0-alpha-2-SNAPSHOT.jar |  grep -c "org/apache/hadoop/thirdparty"
   3092
   ```
   
   I also diffed the `jar -tf` content between master and this branch, and the two byo-hadoop jars were identical while the hbase-shaded-client only included the new thirdparty classes as expected.
   
   Finally, I also pushed this to our internal fork and verified that my end-client which was previously failing is now succeeding.
   
   It seems like this should be good to merge as-is. @saintstack since you originally ran into this failure, what do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org