You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by Guillaume Nodet <gn...@gmail.com> on 2010/11/22 08:54:48 UTC
Maven filtering problem (was Re: [VOTE] Release Karaf version 2.1.2)
Yeah, and it seems to have been caused by the upgrade i did to
maven-resources-plugin 2.4.3.
That was was important in order to be able to specify different
delimiters for the archetype.
I'm trying to find where the issue comes from, but all 2.4.x seem to
have the same behavior.
The weird thing is that the unix shell scripts aren't affected.
2010/11/21 Achim Nierbeck <bc...@googlemail.com>:
> Looks like it is also an issue on trunk.
>
> Am 21.11.2010 20:51, schrieb Guillaume Nodet:
>> Right, and the admin.bat seems wrong too.
>>
>> 2010/11/21 Łukasz Dywicki <lu...@code-house.org>:
>>> Hi All,
>>> I checked the release. Everything is ok, but I found small issue in
>>> client.bat configuration file. It doesn't work because there is placeholders
>>> that are not replaced by Maven:
>>>
>>> set CLASSPATH=%KARAF_HOME%\lib\bin\karaf-client.jar
>>> set
>>> CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\sshd\sshd-core\${sshd.v
>>> ersion}\sshd-core-${sshd.version}.jar
>>> set
>>> CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\mina\mina-core\${mina.v
>>> ersion}\mina-core-${mina.version}.jar
>>> set
>>> CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\karaf\shell\org.apache.
>>> karaf.shell.console\${project.version}\org.apache.karaf.shell.console-${proj
>>> ect.version}.jar
>>>
>>> Sorry but from me it's -1. I checked linux script and it looks fine. Issue
>>> is strictly related to windows release - both build by hand and downloaded
>>> from staging repository have same issue.
>>>
>>> Debug output from maven says that these resources are filtered
>>> [DEBUG] filering
>>> D:\sources\karaf-2.1.2\assembly\src\main\filtered-resources\bin\client to
>>> D:\sources\karaf-2.1.2\assembly\target\classes\bin\client
>>> [DEBUG] file client.bat has a filtered file extension
>>>
>>> Best regards,
>>> Lukasz
>>>
>>> -----Original Message-----
>>> From: chirino@gmail.com [mailto:chirino@gmail.com] On Behalf Of Hiram
>>> Chirino
>>> Sent: Sunday, November 21, 2010 1:12 PM
>>> To: dev@karaf.apache.org
>>> Subject: Re: [VOTE] Release Karaf version 2.1.2
>>>
>>> +1
>>>
>>> Regards,
>>> Hiram
>>>
>>> FuseSource
>>> Web: http://fusesource.com/
>>>
>>>
>>>
>>>
>>> On Sat, Nov 20, 2010 at 4:37 PM, Jamie G. <ja...@gmail.com> wrote:
>>>> Hi,
>>>>
>>>> We resolved 8 issues in this release (may take some time for cwiki to
>>>> update with this page):
>>>> https://cwiki.apache.org/confluence/display/KARAF/Karaf+2.1.2+Release
>>>>
>>>> Staging repository:
>>>> https://repository.apache.org/content/repositories/orgapachekaraf-017/
>>>>
>>>> Release tags:
>>>> http://svn.apache.org/repos/asf/karaf/tags/karaf-2.1.2/
>>>>
>>>> Please vote to approve this release:
>>>>
>>>> [ ] +1 Approve the release
>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>
>>>> This vote will be open for 72 hours.
>>>>
>>>
>>
>>
>
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: Maven filtering problem (was Re: [VOTE] Release Karaf version 2.1.2)
Posted by "Jamie G." <ja...@gmail.com>.
That is a really strange issue. I've created a jira entry for tracking
the maven filtering issue here:
https://issues.apache.org/jira/browse/KARAF-292
Thanks for diving in to see what is happening here Guillaume.
On Mon, Nov 22, 2010 at 5:30 AM, Guillaume Nodet <gn...@gmail.com> wrote:
> I think I've fixed the issue.
> It was caused by the "@echo off" first line of windows batches. The
> reason seems to be that the default filtering expressions have been
> changed and it now has "@*@" as another default value, so the whole
> script was actually filtered as a single value with no replacement.
>
> On Mon, Nov 22, 2010 at 08:54, Guillaume Nodet <gn...@gmail.com> wrote:
>> Yeah, and it seems to have been caused by the upgrade i did to
>> maven-resources-plugin 2.4.3.
>> That was was important in order to be able to specify different
>> delimiters for the archetype.
>> I'm trying to find where the issue comes from, but all 2.4.x seem to
>> have the same behavior.
>> The weird thing is that the unix shell scripts aren't affected.
>>
>> 2010/11/21 Achim Nierbeck <bc...@googlemail.com>:
>>> Looks like it is also an issue on trunk.
>>>
>>> Am 21.11.2010 20:51, schrieb Guillaume Nodet:
>>>> Right, and the admin.bat seems wrong too.
>>>>
>>>> 2010/11/21 Łukasz Dywicki <lu...@code-house.org>:
>>>>> Hi All,
>>>>> I checked the release. Everything is ok, but I found small issue in
>>>>> client.bat configuration file. It doesn't work because there is placeholders
>>>>> that are not replaced by Maven:
>>>>>
>>>>> set CLASSPATH=%KARAF_HOME%\lib\bin\karaf-client.jar
>>>>> set
>>>>> CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\sshd\sshd-core\${sshd.v
>>>>> ersion}\sshd-core-${sshd.version}.jar
>>>>> set
>>>>> CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\mina\mina-core\${mina.v
>>>>> ersion}\mina-core-${mina.version}.jar
>>>>> set
>>>>> CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\karaf\shell\org.apache.
>>>>> karaf.shell.console\${project.version}\org.apache.karaf.shell.console-${proj
>>>>> ect.version}.jar
>>>>>
>>>>> Sorry but from me it's -1. I checked linux script and it looks fine. Issue
>>>>> is strictly related to windows release - both build by hand and downloaded
>>>>> from staging repository have same issue.
>>>>>
>>>>> Debug output from maven says that these resources are filtered
>>>>> [DEBUG] filering
>>>>> D:\sources\karaf-2.1.2\assembly\src\main\filtered-resources\bin\client to
>>>>> D:\sources\karaf-2.1.2\assembly\target\classes\bin\client
>>>>> [DEBUG] file client.bat has a filtered file extension
>>>>>
>>>>> Best regards,
>>>>> Lukasz
>>>>>
>>>>> -----Original Message-----
>>>>> From: chirino@gmail.com [mailto:chirino@gmail.com] On Behalf Of Hiram
>>>>> Chirino
>>>>> Sent: Sunday, November 21, 2010 1:12 PM
>>>>> To: dev@karaf.apache.org
>>>>> Subject: Re: [VOTE] Release Karaf version 2.1.2
>>>>>
>>>>> +1
>>>>>
>>>>> Regards,
>>>>> Hiram
>>>>>
>>>>> FuseSource
>>>>> Web: http://fusesource.com/
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Sat, Nov 20, 2010 at 4:37 PM, Jamie G. <ja...@gmail.com> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> We resolved 8 issues in this release (may take some time for cwiki to
>>>>>> update with this page):
>>>>>> https://cwiki.apache.org/confluence/display/KARAF/Karaf+2.1.2+Release
>>>>>>
>>>>>> Staging repository:
>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-017/
>>>>>>
>>>>>> Release tags:
>>>>>> http://svn.apache.org/repos/asf/karaf/tags/karaf-2.1.2/
>>>>>>
>>>>>> Please vote to approve this release:
>>>>>>
>>>>>> [ ] +1 Approve the release
>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>
>>>>>> This vote will be open for 72 hours.
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>>
>> --
>> Cheers,
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> Open Source SOA
>> http://fusesource.com
>>
>
>
>
> --
> Cheers,
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com
>
Re: Maven filtering problem (was Re: [VOTE] Release Karaf version 2.1.2)
Posted by Guillaume Nodet <gn...@gmail.com>.
I think I've fixed the issue.
It was caused by the "@echo off" first line of windows batches. The
reason seems to be that the default filtering expressions have been
changed and it now has "@*@" as another default value, so the whole
script was actually filtered as a single value with no replacement.
On Mon, Nov 22, 2010 at 08:54, Guillaume Nodet <gn...@gmail.com> wrote:
> Yeah, and it seems to have been caused by the upgrade i did to
> maven-resources-plugin 2.4.3.
> That was was important in order to be able to specify different
> delimiters for the archetype.
> I'm trying to find where the issue comes from, but all 2.4.x seem to
> have the same behavior.
> The weird thing is that the unix shell scripts aren't affected.
>
> 2010/11/21 Achim Nierbeck <bc...@googlemail.com>:
>> Looks like it is also an issue on trunk.
>>
>> Am 21.11.2010 20:51, schrieb Guillaume Nodet:
>>> Right, and the admin.bat seems wrong too.
>>>
>>> 2010/11/21 Łukasz Dywicki <lu...@code-house.org>:
>>>> Hi All,
>>>> I checked the release. Everything is ok, but I found small issue in
>>>> client.bat configuration file. It doesn't work because there is placeholders
>>>> that are not replaced by Maven:
>>>>
>>>> set CLASSPATH=%KARAF_HOME%\lib\bin\karaf-client.jar
>>>> set
>>>> CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\sshd\sshd-core\${sshd.v
>>>> ersion}\sshd-core-${sshd.version}.jar
>>>> set
>>>> CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\mina\mina-core\${mina.v
>>>> ersion}\mina-core-${mina.version}.jar
>>>> set
>>>> CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\karaf\shell\org.apache.
>>>> karaf.shell.console\${project.version}\org.apache.karaf.shell.console-${proj
>>>> ect.version}.jar
>>>>
>>>> Sorry but from me it's -1. I checked linux script and it looks fine. Issue
>>>> is strictly related to windows release - both build by hand and downloaded
>>>> from staging repository have same issue.
>>>>
>>>> Debug output from maven says that these resources are filtered
>>>> [DEBUG] filering
>>>> D:\sources\karaf-2.1.2\assembly\src\main\filtered-resources\bin\client to
>>>> D:\sources\karaf-2.1.2\assembly\target\classes\bin\client
>>>> [DEBUG] file client.bat has a filtered file extension
>>>>
>>>> Best regards,
>>>> Lukasz
>>>>
>>>> -----Original Message-----
>>>> From: chirino@gmail.com [mailto:chirino@gmail.com] On Behalf Of Hiram
>>>> Chirino
>>>> Sent: Sunday, November 21, 2010 1:12 PM
>>>> To: dev@karaf.apache.org
>>>> Subject: Re: [VOTE] Release Karaf version 2.1.2
>>>>
>>>> +1
>>>>
>>>> Regards,
>>>> Hiram
>>>>
>>>> FuseSource
>>>> Web: http://fusesource.com/
>>>>
>>>>
>>>>
>>>>
>>>> On Sat, Nov 20, 2010 at 4:37 PM, Jamie G. <ja...@gmail.com> wrote:
>>>>> Hi,
>>>>>
>>>>> We resolved 8 issues in this release (may take some time for cwiki to
>>>>> update with this page):
>>>>> https://cwiki.apache.org/confluence/display/KARAF/Karaf+2.1.2+Release
>>>>>
>>>>> Staging repository:
>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-017/
>>>>>
>>>>> Release tags:
>>>>> http://svn.apache.org/repos/asf/karaf/tags/karaf-2.1.2/
>>>>>
>>>>> Please vote to approve this release:
>>>>>
>>>>> [ ] +1 Approve the release
>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>
>>>>> This vote will be open for 72 hours.
>>>>>
>>>>
>>>
>>>
>>
>>
>
>
>
> --
> Cheers,
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com