You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by zhou xing <xi...@cn.ibm.com> on 2016/04/14 10:01:08 UTC
Review Request 46190: Slave rename - Update standard output messages
in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/
-----------------------------------------------------------
Review request for mesos, Kevin Klues and Vinod Kone.
Bugs: MESOS-5057
https://issues.apache.org/jira/browse/MESOS-5057
Repository: mesos
Description
-------
[#MESOS-5057]
Rename 'slave' to 'agent' in the standard output messages of
libprocess
Diffs
-----
3rdparty/libprocess/src/test-master.cpp 03f2f83613674b3b9edfe76b76adb9b2513c1f06
3rdparty/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4
Diff: https://reviews.apache.org/r/46190/diff/
Testing
-------
make
make check
Thanks,
zhou xing
Re: Review Request 46190: Slave rename - Update standard output
messages in libprocess.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/#review128993
-----------------------------------------------------------
Can you comment in the testing section how you verified that you covered everything?
- Kevin Klues
On April 14, 2016, 8:01 a.m., zhou xing wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46190/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 8:01 a.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Bugs: MESOS-5057
> https://issues.apache.org/jira/browse/MESOS-5057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [#MESOS-5057]
> Rename 'slave' to 'agent' in the standard output messages of
> libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/test-master.cpp 03f2f83613674b3b9edfe76b76adb9b2513c1f06
> 3rdparty/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4
>
> Diff: https://reviews.apache.org/r/46190/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> zhou xing
>
>
Re: Review Request 46190: Slave rename - Update standard output
messages in libprocess.
Posted by zhou xing <xi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/
-----------------------------------------------------------
(Updated 四月 18, 2016, 2:31 a.m.)
Review request for mesos, Kevin Klues and Vinod Kone.
Changes
-------
rebased the code
Bugs: MESOS-5057
https://issues.apache.org/jira/browse/MESOS-5057
Repository: mesos
Description
-------
[#MESOS-5057]
Rename 'slave' to 'agent' in the standard output messages of
libprocess
Diffs (updated)
-----
3rdparty/libprocess/src/test-master.cpp 03f2f83613674b3b9edfe76b76adb9b2513c1f06
3rdparty/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4
Diff: https://reviews.apache.org/r/46190/diff/
Testing
-------
Perform the following regular expression on 'mesos/3rdparty' folder to find out all the message strings(in Eclipse IDE):
```
^[^#include].*".*slave.*"
```
then filter out the lines that using term 'slave' as the field name or attribute name
make
make check
Thanks,
zhou xing
Re: Review Request 46190: Slave rename - Update standard output
messages in libprocess.
Posted by zhou xing <xi...@cn.ibm.com>.
> On 四月 18, 2016, 12:59 a.m., Vinod Kone wrote:
> > Ship It!
>
> Vinod Kone wrote:
> Can you rebase?
Hi Vinod, has rebased the code, please take a look, thanks
- zhou
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/#review129276
-----------------------------------------------------------
On 四月 18, 2016, 2:31 a.m., zhou xing wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46190/
> -----------------------------------------------------------
>
> (Updated 四月 18, 2016, 2:31 a.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Bugs: MESOS-5057
> https://issues.apache.org/jira/browse/MESOS-5057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [#MESOS-5057]
> Rename 'slave' to 'agent' in the standard output messages of
> libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/test-master.cpp 03f2f83613674b3b9edfe76b76adb9b2513c1f06
> 3rdparty/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4
>
> Diff: https://reviews.apache.org/r/46190/diff/
>
>
> Testing
> -------
>
> Perform the following regular expression on 'mesos/3rdparty' folder to find out all the message strings(in Eclipse IDE):
> ```
> ^[^#include].*".*slave.*"
> ```
> then filter out the lines that using term 'slave' as the field name or attribute name
>
> make
> make check
>
>
> Thanks,
>
> zhou xing
>
>
Re: Review Request 46190: Slave rename - Update standard output
messages in libprocess.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 18, 2016, 12:59 a.m., Vinod Kone wrote:
> > Ship It!
Can you rebase?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/#review129276
-----------------------------------------------------------
On April 14, 2016, 11:26 p.m., zhou xing wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46190/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 11:26 p.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Bugs: MESOS-5057
> https://issues.apache.org/jira/browse/MESOS-5057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [#MESOS-5057]
> Rename 'slave' to 'agent' in the standard output messages of
> libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/test-master.cpp 03f2f83613674b3b9edfe76b76adb9b2513c1f06
> 3rdparty/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4
>
> Diff: https://reviews.apache.org/r/46190/diff/
>
>
> Testing
> -------
>
> Perform the following regular expression on 'mesos/3rdparty' folder to find out all the message strings(in Eclipse IDE):
> ```
> ^[^#include].*".*slave.*"
> ```
> then filter out the lines that using term 'slave' as the field name or attribute name
>
> make
> make check
>
>
> Thanks,
>
> zhou xing
>
>
Re: Review Request 46190: Slave rename - Update standard output
messages in libprocess.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/#review129276
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 14, 2016, 11:26 p.m., zhou xing wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46190/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 11:26 p.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Bugs: MESOS-5057
> https://issues.apache.org/jira/browse/MESOS-5057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [#MESOS-5057]
> Rename 'slave' to 'agent' in the standard output messages of
> libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/test-master.cpp 03f2f83613674b3b9edfe76b76adb9b2513c1f06
> 3rdparty/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4
>
> Diff: https://reviews.apache.org/r/46190/diff/
>
>
> Testing
> -------
>
> Perform the following regular expression on 'mesos/3rdparty' folder to find out all the message strings(in Eclipse IDE):
> ```
> ^[^#include].*".*slave.*"
> ```
> then filter out the lines that using term 'slave' as the field name or attribute name
>
> make
> make check
>
>
> Thanks,
>
> zhou xing
>
>
Re: Review Request 46190: Slave rename - Update standard output
messages in libprocess.
Posted by zhou xing <xi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/
-----------------------------------------------------------
(Updated 四月 14, 2016, 11:26 p.m.)
Review request for mesos, Kevin Klues and Vinod Kone.
Bugs: MESOS-5057
https://issues.apache.org/jira/browse/MESOS-5057
Repository: mesos
Description
-------
[#MESOS-5057]
Rename 'slave' to 'agent' in the standard output messages of
libprocess
Diffs
-----
3rdparty/libprocess/src/test-master.cpp 03f2f83613674b3b9edfe76b76adb9b2513c1f06
3rdparty/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4
Diff: https://reviews.apache.org/r/46190/diff/
Testing (updated)
-------
Perform the following regular expression on 'mesos/3rdparty' folder to find out all the message strings(in Eclipse IDE):
```
^[^#include].*".*slave.*"
```
then filter out the lines that using term 'slave' as the field name or attribute name
make
make check
Thanks,
zhou xing
Re: Review Request 46190: Slave rename - Update standard output
messages in libprocess.
Posted by zhou xing <xi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/
-----------------------------------------------------------
(Updated 四月 14, 2016, 11:25 p.m.)
Review request for mesos, Kevin Klues and Vinod Kone.
Bugs: MESOS-5057
https://issues.apache.org/jira/browse/MESOS-5057
Repository: mesos
Description
-------
[#MESOS-5057]
Rename 'slave' to 'agent' in the standard output messages of
libprocess
Diffs
-----
3rdparty/libprocess/src/test-master.cpp 03f2f83613674b3b9edfe76b76adb9b2513c1f06
3rdparty/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4
Diff: https://reviews.apache.org/r/46190/diff/
Testing (updated)
-------
Perform the following regular expression on 'mesos/src' and 'mesos/support' folder to find out all the message strings(in Eclipse IDE):
```
^[^#include].*".*slave.*"
```
then filter out the lines that using term 'slave' as the field name or attribute name
make
make check
Thanks,
zhou xing
Re: Review Request 46190: Slave rename - Update standard output
messages in libprocess.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/#review128860
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46189, 46190]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 14, 2016, 8:01 a.m., zhou xing wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46190/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 8:01 a.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Bugs: MESOS-5057
> https://issues.apache.org/jira/browse/MESOS-5057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [#MESOS-5057]
> Rename 'slave' to 'agent' in the standard output messages of
> libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/test-master.cpp 03f2f83613674b3b9edfe76b76adb9b2513c1f06
> 3rdparty/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4
>
> Diff: https://reviews.apache.org/r/46190/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> zhou xing
>
>