You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2025/12/30 03:00:13 UTC
[I] Investigate why there are `validateDataTypeForSecondaryIndex` and `validateDataTypeForSecondaryOrExpressionIndex` [hudi]
voonhous opened a new issue, #17750:
URL: https://github.com/apache/hudi/issues/17750
### Task Description
**What needs to be done:**
We need to follow up separately why there are two methods: `validateDataTypeForSecondaryIndex`, `validateDataTypeForSecondaryOrExpressionIndex`. From the naming, they seem to overlap.
In https://github.com/apache/hudi/pull/17599, changes were made to the `validateDataTypeForSecondaryOrExpressionIndex` method signature, changing the parameter type of `Avro.Schema` to `HoodieSchema`, from here, we noticed that there seems to be some method overlap.
**Why this task is needed:**
Removing code smell and potential bugs.
### Task Type
Code improvement/refactoring
### Related Issues
**Parent feature issue:** (if applicable )
**Related issues:**
NOTE: Use `Relationships` button to add parent/blocking issues after issue is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Investigate why there are `validateDataTypeForSecondaryIndex` and `validateDataTypeForSecondaryOrExpressionIndex` [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on issue #17750:
URL: https://github.com/apache/hudi/issues/17750#issuecomment-3758138273
@padhle-yrr-adi Sorry for the late reply. We're a little more responsive on Slack. You can join Slack and post any questions you have here here: apache-hudi.slack.com
We have a Dev sync that happens weekly on a Thursday/Wednesday depending on which timezone you are in.
https://hudi.apache.org/contribute/developer-sync-call/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Investigate why there are `validateDataTypeForSecondaryIndex` and `validateDataTypeForSecondaryOrExpressionIndex` [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous closed issue #17750: Investigate why there are `validateDataTypeForSecondaryIndex` and `validateDataTypeForSecondaryOrExpressionIndex`
URL: https://github.com/apache/hudi/issues/17750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Investigate why there are `validateDataTypeForSecondaryIndex` and `validateDataTypeForSecondaryOrExpressionIndex` [hudi]
Posted by "padhle-yrr-adi (via GitHub)" <gi...@apache.org>.
padhle-yrr-adi commented on issue #17750:
URL: https://github.com/apache/hudi/issues/17750#issuecomment-3699929131
@voonhous Hyy there, i m new to open source and want to contribute....can ypu plz help me out? How and where can i join the discussion groups?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org