You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "slievrly (via GitHub)" <gi...@apache.org> on 2026/06/07 14:56:26 UTC

[PR] refactor: merge threadpool and json-common modules [incubator-seata]

slievrly opened a new pull request, #8132:
URL: https://github.com/apache/incubator-seata/pull/8132

   
   Eliminate two top-level modules (threadpool, json-common) by distributing their code into existing modules based on dependency constraints, and create dedicated jdk17/jdk21 modules for version-specific extensions.
   
   threadpool refactoring:
   - Move SPI interface + platform impl (5 files) → common module
   - Move Factory + RuntimeEnvironment (2 files) → core module
   - Rename threadpool-loom → jdk21 (artifactId: seata-jdk21)
   - discovery-core/consul/etcd3/redis: use PlatformThreadPoolProvider directly to avoid core→discovery-core→core circular dependency
   
   json-common refactoring:
   - Move JsonSerializer SPI + 4 impl classes + AllowlistManager → common
   - Move JsonUtil (depends on ConfigurationFactory) → core module
   - Rename json-common-jackson3 → jdk17 (artifactId: seata-jdk17)
   - Remove json-common-core dependency from 5 downstream modules (available transitively through core)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one or more
       contributor license agreements.  See the NOTICE file distributed with
       this work for additional information regarding copyright ownership.
       The ASF licenses this file to You under the Apache License, Version 2.0
       (the "License"); you may not use this file except in compliance with
       the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
       
       Unless required by applicable law or agreed to in writing, software
       distributed under the License is distributed on an "AS IS" BASIS,
       WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
       See the License for the specific language governing permissions and
       limitations under the License.
   -->
   <!-- Please make sure you have read and understood the contributing guidelines -->
   
   - [ ] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
   - [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
   
   ### Ⅰ. Describe what this PR did
   
   
   ### Ⅱ. Does this pull request fix one issue?
   <!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
   
   
   ### Ⅲ. Why don't you add test cases (unit test/integration test)? 
   
   
   ### Ⅳ. Describe how to verify it
   
   
   ### Ⅴ. Special notes for reviews
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] refactor: merge threadpool and json-common modules [incubator-seata]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8132:
URL: https://github.com/apache/incubator-seata/pull/8132#issuecomment-4643091910

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8132?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 72.68%. Comparing base ([`386bbb9`](https://app.codecov.io/gh/apache/incubator-seata/commit/386bbb9bbe72e4145ef0f8d6baeba9d7d5665ba5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd97b5f`](https://app.codecov.io/gh/apache/incubator-seata/commit/bd97b5f58970eecd88db3d5b7a682f8b58e5b3de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##                2.x    #8132      +/-   ##
   ============================================
   - Coverage     72.75%   72.68%   -0.07%     
     Complexity      883      883              
   ============================================
     Files          1327     1315      -12     
     Lines         50742    50229     -513     
     Branches       6055     5994      -61     
   ============================================
   - Hits          36918    36511     -407     
   + Misses        10820    10752      -68     
   + Partials       3004     2966      -38     
   ```
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/8132?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ery/registry/consul/ConsulRegistryServiceImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/8132?src=pr&el=tree&filepath=discovery%2Fseata-discovery-consul%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fdiscovery%2Fregistry%2Fconsul%2FConsulRegistryServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGlzY292ZXJ5L3NlYXRhLWRpc2NvdmVyeS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlYXRhL2Rpc2NvdmVyeS9yZWdpc3RyeS9jb25zdWwvQ29uc3VsUmVnaXN0cnlTZXJ2aWNlSW1wbC5qYXZh) | `64.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...e/seata/discovery/registry/RegistryHeartBeats.java](https://app.codecov.io/gh/apache/incubator-seata/pull/8132?src=pr&el=tree&filepath=discovery%2Fseata-discovery-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fdiscovery%2Fregistry%2FRegistryHeartBeats.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGlzY292ZXJ5L3NlYXRhLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9kaXNjb3ZlcnkvcmVnaXN0cnkvUmVnaXN0cnlIZWFydEJlYXRzLmphdmE=) | `68.96% <100.00%> (ø)` | |
   | [...covery/registry/etcd3/EtcdRegistryServiceImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/8132?src=pr&el=tree&filepath=discovery%2Fseata-discovery-etcd3%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fdiscovery%2Fregistry%2Fetcd3%2FEtcdRegistryServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGlzY292ZXJ5L3NlYXRhLWRpc2NvdmVyeS1ldGNkMy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvZGlzY292ZXJ5L3JlZ2lzdHJ5L2V0Y2QzL0V0Y2RSZWdpc3RyeVNlcnZpY2VJbXBsLmphdmE=) | `75.92% <100.00%> (+0.14%)` | :arrow_up: |
   | [...overy/registry/redis/RedisRegistryServiceImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/8132?src=pr&el=tree&filepath=discovery%2Fseata-discovery-redis%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fdiscovery%2Fregistry%2Fredis%2FRedisRegistryServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGlzY292ZXJ5L3NlYXRhLWRpc2NvdmVyeS1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvZGlzY292ZXJ5L3JlZ2lzdHJ5L3JlZGlzL1JlZGlzUmVnaXN0cnlTZXJ2aWNlSW1wbC5qYXZh) | `66.48% <100.00%> (-5.71%)` | :arrow_down: |
   
   ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8132/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/8132/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/8132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] refactor: merge threadpool and json-common modules [incubator-seata]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #8132:
URL: https://github.com/apache/incubator-seata/pull/8132#discussion_r3457607869


##########
integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/util/JsonUtil.java:
##########
@@ -25,7 +25,7 @@
 import java.util.Objects;
 
 /**
- * @deprecated use {@link org.apache.seata.common.json.JsonUtil} in json-common-core module instead.
+ * @deprecated use {@link org.apache.seata.common.json.JsonUtil} in seata-common module instead.
  */

Review Comment:
   The deprecation Javadoc points to `org.apache.seata.common.json.JsonUtil` but says it lives in the `seata-common` module; in this refactor `JsonUtil` is located under the `seata-core` artifact (it depends on `ConfigurationFactory`). This can mislead users trying to add the right dependency.



##########
discovery/seata-discovery-core/src/main/java/org/apache/seata/discovery/registry/RegistryHeartBeats.java:
##########
@@ -42,8 +43,8 @@ public class RegistryHeartBeats {
     private static final long DEFAULT_HEARTBEAT_PERIOD = 60 * 1000;
     private static final boolean DEFAULT_HEARTBEAT_ENABLED = Boolean.TRUE;
 
-    private static final ScheduledExecutorService HEARTBEAT_SCHEDULED =
-            ThreadPoolExecutorFactory.newScheduledThreadPoolExecutor("seata-discovery-heartbeat", 1, true);
+    private static final ScheduledExecutorService HEARTBEAT_SCHEDULED = new PlatformThreadPoolProvider()
+            .newScheduledThreadPoolExecutor("seata-discovery-heartbeat", 1, true, new ThreadPoolExecutor.AbortPolicy());
 

Review Comment:
   `RegistryHeartBeats` now hard-wires `PlatformThreadPoolProvider`, which bypasses `transport.threadpool` selection (virtual/auto) and will always use platform threads even when the JDK21 provider is on the classpath. If that behavior change is unintended, consider resolving `ThreadPoolProvider` via SPI + config (without depending on `seata-core`) so virtual threads can be used when configured.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] refactor: merge threadpool and json-common modules [incubator-seata]

Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on PR #8132:
URL: https://github.com/apache/incubator-seata/pull/8132#issuecomment-5957014849

   The CI merge failure (missing Fastjson2JsonbParser in seata-serializer-fastjson2) is addressed in 10ca49120. I merged current upstream 2.x and retained the newly added parser and its test in seata-common, consistent with this module consolidation.
   
   Validation of the actual merged tree: clean JDK 17 reactor build across 81 modules, 260 selected tests passing, plus all 3 VirtualThreadPoolProviderTest cases passing on JDK 25. The selected tests include the JSONB RPC and undo-log consumers. The new GitHub CI matrix still needs to complete.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] refactor: merge threadpool and json-common modules [incubator-seata]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #8132:
URL: https://github.com/apache/incubator-seata/pull/8132#discussion_r3369565623


##########
bom/pom.xml:
##########
@@ -48,12 +48,7 @@
             </dependency>
             <dependency>
                 <groupId>org.apache.seata</groupId>
-                <artifactId>seata-threadpool</artifactId>
-                <version>${project.version}</version>
-            </dependency>
-            <dependency>
-                <groupId>org.apache.seata</groupId>
-                <artifactId>seata-threadpool-loom</artifactId>
+                <artifactId>seata-jdk21</artifactId>
                 <version>${project.version}</version>
             </dependency>

Review Comment:
   The BOM manages the version for `seata-jdk21`, but it does not manage the version for the new `seata-jdk17` module. This makes it harder for downstream builds using `seata-bom` to consume the Jackson3/JDK17 extension without adding an explicit version.



##########
core/src/main/java/org/apache/seata/common/thread/ThreadPoolExecutorFactory.java:
##########
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.seata.common.thread;
+
+import org.apache.seata.common.loader.EnhancedServiceLoader;
+import org.apache.seata.common.loader.EnhancedServiceNotFoundException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Objects;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.RejectedExecutionHandler;
+import java.util.concurrent.ScheduledThreadPoolExecutor;
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.ThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Central factory used by Seata managed thread pools.
+ */
+public final class ThreadPoolExecutorFactory {
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(ThreadPoolExecutorFactory.class);
+
+    private ThreadPoolExecutorFactory() {}
+
+    public static ThreadFactory newThreadFactory(String threadPrefix, int totalSize) {
+        return newThreadFactory(threadPrefix, totalSize, true);
+    }
+
+    public static ThreadFactory newThreadFactory(String threadPrefix, int totalSize, boolean daemon) {
+        Objects.requireNonNull(threadPrefix, "threadPrefix must not be null");
+        return new NamedThreadFactory(threadPrefix, totalSize, daemon);
+    }
+
+    public static ThreadPoolExecutor newThreadPoolExecutor(
+            String threadPrefix,
+            int corePoolSize,
+            int maximumPoolSize,
+            long keepAliveTime,
+            TimeUnit unit,
+            BlockingQueue<Runnable> workQueue) {
+        return newThreadPoolExecutor(threadPrefix, corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, true);
+    }
+
+    public static ThreadPoolExecutor newThreadPoolExecutor(
+            String threadPrefix,
+            int corePoolSize,
+            int maximumPoolSize,
+            long keepAliveTime,
+            TimeUnit unit,
+            BlockingQueue<Runnable> workQueue,
+            boolean daemon) {
+        return newThreadPoolExecutor(
+                threadPrefix,
+                corePoolSize,
+                maximumPoolSize,
+                keepAliveTime,
+                unit,
+                workQueue,
+                daemon,
+                new ThreadPoolExecutor.AbortPolicy());
+    }
+
+    public static ThreadPoolExecutor newThreadPoolExecutor(
+            String threadPrefix,
+            int corePoolSize,
+            int maximumPoolSize,
+            long keepAliveTime,
+            TimeUnit unit,
+            BlockingQueue<Runnable> workQueue,
+            RejectedExecutionHandler rejectedHandler) {
+        return newThreadPoolExecutor(
+                threadPrefix, corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, true, rejectedHandler);
+    }
+
+    public static ThreadPoolExecutor newThreadPoolExecutor(
+            String threadPrefix,
+            int corePoolSize,
+            int maximumPoolSize,
+            long keepAliveTime,
+            TimeUnit unit,
+            BlockingQueue<Runnable> workQueue,
+            boolean daemon,
+            RejectedExecutionHandler rejectedHandler) {
+        validateThreadPoolArguments(threadPrefix, corePoolSize, maximumPoolSize, keepAliveTime, unit);
+        return resolveThreadPoolProvider()
+                .newThreadPoolExecutor(
+                        threadPrefix,
+                        corePoolSize,
+                        maximumPoolSize,
+                        keepAliveTime,
+                        unit,
+                        Objects.requireNonNull(workQueue, "workQueue must not be null"),
+                        daemon,
+                        Objects.requireNonNull(rejectedHandler, "rejectedHandler must not be null"));
+    }
+
+    public static ScheduledThreadPoolExecutor newScheduledThreadPoolExecutor(String threadPrefix, int corePoolSize) {
+        return newScheduledThreadPoolExecutor(threadPrefix, corePoolSize, true);
+    }
+
+    public static ScheduledThreadPoolExecutor newScheduledThreadPoolExecutor(
+            String threadPrefix, int corePoolSize, boolean daemon) {
+        return newScheduledThreadPoolExecutor(threadPrefix, corePoolSize, daemon, new ThreadPoolExecutor.AbortPolicy());
+    }
+
+    public static ScheduledThreadPoolExecutor newScheduledThreadPoolExecutor(
+            String threadPrefix, int corePoolSize, boolean daemon, RejectedExecutionHandler rejectedHandler) {
+        validateScheduledThreadPoolArguments(threadPrefix, corePoolSize);
+        return resolveThreadPoolProvider()
+                .newScheduledThreadPoolExecutor(
+                        threadPrefix,
+                        corePoolSize,
+                        daemon,
+                        Objects.requireNonNull(rejectedHandler, "rejectedHandler must not be null"));
+    }
+
+    private static void validateThreadPoolArguments(
+            String threadPrefix, int corePoolSize, int maximumPoolSize, long keepAliveTime, TimeUnit unit) {
+        Objects.requireNonNull(threadPrefix, "threadPrefix must not be null");
+        Objects.requireNonNull(unit, "timeUnit must not be null");
+        if (corePoolSize < 0) {
+            throw new IllegalArgumentException("corePoolSize must not be negative");
+        }
+        if (maximumPoolSize <= 0) {
+            throw new IllegalArgumentException("maximumPoolSize must be greater than zero");
+        }
+        if (maximumPoolSize < corePoolSize) {
+            throw new IllegalArgumentException("maximumPoolSize must be greater than or equal to corePoolSize");
+        }
+        if (keepAliveTime < 0) {
+            throw new IllegalArgumentException("keepAliveTime must not be negative");
+        }
+    }
+
+    private static void validateScheduledThreadPoolArguments(String threadPrefix, int corePoolSize) {
+        Objects.requireNonNull(threadPrefix, "threadPrefix must not be null");
+        if (corePoolSize < 0) {
+            throw new IllegalArgumentException("corePoolSize must not be negative");
+        }
+    }
+
+    private static ThreadPoolProvider resolveThreadPoolProvider() {
+        ThreadPoolType threadPoolType = ThreadPoolRuntimeEnvironment.resolveThreadPoolType();
+        if (threadPoolType == ThreadPoolType.VIRTUAL && ThreadPoolProviderHolder.VIRTUAL_THREAD_POOL_PROVIDER != null) {
+            return ThreadPoolProviderHolder.VIRTUAL_THREAD_POOL_PROVIDER;
+        }
+        if (threadPoolType == ThreadPoolType.VIRTUAL) {
+            // loadOptional() already warned that the provider is absent at initialisation time.
+            // This second warning is intentionally kept to surface the per-request fallback
+            // decision so that operators can correlate the missing-provider startup message
+            // with the actual thread-pool mode that is in effect.
+            LOGGER.warn(
+                    "Virtual thread pool was selected but the virtual-thread SPI provider (seata-threadpool-virtual) "
+                            + "is not present on the classpath. Falling back to platform threads.");

Review Comment:
   The warning message hard-codes a module/artifact name that no longer exists after the refactor ("seata-threadpool-virtual"). Since the virtual thread provider now lives in the `seata-jdk21` module, this log line will mislead operators when diagnosing why virtual threads are not used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] refactor: merge threadpool and json-common modules [incubator-seata]

Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on code in PR #8132:
URL: https://github.com/apache/incubator-seata/pull/8132#discussion_r4167530622


##########
integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/util/JsonUtil.java:
##########
@@ -25,7 +25,7 @@
 import java.util.Objects;
 
 /**
- * @deprecated use {@link org.apache.seata.common.json.JsonUtil} in json-common-core module instead.
+ * @deprecated use {@link org.apache.seata.common.json.JsonUtil} in seata-common module instead.
  */

Review Comment:
   Fixed in 1dc8c4556: the deprecated JsonUtil Javadoc now points to seata-core.



##########
discovery/seata-discovery-core/src/main/java/org/apache/seata/discovery/registry/RegistryHeartBeats.java:
##########
@@ -42,8 +43,8 @@ public class RegistryHeartBeats {
     private static final long DEFAULT_HEARTBEAT_PERIOD = 60 * 1000;
     private static final boolean DEFAULT_HEARTBEAT_ENABLED = Boolean.TRUE;
 
-    private static final ScheduledExecutorService HEARTBEAT_SCHEDULED =
-            ThreadPoolExecutorFactory.newScheduledThreadPoolExecutor("seata-discovery-heartbeat", 1, true);
+    private static final ScheduledExecutorService HEARTBEAT_SCHEDULED = new PlatformThreadPoolProvider()
+            .newScheduledThreadPoolExecutor("seata-discovery-heartbeat", 1, true, new ThreadPoolExecutor.AbortPolicy());
 

Review Comment:
   Fixed in 1dc8c4556: moved the configuration-aware ThreadPoolExecutorFactory and runtime helper (unchanged public package) to seata-config-core, which discovery already depends on. Heartbeat, Consul, Etcd and Redis use the shared factory again; no core/discovery cycle is introduced. Restored 9 missing JSON test classes, retained JsonUtil/configuration tests in core, and fixed the Saga statelang dependency. The 81-module JDK 17 reactor succeeds with 254 selected tests passing. Dependency analysis completes with plugin 3.8.1; PR description now records accurate artifact names, migration instructions and validation limits.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org