You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/05 04:11:11 UTC

[GitHub] [kafka] jasonyanwenl opened a new pull request #11297: KAFKA-10038: Supports default client.id for ConsoleConsumer, ProducerPerformance, ConsumerPerformance

jasonyanwenl opened a new pull request #11297:
URL: https://github.com/apache/kafka/pull/11297


   Currently in `ConsoleConsumer`/`ProducerPerformance`/`ConsolePerformance`, we will not set `client.id` if it is not provided by the user. Simiarly to what we already did for `ConsoleProducer`([code](https://github.com/apache/kafka/blob/99b9b3e84f4e98c3f07714e1de6a139a004cbc5b/core/src/main/scala/kafka/tools/ConsoleProducer.scala#L96)), this PR will set a default value of `client.id` so that we can better support quota testing. The default value is shown as follows:
   * `client.id` in `ConsoleConsumer`: `console-consumer`
   * `client.id` in `ConsumerPerformance`: `perf-consumer-client`
   * `client.id` in `ProducerPerformance`: `perf-producer-client`
   
   New unit testings are added to test both default `client.id` and `client.id` provided by users
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] jasonyanwenl commented on pull request #11297: KAFKA-10038: Supports default client.id for ConsoleConsumer, ProducerPerformance, ConsumerPerformance

Posted by GitBox <gi...@apache.org>.
jasonyanwenl commented on pull request #11297:
URL: https://github.com/apache/kafka/pull/11297#issuecomment-913314815


   Hi @guozhangwang, I saw you are assigned as the reviewer of the ticket [KAFKA-10038](https://issues.apache.org/jira/browse/KAFKA-10038), please help take a look at this PR when you get a chance. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] guozhangwang commented on pull request #11297: KAFKA-10038: Supports default client.id for ConsoleConsumer, ProducerPerformance, ConsumerPerformance

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11297:
URL: https://github.com/apache/kafka/pull/11297#issuecomment-914619982


   Thanks @jasonyanwenl , the PR lgtm, and thank you also for adding the unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] guozhangwang merged pull request #11297: KAFKA-10038: Supports default client.id for ConsoleConsumer, ProducerPerformance, ConsumerPerformance

Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #11297:
URL: https://github.com/apache/kafka/pull/11297


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org