You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/04/02 17:19:53 UTC

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14587: [MXNET-1344, 1346][FIT-API] Retrieve Batch size and Logging verbose support for Gluon fit() API

roywei commented on a change in pull request #14587: [MXNET-1344, 1346][FIT-API] Retrieve Batch size and Logging verbose support for Gluon fit() API
URL: https://github.com/apache/incubator-mxnet/pull/14587#discussion_r271412170
 
 

 ##########
 File path: python/mxnet/gluon/estimator/estimator.py
 ##########
 @@ -334,6 +355,9 @@ def fit(self, train_data,
             if self.stop_training:
                 break
 
+            # Reset batch size since last batch size may be different
+            batch_size = self.train_stats['batch_size']
 
 Review comment:
   here batch size is more like a hyper parameter, we don't want to change it for the last batch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services