You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by st...@apache.org on 2011/02/19 17:58:55 UTC

svn commit: r1072390 - in /myfaces/extensions/cdi/trunk/core: api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/logging/ impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/

Author: struberg
Date: Sat Feb 19 16:58:55 2011
New Revision: 1072390

URL: http://svn.apache.org/viewvc?rev=1072390&view=rev
Log:
EXTCDI-140 use explicit @Dependent in (renamed) LoggerProducer

Added:
    myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/LoggerProducer.java
      - copied, changed from r1072380, myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/InstanceProducer.java
Removed:
    myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/InstanceProducer.java
Modified:
    myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/logging/LoggerDetails.java

Modified: myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/logging/LoggerDetails.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/logging/LoggerDetails.java?rev=1072390&r1=1072389&r2=1072390&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/logging/LoggerDetails.java (original)
+++ myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/logging/LoggerDetails.java Sat Feb 19 16:58:55 2011
@@ -33,7 +33,6 @@ import static java.lang.annotation.Reten
 @Target({PARAMETER, FIELD, METHOD})
 @Retention(RUNTIME)
 @Documented
-
 @Qualifier
 public @interface LoggerDetails
 {

Copied: myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/LoggerProducer.java (from r1072380, myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/InstanceProducer.java)
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/LoggerProducer.java?p2=myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/LoggerProducer.java&p1=myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/InstanceProducer.java&r1=1072380&r2=1072390&rev=1072390&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/InstanceProducer.java (original)
+++ myfaces/extensions/cdi/trunk/core/impl/src/main/java/org/apache/myfaces/extensions/cdi/core/impl/logging/LoggerProducer.java Sat Feb 19 16:58:55 2011
@@ -30,23 +30,25 @@ import javax.enterprise.inject.spi.Injec
  * @author Werner Punz
  */
 @Dependent
-public class InstanceProducer
+public class LoggerProducer
 {
-    private java.util.logging.Logger logger = java.util.logging.Logger.getLogger(InstanceProducer.class.getName());
 
     @Produces
+    @Dependent
     public Logger getLogger(InjectionPoint injectionPoint)
     {
         return new DefaultLogger(injectionPoint.getBean().getBeanClass().getName());
     }
 
     @Produces
+    @Dependent
     public Logger.Factory getLoggerFactory(InjectionPoint injectionPoint)
     {
         return new DefaultLogger(injectionPoint.getBean().getBeanClass().getName()).getFactory();
     }
 
     @Produces
+    @Dependent
     @LoggerDetails
     public Logger getLoggerForDetails(InjectionPoint injectionPoint)
     {
@@ -58,9 +60,10 @@ public class InstanceProducer
 
         if(!logger.isValid())
         {
-            this.logger.warning("an injection point in " + injectionPoint.getBean().getBeanClass().getName() +
-                                " uses an empty qualifier of type " + LoggerDetails.class.getName() +
-                                " - please remove it!");
+            java.util.logging.Logger.getLogger(LoggerProducer.class.getName())
+                    .warning("an injection point in " + injectionPoint.getBean().getBeanClass().getName() +
+                             " uses an empty qualifier of type " + LoggerDetails.class.getName() +
+                             " - please remove it!");
         }
         return logger;
     }