You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/12/27 07:32:48 UTC
[GitHub] sijie commented on a change in pull request #851: Issue 578 : make MajorCompaction controlled by time of the day/day of the week
sijie commented on a change in pull request #851: Issue 578 : make MajorCompaction controlled by time of the day/day of the week
URL: https://github.com/apache/bookkeeper/pull/851#discussion_r158773230
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
##########
@@ -134,15 +142,20 @@ public GarbageCollectorThread(ServerConfiguration conf,
// compaction parameters
minorCompactionThreshold = conf.getMinorCompactionThreshold();
minorCompactionInterval = conf.getMinorCompactionInterval() * SECOND;
- majorCompactionThreshold = conf.getMajorCompactionThreshold();
+ originalMajorCompactionThreshold = majorCompactionThreshold = conf.getMajorCompactionThreshold();
majorCompactionInterval = conf.getMajorCompactionInterval() * SECOND;
+ medianMajorCompactionThreshold = conf.getMedianMajorCompactionThreshold();
Review comment:
do we need to set any constraints between `MajorCompactionInterval` `MedianMajorCompactionInterval` and `HighMajorCompactionInterval`? E.g `MajorCompactionInterval` < `MedianMajorCompactionInterval` < `HighMajorCompactionInterval`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services