You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "RaigorJiang (via GitHub)" <gi...@apache.org> on 2023/02/17 02:42:03 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #24206: Refactor LabelComputeNodeHandler

RaigorJiang opened a new pull request, #24206:
URL: https://github.com/apache/shardingsphere/pull/24206

   For #24181.
   
   Refactor LabelComputeNodeHandler
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #24206: Refactor LabelComputeNodeHandler

Posted by "tristaZero (via GitHub)" <gi...@apache.org>.
tristaZero merged PR #24206:
URL: https://github.com/apache/shardingsphere/pull/24206


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #24206: Refactor LabelComputeNodeHandler

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24206:
URL: https://github.com/apache/shardingsphere/pull/24206#issuecomment-1434037182

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24206?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#24206](https://codecov.io/gh/apache/shardingsphere/pull/24206?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fba0ef0) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a9e1580899a5ec118d80339c0f155791cfe082c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9e1580) will **increase** coverage by `0.00%`.
   > The diff coverage is `44.44%`.
   
   > :exclamation: Current head fba0ef0 differs from pull request most recent head 7096761. Consider uploading reports for the commit 7096761 to get more accurate results
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #24206   +/-   ##
   =========================================
     Coverage     50.12%   50.13%           
     Complexity     1580     1580           
   =========================================
     Files          3255     3255           
     Lines         53473    53474    +1     
     Branches       9856     9856           
   =========================================
   + Hits          26805    26809    +4     
   + Misses        24313    24309    -4     
   - Partials       2355     2356    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `67.85% <ø> (-1.11%)` | :arrow_down: |
   | [...distsql/ral/updatable/LabelComputeNodeUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/24206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9MYWJlbENvbXB1dGVOb2RlVXBkYXRlci5qYXZh) | `35.71% <44.44%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org